Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

2025-04-25 Thread Nizar Benalla
On Thu, 24 Apr 2025 15:55:34 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

2025-04-24 Thread Chen Liang
On Thu, 24 Apr 2025 15:55:34 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v2]

2025-04-24 Thread Nizar Benalla
On Thu, 24 Apr 2025 14:28:21 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

2025-04-24 Thread Hannes Wallnöfer
On Thu, 24 Apr 2025 15:55:34 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

2025-04-24 Thread Nizar Benalla
> Please review this patch to fix a potential infinite loop in > `JavadocTokenizer.ensure` when `map.length` and `size + need` approach > Interger.MAX_VALUE. > > While I couldn't reproduce the issue even with large inputs (~1.9GB java file > where almost the entire file is one javadoc comment),

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v3]

2025-04-24 Thread Nizar Benalla
On Thu, 24 Apr 2025 15:45:48 GMT, Hannes Wallnöfer wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> place negative check in correct position > > src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavadocToke

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v3]

2025-04-24 Thread Hannes Wallnöfer
On Thu, 24 Apr 2025 15:24:35 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v3]

2025-04-24 Thread Nizar Benalla
> Please review this patch to fix a potential infinite loop in > `JavadocTokenizer.ensure` when `map.length` and `size + need` approach > Interger.MAX_VALUE. > > While I couldn't reproduce the issue even with large inputs (~1.9GB java file > where almost the entire file is one javadoc comment),

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v2]

2025-04-24 Thread Nizar Benalla
On Thu, 24 Apr 2025 15:05:50 GMT, Hannes Wallnöfer wrote: >> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> c

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v2]

2025-04-24 Thread Hannes Wallnöfer
On Thu, 24 Apr 2025 14:28:21 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v2]

2025-04-24 Thread Nizar Benalla
> Please review this patch to fix a potential infinite loop in > `JavadocTokenizer.ensure` when `map.length` and `size + need` approach > Interger.MAX_VALUE. > > While I couldn't reproduce the issue even with large inputs (~1.9GB java file > where almost the entire file is one javadoc comment),

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures

2025-04-23 Thread Hannes Wallnöfer
On Tue, 15 Apr 2025 14:12:49 GMT, Vicente Romero wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB jav

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures

2025-04-15 Thread Vicente Romero
On Mon, 14 Apr 2025 10:59:48 GMT, Nizar Benalla wrote: > Please review this patch to fix a potential infinite loop in > `JavadocTokenizer.ensure` when `map.length` and `size + need` approach > Interger.MAX_VALUE. > > While I couldn't reproduce the issue even with large inputs (~1.9GB java file

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures

2025-04-14 Thread Chen Liang
On Mon, 14 Apr 2025 10:59:48 GMT, Nizar Benalla wrote: > Please review this patch to fix a potential infinite loop in > `JavadocTokenizer.ensure` when `map.length` and `size + need` approach > Interger.MAX_VALUE. > > While I couldn't reproduce the issue even with large inputs (~1.9GB java file