RFR: JDK-8319139: Improve diagnosability of `JavadocTester` output

2023-10-31 Thread Jonathan Gibbons
Please review a small update to the output generated by `JavadocTester` when a test fails. Although `JavadocTester` does report a stack trace, it appears after all the content of the failure message, which may be some distance away if the message is long. The `String message` parameter for `pa

RFR: JDK-8319046: Execute tests in source/class-file order in JavadocTester

2023-10-31 Thread Jonathan Gibbons
Please review an update to `JavadocTester` to execute the default set of test methods in source-file order. The order can be changed by overriding the new `getMethodComparator` method. Code is provided, but commented out, to determine the methods in class-file order, for use when the new classf

Re: RFR: JDK-8306980: Generated docs should contain correct Legal Documents [v2]

2023-10-31 Thread Jonathan Gibbons
On Mon, 30 Oct 2023 21:43:11 GMT, Mandy Chung wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review feedback > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java

Re: RFR: JDK-8306980: Generated docs should contain correct Legal Documents [v3]

2023-10-31 Thread Jonathan Gibbons
> Please review an update to the way that `javadoc` handles the default legal > notices when generating docs. > > Previously, the default notices were taken from the module's `legal` > directory (`$JAVA_HOME/legal/jdk.javadoc`), but in some contexts, these files > were either symbolic links, or

Re: RFR: JDK-8306980: Generated docs should contain correct Legal Documents [v3]

2023-10-31 Thread Mandy Chung
On Tue, 31 Oct 2023 20:58:04 GMT, Jonathan Gibbons wrote: >> Please review an update to the way that `javadoc` handles the default legal >> notices when generating docs. >> >> Previously, the default notices were taken from the module's `legal` >> directory (`$JAVA_HOME/legal/jdk.javadoc`), bu

Integrated: JDK-8306980: Generated docs should contain correct Legal Documents

2023-10-31 Thread Jonathan Gibbons
On Wed, 25 Oct 2023 23:06:59 GMT, Jonathan Gibbons wrote: > Please review an update to the way that `javadoc` handles the default legal > notices when generating docs. > > Previously, the default notices were taken from the module's `legal` > directory (`$JAVA_HOME/legal/jdk.javadoc`), but in

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-31 Thread Jaikiran Pai
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: >> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/

Withdrawn: 8306980: Generated docs should contain correct GPLv2 Legal Documents

2023-10-31 Thread KIRIYAMA Takuya
On Thu, 27 Apr 2023 08:02:50 GMT, KIRIYAMA Takuya wrote: > I modified the location from which javadoc copies some legal files to the > generated documentation. If --legal-notices option is set to default or > nothing is specified,, GPLv2 Legal Documents are copied from legal/java.base/ > dire

Re: RFR: 8306980: Generated docs should contain correct GPLv2 Legal Documents [v6]

2023-10-31 Thread KIRIYAMA Takuya
On Tue, 20 Jun 2023 05:07:34 GMT, KIRIYAMA Takuya wrote: >> I modified the location from which javadoc copies some legal files to the >> generated documentation. If --legal-notices option is set to default or >> nothing is specified,, GPLv2 Legal Documents are copied from >> legal/java.base/