Re: RFR: JDK-8323016: Improve reporting for bad options

2024-01-05 Thread Pavel Rappo
On Fri, 5 Jan 2024 00:12:32 GMT, Jonathan Gibbons wrote: > Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word a

Re: RFR: JDK-8323016: Improve reporting for bad options

2024-01-05 Thread Pavel Rappo
On Fri, 5 Jan 2024 00:12:32 GMT, Jonathan Gibbons wrote: > Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word a

RFR: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException

2024-01-05 Thread Pavel Rappo
This PR improves diagnostic output and behaviour of the `TestMethodCommentsAlgorithm` test in environments that do not meet that test's expectations. The test assumes that a correct source file for `java.lang.Object` is available nearby. While the test verified that assumption, it didn't verify

Re: RFR: JDK-8323016: Improve reporting for bad options [v2]

2024-01-05 Thread Jonathan Gibbons
> Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word and a > vocabulary of possibly intended words. It was adde

Re: RFR: JDK-8323016: Improve reporting for bad options [v2]

2024-01-05 Thread Jonathan Gibbons
On Fri, 5 Jan 2024 09:45:34 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> slight simplication for handling suggestions > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java l

Re: RFR: JDK-8323016: Improve reporting for bad options [v2]

2024-01-05 Thread Jonathan Gibbons
On Fri, 5 Jan 2024 10:13:57 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with one >> additional commit since the last revision: >> >> slight simplication for handling suggestions > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java l

Re: RFR: JDK-8323016: Improve reporting for bad options [v3]

2024-01-05 Thread Jonathan Gibbons
> Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word and a > vocabulary of possibly intended words. It was adde

Re: RFR: JDK-8323016: Improve reporting for bad options [v4]

2024-01-05 Thread Jonathan Gibbons
> Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word and a > vocabulary of possibly intended words. It was adde

Re: RFR: JDK-8323016: Improve reporting for bad options [v5]

2024-01-05 Thread Jonathan Gibbons
> Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word and a > vocabulary of possibly intended words. It was adde

Re: RFR: JDK-8323016: Improve reporting for bad options [v5]

2024-01-05 Thread Pavel Rappo
On Fri, 5 Jan 2024 19:59:45 GMT, Jonathan Gibbons wrote: >> Please review a small enhancement when reporting bad options on the command >> line. >> >> [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code >> to help determine a list of suggestions when given a misspelled w

Re: RFR: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException

2024-01-05 Thread Jonathan Gibbons
On Fri, 5 Jan 2024 13:52:23 GMT, Pavel Rappo wrote: > This PR improves diagnostic output and behaviour of the > `TestMethodCommentsAlgorithm` test in environments that do not meet that > test's expectations. > > The test assumes that a correct source file for `java.lang.Object` is > available

Re: RFR: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException

2024-01-05 Thread Jonathan Gibbons
On Fri, 5 Jan 2024 13:52:23 GMT, Pavel Rappo wrote: > This PR improves diagnostic output and behaviour of the > `TestMethodCommentsAlgorithm` test in environments that do not meet that > test's expectations. > > The test assumes that a correct source file for `java.lang.Object` is > available

Re: RFR: 8310277: jdk/javadoc/doclet/testMethodCommentAlgorithm/TestMethodCommentsAlgorithm.java fails with IllegalStateException

2024-01-05 Thread Jonathan Gibbons
On Fri, 5 Jan 2024 13:52:23 GMT, Pavel Rappo wrote: > This PR improves diagnostic output and behaviour of the > `TestMethodCommentsAlgorithm` test in environments that do not meet that > test's expectations. > > The test assumes that a correct source file for `java.lang.Object` is > available

Integrated: JDK-8323016: Improve reporting for bad options

2024-01-05 Thread Jonathan Gibbons
On Fri, 5 Jan 2024 00:12:32 GMT, Jonathan Gibbons wrote: > Please review a small enhancement when reporting bad options on the command > line. > > [JDK-8313693](https://bugs.openjdk.org/browse/JDK-8313693) introduced code to > help determine a list of suggestions when given a misspelled word a