Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-17 Thread Hannes Wallnöfer
On Fri, 8 Dec 2023 05:59:49 GMT, psoujany wrote: >> Interactive component with ARIA role 'tabpanel' does not have a >> programmatically associated name in javadoc which is failing Accessibility >> checks. >> https://bugs.openjdk.org/browse/JDK-8311893 >> https://bugs.openjdk.org/browse/JDK-8311

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-17 Thread Hannes Wallnöfer
On Fri, 8 Dec 2023 05:59:49 GMT, psoujany wrote: >> Interactive component with ARIA role 'tabpanel' does not have a >> programmatically associated name in javadoc which is failing Accessibility >> checks. >> https://bugs.openjdk.org/browse/JDK-8311893 >> https://bugs.openjdk.org/browse/JDK-8311

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-17 Thread psoujany
On Wed, 17 Jan 2024 11:05:57 GMT, Hannes Wallnöfer wrote: >> psoujany has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add accessible name to role=tabpanel > > There are quite a few tests failing because of this change, which need to be

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-17 Thread Hannes Wallnöfer
On Wed, 17 Jan 2024 11:27:52 GMT, psoujany wrote: >> There are quite a few tests failing because of this change, which need to be >> updated once we agree on the proper solution. > > @hns Thanks for your review. Will look into the changes. @psoujany some of the additional changes such as updati

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-17 Thread psoujany
On Wed, 17 Jan 2024 11:54:33 GMT, Hannes Wallnöfer wrote: >> @hns Thanks for your review. Will look into the changes. > > @psoujany some of the additional changes such as updating `script.js` and the > failing tests are probably quite involved and easier to do by someone > familiar with the cod

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v3]

2024-01-17 Thread psoujany
> Interactive component with ARIA role 'tabpanel' does not have a > programmatically associated name in javadoc which is failing Accessibility > checks. > https://bugs.openjdk.org/browse/JDK-8311893 > https://bugs.openjdk.org/browse/JDK-8311894 psoujany has updated the pull request incrementally

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-17 Thread Hannes Wallnöfer
On Wed, 17 Jan 2024 12:11:52 GMT, psoujany wrote: >> @psoujany some of the additional changes such as updating `script.js` and >> the failing tests are probably quite involved and easier to do by someone >> familiar with the code, so I could contribute these changes if that's ok >> with you. >