Please review this jdk24 bug, which we intend to backport to jdk23 before RDP2,
which is a week away. This is a simple fix, but it disturbs multiple tests.
Here's a tip for reviewing. Sometimes a snippet id in a test ends up with
`()1`, other times with `()2`. This is because the same snippet ma
On Thu, 11 Jul 2024 14:07:39 GMT, Pavel Rappo wrote:
> Please review this jdk24 bug, which we intend to backport to jdk23 before
> RDP2, which is a week away. This is a simple fix, but it disturbs multiple
> tests.
>
> Here's a tip for reviewing. Sometimes a snippet id in a test ends up with
> Please review this jdk24 bug, which we intend to backport to jdk23 before
> RDP2, which is a week away. This is a simple fix, but it disturbs multiple
> tests.
>
> Here's a tip for reviewing. Sometimes a snippet id in a test ends up with
> `()1`, other times with `()2`. This is because the sa
On Thu, 11 Jul 2024 15:08:34 GMT, Pavel Rappo wrote:
>> Please review this jdk24 bug, which we intend to backport to jdk23 before
>> RDP2, which is a week away. This is a simple fix, but it disturbs multiple
>> tests.
>>
>> Here's a tip for reviewing. Sometimes a snippet id in a test ends up w
On Thu, 11 Jul 2024 14:43:08 GMT, Chen Liang wrote:
>> Pavel Rappo has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains two
>> new commits
On Wed, 10 Jul 2024 21:47:52 GMT, Jonathan Gibbons wrote:
>> Fixes the link to the generated sealed graph svg generated by the sealed
>> graph taglet.
>>
>> Affected interfaces includes
>> [`ClassFile.Option`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.ba
On Wed, 10 Jul 2024 23:24:43 GMT, Chen Liang wrote:
> Fixes to Javadoc's default documentation on record classes, that all
> primitives are compared as if with their wrapper classes' `compare` method by
> default.
Looks good.
-
Marked as reviewed by prappo (Reviewer).
PR Review:
On Wed, 10 Jul 2024 18:57:22 GMT, Chen Liang wrote:
> Fixes the link to the generated sealed graph svg generated by the sealed
> graph taglet.
>
> Affected interfaces includes
> [`ClassFile.Option`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lan
Please review this build-only change that fixes the link to the SVG sealed
graph by the `@sealedGraph` javadoc taglet. This affects JDK 23 ea
documentation (as shown in #20122) and thus is backported.
-
Commit messages:
- Backport d06d79c80980644df511cded0eb8bc0309d878d3
Changes:
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the ARIA role as global.
> Thanks in advance.
Congrats on becoming a reviewer
-
PR Comment: https://git.openjdk.or
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the ARIA role as global.
> Thanks in advance.
@nizarbenalla
Your change (at version 94c1ca8429fee2da0a9b2da1ce208bed371c2e0d) i
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the ARIA role as global.
> Thanks in advance.
Thank you for your consistent improvement fixes!
-
PR Comment: https
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the ARIA role as global.
> Thanks in advance.
This pull request has now been integrated.
Changeset: 88905571
Author:Nizar B
On Wed, 10 Jul 2024 23:24:43 GMT, Chen Liang wrote:
> Fixes to Javadoc's default documentation on record classes, that all
> primitives are compared as if with their wrapper classes' `compare` method by
> default.
This pull request has now been integrated.
Changeset: b3ef2a60
Author:Chen
Can I please get a review for this small change, the relative link to the
stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
correct link to the stylesheet is already in the generated HTML.
This is the difference between the generated docs before and after this change,
Please review this backport of #20129 to JDK 23, fixing the documentation
Javadoc generates for the default object method implementations in user records
about the comparison behavior for `float` and `double` values.
-
Commit messages:
- Backport b3ef2a600cfec31723dc78fe552e9cf9976
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced by CF API-based ne
On Tue, 12 Mar 2024 22:06:35 GMT, Chen Liang wrote:
>> Please review this patch that fixes placement of type annotations on array
>> types in Javadoc output. This oversight seems to have existed since JDK 8
>> but was never noticed or reported.
>
> Chen Liang has updated the pull request with a
On Fri, 23 Feb 2024 05:44:08 GMT, Chen Liang wrote:
>> Currently in the javadoc tool, the generated class use page does not track
>> the occurrences of a class in the type arguments of the extends or
>> implements list, where they can appear. (See more details on the JBS issue)
>> For example:
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
On Thu, 11 Jul 2024 21:10:43 GMT, Chen Liang wrote:
> Please review this backport of #20129 to JDK 23, fixing the documentation
> Javadoc generates for the default object method implementations in user
> records about the comparison behavior for `float` and `double` values.
Marked as reviewed
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the di
25 matches
Mail list logo
