Re: RFR: 8335870: Doclet should default @since of classes with no @since information to that of the enclosing package

2024-10-08 Thread Hannes Wallnöfer
On Mon, 9 Sep 2024 16:14:47 GMT, Nizar Benalla wrote: > Please review this change to default the value of `@since` to that of the > immediately enclosing package if a class doesn't have the `@since` tag. > > For nested classes, you still need to recursively look for the package so I > had to a

Integrated: 8340203: Link color is hard to distinguish from text color in API documentation

2024-10-08 Thread Hannes Wallnöfer
On Tue, 8 Oct 2024 14:28:44 GMT, Hannes Wallnöfer wrote: > Please review a CSS-only change to make it easier to recognize links in API > documentation with the default stylesheet. > > This subtle change makes the link color a bit lighter and more saturated and > normal text a bit darker. The

Re: RFR: 8340203: Link color is hard to distinguish from text color in API documentation

2024-10-08 Thread Hannes Wallnöfer
On Tue, 8 Oct 2024 14:28:44 GMT, Hannes Wallnöfer wrote: > Please review a CSS-only change to make it easier to recognize links in API > documentation with the default stylesheet. > > This subtle change makes the link color a bit lighter and more saturated and > normal text a bit darker. The

Re: RFR: 8340203: Link color is hard to distinguish from text color in API documentation

2024-10-08 Thread Chen Liang
On Tue, 8 Oct 2024 14:28:44 GMT, Hannes Wallnöfer wrote: > Please review a CSS-only change to make it easier to recognize links in API > documentation with the default stylesheet. > > This subtle change makes the link color a bit lighter and more saturated and > normal text a bit darker. The

RFR: 8340203: Link color is hard to distinguish from text color in API documentation

2024-10-08 Thread Hannes Wallnöfer
Please review a CSS-only change to make it easier to recognize links in API documentation with the default stylesheet. This subtle change makes the link color a bit lighter and more saturated and normal text a bit darker. The new link color is `#437291` which is the same color used for links o

Re: RFR: 8335870: Doclet should default @since of classes with no @since information to that of the enclosing package

2024-10-08 Thread Nizar Benalla
On Tue, 8 Oct 2024 15:09:15 GMT, Hannes Wallnöfer wrote: > Wouldn't this better be done in the getDefaultBlockTags method above so we > don't have to override getBlockTags? I think you're right, I didn't notice this as I was too concerned trying to do micro-optimisations - PR Rev

Re: RFR: 8340203: Link color is hard to distinguish from text color in API documentation

2024-10-08 Thread Pavel Rappo
On Tue, 8 Oct 2024 14:28:44 GMT, Hannes Wallnöfer wrote: > Please review a CSS-only change to make it easier to recognize links in API > documentation with the default stylesheet. > > This subtle change makes the link color a bit lighter and more saturated and > normal text a bit darker. The