Integrated: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java

2025-04-04 Thread Jaikiran Pai
On Tue, 1 Apr 2025 16:25:58 GMT, Jaikiran Pai wrote: > Can I please get a review of this test-only change which proposes to clean up > some issues noticed in the `TestRedirectLinks.java` test? > > The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has been > failing intermittently

Re: RFR: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java [v2]

2025-04-04 Thread Jaikiran Pai
On Wed, 2 Apr 2025 01:41:27 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test-only change which proposes to clean >> up some issues noticed in the `TestRedirectLinks.java` test? >> >> The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has been >> failing intermitt

Re: RFR: 8254622: Hide superclasses from conditionally exported packages

2025-04-04 Thread Chen Liang
On Fri, 4 Apr 2025 13:36:19 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to treat classes and interfaces that are not > included and not unconditionally exported as hidden. This means they do not > show up in the generated documentation even if they are implemented or > extended

Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets

2025-04-04 Thread Erik Joelsson
On Thu, 3 Apr 2025 14:48:58 GMT, Hannes Wallnöfer wrote: > Please review a change to add a `javadoc` option to enable syntax > highlighting for code fragments in snippets and `` tags. The new > `--syntax-highlight` option uses the [highlight.js] JavaScript library and > supports Java, Propert

Re: RFR: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java [v2]

2025-04-04 Thread Nizar Benalla
On Wed, 2 Apr 2025 01:41:27 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test-only change which proposes to clean >> up some issues noticed in the `TestRedirectLinks.java` test? >> >> The `javadoc/doclet/testLinkOption/TestRedirectLinks.java` test has been >> failing intermitt

Re: RFR: 8352511: Show additional level of headings in table of contents [v2]

2025-04-04 Thread Hannes Wallnöfer
On Fri, 21 Mar 2025 05:17:58 GMT, Chen Liang wrote: > Looks good. Since the removal of old push/pop will cause compile errors, I > assume you have updated all legacy sites. This is an internal API that was created specifically for this use and isn't used anywhere else, so we should be fine. -

RFR: 8254622: Hide superclasses from conditionally exported packages

2025-04-04 Thread Hannes Wallnöfer
Please review an enhancement to treat classes and interfaces that are not included and not unconditionally exported as hidden. This means they do not show up in the generated documentation even if they are implemented or extended by a documented type. This change makes the `@hidden` JavaDoc ta

Re: RFR: 8350920: Allow inherited member summaries to be viewed inline [v3]

2025-04-04 Thread Nizar Benalla
On Tue, 25 Mar 2025 04:35:19 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to allow switching between the traditional >> condensed footnote-style summary and the summary table format for inherited >> members (types, fields, methods and properties) that are inherited from >> incl