Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets [v4]

2025-04-25 Thread Nizar Benalla
On Wed, 9 Apr 2025 04:15:20 GMT, Hannes Wallnöfer wrote: >> Please review a change to add a `javadoc` option to enable syntax >> highlighting for code fragments in snippets and `` tags. The new >> `--syntax-highlight` option uses the [highlight.js] JavaScript library and >> supports Java, Pro

Integrated: 8346785: Potential infinite loop in JavadocTokenizer.ensures

2025-04-25 Thread Nizar Benalla
On Mon, 14 Apr 2025 10:59:48 GMT, Nizar Benalla wrote: > Please review this patch to fix a potential infinite loop in > `JavadocTokenizer.ensure` when `map.length` and `size + need` approach > Interger.MAX_VALUE. > > While I couldn't reproduce the issue even with large inputs (~1.9GB java file

Re: RFR: 8346785: Potential infinite loop in JavadocTokenizer.ensures [v4]

2025-04-25 Thread Nizar Benalla
On Thu, 24 Apr 2025 15:55:34 GMT, Nizar Benalla wrote: >> Please review this patch to fix a potential infinite loop in >> `JavadocTokenizer.ensure` when `map.length` and `size + need` approach >> Interger.MAX_VALUE. >> >> While I couldn't reproduce the issue even with large inputs (~1.9GB java

Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets [v4]

2025-04-25 Thread Hannes Wallnöfer
On Thu, 24 Apr 2025 15:22:47 GMT, Nizar Benalla wrote: > I wonder if we can push for the conversion of some `` to > `@snippet` so that we can benefit more from this new feature. I checked some > older classes and the use of `` is still widespread. `` is supported by syntax highlighting, so the

Re: RFR: 8349369: test/docs/jdk/javadoc/doccheck/checks/jdkCheckLinks.java did not report on missing man page files

2025-04-25 Thread Nizar Benalla
On Tue, 4 Feb 2025 14:39:49 GMT, Nizar Benalla wrote: > Please review this small update to make the test more robust, the test did > not always check links to other files if they did not contain a fragment or a > `#`symbol. > > I'd like to add that the original > [doccheck](https://github.com