Re: RFR: 8357869: Remove PreviewNote taglet in its current form

2025-05-28 Thread Hannes Wallnöfer
On Tue, 27 May 2025 22:38:58 GMT, Magnus Ihse Bursie wrote: > Can you really keep the changes to TestPreview.java from JDK-8346109? Yes, the test does not rely on the JDK build taglet, it uses the javadoc `-tag` option to register a generic tag. More importantly, the internal JavaDoc changes i

Integrated: 8357869: Remove PreviewNote taglet in its current form

2025-05-28 Thread Hannes Wallnöfer
On Tue, 27 May 2025 14:38:53 GMT, Hannes Wallnöfer wrote: > Please review a change to remove the `PreviewNote` build taglet as it did not > pass CSR. This is a partial (build changes) undo of > [JDK-8346109](https://bugs.openjdk.org/browse/JDK-8346109). > > The taglet is planned to be reintr

Withdrawn: 8350920: Allow inherited member summaries to be viewed inline

2025-05-28 Thread Hannes Wallnöfer
On Mon, 10 Mar 2025 15:41:58 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to allow switching between the traditional > condensed footnote-style summary and the summary table format for inherited > members (types, fields, methods and properties) that are inherited from > included

Re: RFR: 8350920: Allow inherited member summaries to be viewed inline [v6]

2025-05-28 Thread Hannes Wallnöfer
On Fri, 9 May 2025 15:24:39 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to allow switching between the traditional >> condensed footnote-style summary and the summary table format for inherited >> members (types, fields, methods and properties) that are inherited from >> inclu

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-28 Thread Phil Race
On Mon, 26 May 2025 07:55:52 GMT, Magnus Ihse Bursie wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Restore MenuShortcut.java >> - Restore LocaleDataTest.java > > test/jdk/java/awt/event/KeyEvent/KeyTyped

Re: RFR: 8356977: UTF-8 cleanups [v2]

2025-05-28 Thread Phil Race
On Mon, 26 May 2025 08:07:19 GMT, Magnus Ihse Bursie wrote: >> test/jdk/java/awt/font/TextLayout/RotFontBoundsTest.java line 63: >> >>> 61: >>> 62: private static final String INSTRUCTIONS = >>> 63: "A string \u201C" + TEXT + "\u201D is drawn at eight >>> different " >> >> I r

Re: RFR: 8177100: APIs duplicated in JavaDoc [v5]

2025-05-28 Thread Hannes Wallnöfer
On Mon, 12 May 2025 14:46:39 GMT, Nizar Benalla wrote: >> Please review this patch to fix a bug where a method can be documented >> multiple times >> Consider these 4 classes >> >> A (interface) >>/ \ >> / \ >> (abstract class)