Re: RFR: 8356975: Provide alternative way to generate preview API docs [v2]

2025-07-15 Thread Roger Riggs
On Tue, 15 Jul 2025 11:04:05 GMT, Hannes Wallnöfer wrote: >> Please review a change to allow marking API elements as preview features via >> a new hidden `--preview-feature-tag` option. In conjunction with the already >> existing hidden `--preview-note-tag` option this allows documenting elemen

Re: RFR: 8356975: Provide alternative way to generate preview API docs [v2]

2025-07-15 Thread Hannes Wallnöfer
> Please review a change to allow marking API elements as preview features via > a new hidden `--preview-feature-tag` option. In conjunction with the already > existing hidden `--preview-note-tag` option this allows documenting elements > as preview features without relying on JDK-internal types

Re: RFR: 8356975: Provide alternative way to generate preview API docs [v2]

2025-07-15 Thread Hannes Wallnöfer
On Sat, 12 Jul 2025 22:09:42 GMT, Chen Liang wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add warning for multiple preview notes > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Ht

Re: RFR: 8342705: Add dark mode for docs

2025-07-15 Thread Hannes Wallnöfer
On Tue, 8 Jul 2025 13:22:20 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to add a dark theme to javadoc-generated API > documentation. There is a new button in the top right corner that brings up a > menu to switch between themes. Available options are "Light", "Dark", and > "Sy

Re: RFR: 8342705: Add dark mode for docs

2025-07-15 Thread Nizar Benalla
On Tue, 8 Jul 2025 13:22:20 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to add a dark theme to javadoc-generated API > documentation. There is a new button in the top right corner that brings up a > menu to switch between themes. Available options are "Light", "Dark", and > "Sy

Re: RFR: 8356975: Provide alternative way to generate preview API docs [v2]

2025-07-15 Thread Chen Liang
On Tue, 15 Jul 2025 11:04:05 GMT, Hannes Wallnöfer wrote: >> Please review a change to allow marking API elements as preview features via >> a new hidden `--preview-feature-tag` option. In conjunction with the already >> existing hidden `--preview-note-tag` option this allows documenting elemen

Re: RFR: 8356975: Provide alternative way to generate preview API docs [v2]

2025-07-15 Thread Hannes Wallnöfer
On Tue, 15 Jul 2025 13:03:47 GMT, Chen Liang wrote: > Looks good to me. Let's see if this requires a CSR before we proceed. It's a hidden option, so it shouldn't require a CSR. - PR Comment: https://git.openjdk.org/jdk/pull/26267#issuecomment-3073909622

Re: RFR: 8356975: Provide alternative way to generate preview API docs [v2]

2025-07-15 Thread Chen Liang
On Tue, 15 Jul 2025 11:04:05 GMT, Hannes Wallnöfer wrote: >> Please review a change to allow marking API elements as preview features via >> a new hidden `--preview-feature-tag` option. In conjunction with the already >> existing hidden `--preview-note-tag` option this allows documenting elemen

RFR: 8361366: Allow sorting of member details in lexicographical order

2025-07-15 Thread Nizar Benalla
Please review this patch to add a toggle to order the member details in the table of contents in lexical order - Commit messages: - add toggle to sort TOC in lexical order Changes: https://git.openjdk.org/jdk/pull/26322/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26322