Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

> On Jun 16, 2016, at 7:28 PM, Jonathan Gibbons > wrote: > > Please review this simple fix for two related aspects of the same problem: > > Export the "standard doclet" used by javadoc, such that it is possible to > derive alternative doclets, either by

Request Review JDK-8182492: docs bundle needs legal notices for 3rd party libraries distributed for javadoc search

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182492/webrev.00/ JDK docs build enables javadoc search that distributes jquery and jszip. The docs bundle needs to include legal notices for these 3rd party libraries. In addition, pako.md is missing and fixed in this patch. Mandy

Re: RFR: 8195795: Organize javadoc output files by module/package, not just package

$MODULE-graph.png to $MODULE/module-graph.png change looks fine. Mandy On 2/2/18 1:42 PM, Jonathan Gibbons wrote: Please review changes, including a couple of small build changes, to reorganize the generated documentation into per-module directories. Build folk: the changes are just to move

Re: RFR: [small, docs] JDK-8240971 Fix CSS styles in some doc comments

This change looks okay. Mandy On 3/12/20 1:50 PM, Jonathan Gibbons wrote: Please review a simple fix regarding the non-standard use of some CSS in some doc comments. From the JBS Description: Recently, for the display of javadoc block tags, javadoc changed from using an inconsistent set of

Re: RFR: 8246774: Record Classes (final) implementation

On Tue, 22 Sep 2020 09:49:12 GMT, Chris Hegarty wrote: >> note: I have removed from the original patch the code related to >> javax.lang.model, I will publish them in a separate PR > > @vicente-romero-oracle I noticed that we can also remove the preview args > from the record serialization

Re: RFR: 8246774: Record Classes (final) implementation

On Thu, 24 Sep 2020 00:23:13 GMT, Mandy Chung wrote: >> @vicente-romero-oracle I noticed that we can also remove the preview args >> from the record serialization tests and >> ObjectMethodsTest. I opened a PR against the branch in your fork. You should >> be able to j

Re: RFR: 8267184: JEP 411: Add -Djava.security.manager=allow to tests calling System.setSecurityManager

On Mon, 17 May 2021 17:51:36 GMT, Weijun Wang wrote: > Please review the test changes for [JEP > 411](https://openjdk.java.net/jeps/411). > > With JEP 411 and the default value of `-Djava.security.manager` becoming > `disallow`, tests calling `System.setSecurityManager()` need >

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >>

Re: RFR: JDK-8280534: Enable compile-time doclint reference checking

On Wed, 26 Jan 2022 20:05:07 GMT, Joe Darcy wrote: > The changes in this PR on top of the out-for-review changes in > https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint > checking to be enabled in all JDK modules. > > Typically, a @SuppressWarnings("doclint:refernce")