Re: RFR: JDK-8223536 jdk/javadoc/doclet/MetaTag/MetaTag.java still fails when run across midnight

2020-01-15 Thread Jonathan Gibbons
Roger, Thanks for the suggestion. The old code used Calendar, but deep down in the impl, I see even that used Date.   Given that the requirements are very very low, that the code is not using any Deprecated methods on Date, and the difficulty of reliably testing in this area, it seemed like

Re: RFR: JDK-8223536 jdk/javadoc/doclet/MetaTag/MetaTag.java still fails when run across midnight

2020-01-15 Thread Jonathan Gibbons
Thanks. -- Jon On 1/15/20 5:51 AM, Pavel Rappo wrote: Three dates are created in succession: (1) `startDate` on MetaTag:103, (2) `startTime` on HtmlConfiguration:265, and `date` on MetaTag:95. If dates (1) and (3) are equal, we then conclude that (2) must be the same as (1) and (3). If I

Re: RFR: JDK-8223536 jdk/javadoc/doclet/MetaTag/MetaTag.java still fails when run across midnight

2020-01-15 Thread Pavel Rappo
Three dates are created in succession: (1) `startDate` on MetaTag:103, (2) `startTime` on HtmlConfiguration:265, and `date` on MetaTag:95. If dates (1) and (3) are equal, we then conclude that (2) must be the same as (1) and (3). If I read the intent correctly, this implication warrants the

RFR: JDK-8223536 jdk/javadoc/doclet/MetaTag/MetaTag.java still fails when run across midnight

2020-01-14 Thread Jonathan Gibbons
Please review a fix for a problem that occurs when a test is run across midnight. Although it is difficult to confirm the root cause, and equally difficult to test, the root cause is believed to be a static final instance of java.util.Calendar that is used to obtain the date written into the