Hannes,
Thanks for the review.
I did have a separate discussion yesterday with Pavel about the relative
merits of adding items to the style sheet vs adding stuff into the test.
At that time, I did not understand the use of all the names as well as I
do now, and I was not comfortable adding st
Pavel,
Thanks, I'll address the "Nit" you raised and follow your suggestions.
-- Jon
On 3/25/20 8:53 AM, Pavel Rappo wrote:
Hi Jon,
It's nice to see this change addresses a visual regression caused by the recent
changes. Thanks for providing detailed comments for "additional class names"
in t
Should have read *unstyled* classes but autocorrect thought that’s not a word.
> Am 25.03.2020 um 16:50 schrieb Hannes Wallnöfer
> :
>
> ... for those unsettled classes ...
>
Hi Jon,
It's nice to see this change addresses a visual regression caused by the recent
changes. Thanks for providing detailed comments for "additional class names"
in the new test.
Nit. Could you change the name of `addExtraCSSClassNames` to
`addExtraCSSClassNamesTo`
or, better still, rename it
+1 and good catch, Jon! I feel guilty for not spotting the visual changes in
the docs previously.
The new test is nice. I wonder if we should add empty declarations to the style
sheet for those unsettled classes, maybe even with a short comment about where
it is used. That would make using the
I forgot to add the bug number into the @bug list in the test. I'll do
that in the next webrev (if one is needed) or before pushing.
-- Jon
On 3/24/20 3:45 PM, Jonathan Gibbons wrote:
Please review some simple fixes to the stylesheet to address some
issues caused by a couple of recent changes
