View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3820613#3820613
Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3820613 As a start to the discussion of how to unify the invocation and interceptor layers used in the aop, jmx, remoting and server frameworks, here are the some base classes derived from the current aop layer. We need to come to a consenus on what the comment layer should look like. This layer should be in the jmx module. /** Pretty basic common interface */ public interface Interceptor { public String getName(); public Object invoke(Invocation invocation) throws Throwable; } /** An encapsulation of the response: (value or exception) + attributes */ public class InvocationResponse implements java.io.Externalizable { // Constants ----------------------------------------------------- static final long serialVersionUID = -718723094688127810L; // The Map of methods used by this Invocation protected HashMap contextInfo = null; protected Object response = null; protected Throwable responseThrowable; public HashMap getContextInfo() { return contextInfo; } public void setContextInfo(HashMap contextInfo) { this.contextInfo = contextInfo; } // Constructors -------------------------------------------------- public InvocationResponse() { } public InvocationResponse(Object obj) { this.response = obj; } public Object getResponse() { return response; } public void setResponse(Object obj) { this.response = obj; } public Throwable getResponseThrowable { return responseThrowable; } public void setResponseThrowable(Throwable cause) { this.responseThrowable = cause; } public void addAttachment(Object key, Object val) { if (contextInfo == null) contextInfo = new HashMap(1); contextInfo.put(key, val); } public Object getAttachment(Object key) { if (contextInfo == null) return null; return contextInfo.get(key); } // Externalizable implementation --------------------------------- public void writeExternal(java.io.ObjectOutput out) throws IOException { ... } public void readExternal(java.io.ObjectInput in) throws IOException, ClassNotFoundException { ... } } /** This class varies significantly... Here is a variation from the aop layer. */ public class Invocation implements java.io.Serializable { protected InvocationType type; protected MetaData metadata = null; protected transient int currentInterceptor = 0; protected transient Interceptor[] interceptors = null; protected transient Object targetObject = null; protected transient InvocationResponse response; public Invocation(InvocationType type, Interceptor[] interceptors) { this(type, interceptors, null); } public Invocation(InvocationType type, Interceptor[] interceptors, MetaData meta) { this.interceptors = interceptors; this.type = type; this.metadata = meta; } public Invocation(Invocation invocation) { this.type = invocation.getType(); this.interceptors = invocation.getInterceptors(); targetObject = invocation.targetObject; } public final InvocationType getType() { return type; } public Object getTarget() { return targetObject; } public void setTarget(Object target) { this.targetObject = target; } public final InvocationResponse getResponse() { if( response == null ) response = new InvocationResponse(); return response; } public final void addResponseAttachment(Object key, Object val) { getResponse().addAttachment(key, val); } public final Object getResponseAttachment(Object key) { Object val = getResponse().getAttachment(key); return val; } /** * Return all the contextual data attached to this invocation */ public final MetaData getMetaData() { if (metadata == null) metadata = new SimpleMetaData(); return metadata; } /** * Set all the contextual data attached to this invocation */ public final void setMetaData(MetaData data) { this.metadata = data; } /** * Invoke on the next interceptor in the chain. If this is already * the end of the chain, reflection will call the constructor, field, or * method you are invoking on. */ public final Object invokeNext() throws Throwable { try { return interceptors[currentInterceptor++].invoke(this); } finally { // so that interceptors like clustering can reinvoke down the chain currentInterceptor--; } } /** Is this useful? * */ public final Object invokeNext(org.jboss.aop.advice.Interceptor[] newInterceptors) throws Throwable { // Save the old stack position org.jboss.aop.advice.Interceptor[] oldInterceptors = interceptors; int oldCurrentInterceptor = currentInterceptor; // Start the new stack interceptors = newInterceptors; currentInterceptor = 0; // Invoke the new stack try { return invokeNext(); } finally { // Restore the old stack interceptors = oldInterceptors; currentInterceptor = oldCurrentInterceptor; } } public final Interceptor[] getInterceptors() { return interceptors; } public final void setInterceptors(Interceptor[] interceptors) { this.interceptors = interceptors; } /** * This method resolves metadata based on the context of the invocation. * It iterates through its list of MetaDataResolvers to find out the * value of the metadata desired. Can't these be embedded in the metadata? * */ public Object getMetaData(Object group, Object attr) { Object val = null; if (this.metadata != null) { val = this.metadata.resolve(this, group, attr); if (val != null) return val; } return null; } } /** Why should MetaData know how to resolve which meta data is needed for a a given invocation? */ public class SimpleMetaData implements MetaDataResolver, java.io.Serializable { protected HashMap metaData = new HashMap(); public static class MetaDataValue implements java.io.Serializable { public final PayloadKey type; // One of "TRANSIENT", "AS_IS", "MARSHALLED" public final Object value; public MetaDataValue(PayloadKey type, Object value) { this.type = type; this.value = value; } public Object get() throws IOException, ClassNotFoundException { if (value instanceof MarshalledValue) { return ((MarshalledValue)value).get(); } return value; } } public synchronized HashSet groups() { return new HashSet(metaData.keySet()); } public synchronized HashMap group(String name) { HashMap map = (HashMap)metaData.get(name); if (map == null) return null; return (HashMap)map.clone(); } public synchronized boolean hasGroup(String name) { return metaData.get(name) != null; } public void addMetaData(Object group, Object attr, Object value) { addMetaData(group, attr, value, PayloadKey.MARSHALLED); } public synchronized void addMetaData(Object group, Object attr, Object value, PayloadKey type) { HashMap groupData = (HashMap)metaData.get(group); if (groupData == null) { groupData = new HashMap(); metaData.put(group, groupData); } MetaDataValue val = new MetaDataValue(type, value); groupData.put(attr, val); } public synchronized Object getMetaData(Object group, Object attr) { try { HashMap groupData = (HashMap)metaData.get(group); if (groupData == null) return null; MetaDataValue val = (MetaDataValue)groupData.get(attr); if (val == null) return null; return val.get(); } catch (IOException ioex) { throw new RuntimeException("failed on MarshalledValue", ioex); } catch (ClassNotFoundException ex) { throw new RuntimeException("failed on MarshalledValue", ex); } } public synchronized void removeMetaData(Object group, Object attr) { HashMap groupData = (HashMap)metaData.get(group); if (groupData != null) { groupData.remove(attr); } } public synchronized void removeGroupData(Object group) { metaData.remove(group); } public synchronized void clear() { metaData.clear(); } /** * merges incoming data. Incoming data overrides existing data */ public synchronized void mergeIn(SimpleMetaData data) { Iterator it = data.metaData.keySet().iterator(); while (it.hasNext()) { Object group = it.next(); HashMap attrs = (HashMap)data.metaData.get(group); HashMap map = (HashMap)metaData.get(group); if (map == null) { map = new HashMap(); this.metaData.put(group, map); } map.putAll(attrs); } } public synchronized Object resolve(Invocation invocation, Object group, Object attr) { return getMetaData(group, attr); } public SimpleMetaData getAllMetaData(Invocation invocation) { return this; } public void writeExternal(java.io.ObjectOutput out) throws IOException { ... } public void readExternal(java.io.ObjectInput in) throws IOException, ClassNotFoundException { ... } } public abstract class Dispatcher { HashMap targetMap = new HashMap(); public boolean isRegistered(Object oid) { synchronized (targetMap) { return targetMap.containsKey(oid); } } /** * Register an Object ID with an actual target object */ public void registerTarget(Object oid, Object target) { synchronized (targetMap) { targetMap.put(oid, target); } } public void unregisterTarget(Object oid) { synchronized (targetMap) { targetMap.remove(oid); } } public Object getRegistered(Object oid) { synchronized (targetMap) { return targetMap.get(oid); } } public InvocationResponse invoke(Invocation invocation) throws Throwable { Invocation invocation = processInvocation(); InvocationReponse response; try { Object target = findTarget(invocation); invocation.setTarget(target); Object result = dispatch(invocation); response = invocation.getOrCreateResponse(); response.setResult(result); } catch (Throwable t) { response = invocation.getOrCreateResponse(); response.setThrowable(t) } return response; } public abstract Invocation processInvocation(); public abstract Object findTarget(Invocation inv, Dispatcher d); public abstract Object dispatch(Invocation inv) throws Throwable; } ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ JBoss-Development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
