Re: [JBoss-dev] Fwd: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc JDBCLoadEntityCommand.java

2002-10-14 Thread Alex Loubyansky 

AB Without the !isReadOnly() check, the preloaded readahead fields
AB were ignored.

Exactly. My mistake. When fixing read-only/read-time-out fields
loading I made rw fields to be loaded always. Sorry. I'll correct it
in other branches.

But in fresh Branch_3_2
org.jboss.test.cmp2.readonly.ReadonlyUnitTestCase fails with due to
EJBTestRunner not bound.
I'll try to figure out, but if someone knows the cause, please, let me
know.

Thanks.

alex


EJBTestRunner not bound

javax.naming.NameNotFoundException: EJBTestRunner not bound
at 
sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:245)
at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:220)
at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:122)
at org.jnp.server.NamingServer_Stub.lookup(Unknown Source)
at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:456)
at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:440)
at javax.naming.InitialContext.lookup(InitialContext.java:350)
at net.sourceforge.junitejb.EJBTestCase.getEJBTestRunner(EJBTestCase.java:162)
at net.sourceforge.junitejb.EJBTestCase.runBare(EJBTestCase.java:109)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:131)
at net.sourceforge.junitejb.EJBTestCase.run(EJBTestCase.java:95)
at junit.framework.TestSuite.runTest(TestSuite.java:173)
at junit.framework.TestSuite.run(TestSuite.java:168)
at junit.framework.TestSuite.runTest(TestSuite.java:173)
at junit.framework.TestSuite.run(TestSuite.java:168)
at junit.extensions.TestDecorator.basicRun(TestDecorator.java:22)
at junit.extensions.TestSetup$1.protect(TestSetup.java:19)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.extensions.TestSetup.run(TestSetup.java:23)
at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:325)
at 
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:524)


AB Regards,
AB Adrian

From: Adrian Brock [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc 
JDBCLoadEntityCommand.java
Date: Sun, 13 Oct 2002 15:53:53 -0700

   User: ejort
   Date: 02/10/13 15:53:53

   Modified:src/main/org/jboss/ejb/plugins/cmp/jdbc Tag: Branch_3_2
 JDBCLoadEntityCommand.java
   Log:
   Fix readahead and load-groups

   Revision  ChangesPath
   No   revision


   No   revision


   1.19.2.4  +6 -2  
jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCLoadEntityCommand.java

   Index: JDBCLoadEntityCommand.java
   ===
   RCS file: 
/cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCLoadEntityCommand.java,v
   retrieving revision 1.19.2.3
   retrieving revision 1.19.2.4
   diff -u -r1.19.2.3 -r1.19.2.4
   --- JDBCLoadEntityCommand.java  5 Oct 2002 10:18:08 -   1.19.2.3
   +++ JDBCLoadEntityCommand.java  13 Oct 2002 22:53:53 -  1.19.2.4
   @@ -40,7 +40,7 @@
 * @author a href=mailto:[EMAIL PROTECTED];Justin Forder/a
 * @author a href=mailto:[EMAIL PROTECTED];Dirk Zimmermann/a
 * @author a href=mailto:[EMAIL PROTECTED];danch (Dan 
Christopherson)/a
   - * @version $Revision: 1.19.2.3 $
   + * @version $Revision: 1.19.2.4 $
 */
public class JDBCLoadEntityCommand {
   private final JDBCStoreManager manager;
   @@ -286,7 +286,11 @@
 // - it is already loaded
 // - it is a read-only _already_loaded_ field that isn't timed 
out yet
 if( field.isPrimaryKeyMember()
   -|| ( field.isLoaded( ctx )  !field.isReadTimedOut( ctx ) 
)) {
   +|| ( field.isLoaded( ctx )
   + ( !field.isReadOnly() || !field.isReadTimedOut( ctx 
) )
   +   )
   +   )
   + {
fields.remove();
 }
  }


-- 
Best regards,
 Alex Loubyansky




---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development

Re: [JBoss-dev] Fwd: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc JDBCLoadEntityCommand.java

2002-10-13 Thread Alex Loubyansky 

Hello Adrian,

sorry, I saw cvs-commits first and wrote to you personally.
I'll try to figure out.
in isReadTimedOut( ctx ) isReadOnly( ctx ) is checked.
Weird...

alex

Monday, October 14, 2002, 2:07:48 AM, you wrote:

AB Hi,

AB Could one of the CMP experts check this fix? It is in 3.2 only.

AB Without the !isReadOnly() check, the preloaded readahead fields
AB were ignored.

AB Regards,
AB Adrian

From: Adrian Brock [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [jboss-cvs] jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc 
JDBCLoadEntityCommand.java
Date: Sun, 13 Oct 2002 15:53:53 -0700

   User: ejort
   Date: 02/10/13 15:53:53

   Modified:src/main/org/jboss/ejb/plugins/cmp/jdbc Tag: Branch_3_2
 JDBCLoadEntityCommand.java
   Log:
   Fix readahead and load-groups

   Revision  ChangesPath
   No   revision


   No   revision


   1.19.2.4  +6 -2  
jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCLoadEntityCommand.java

   Index: JDBCLoadEntityCommand.java
   ===
   RCS file: 
/cvsroot/jboss/jboss/src/main/org/jboss/ejb/plugins/cmp/jdbc/JDBCLoadEntityCommand.java,v
   retrieving revision 1.19.2.3
   retrieving revision 1.19.2.4
   diff -u -r1.19.2.3 -r1.19.2.4
   --- JDBCLoadEntityCommand.java  5 Oct 2002 10:18:08 -   1.19.2.3
   +++ JDBCLoadEntityCommand.java  13 Oct 2002 22:53:53 -  1.19.2.4
   @@ -40,7 +40,7 @@
 * @author a href=mailto:[EMAIL PROTECTED];Justin Forder/a
 * @author a href=mailto:[EMAIL PROTECTED];Dirk Zimmermann/a
 * @author a href=mailto:[EMAIL PROTECTED];danch (Dan 
Christopherson)/a
   - * @version $Revision: 1.19.2.3 $
   + * @version $Revision: 1.19.2.4 $
 */
public class JDBCLoadEntityCommand {
   private final JDBCStoreManager manager;
   @@ -286,7 +286,11 @@
 // - it is already loaded
 // - it is a read-only _already_loaded_ field that isn't timed 
out yet
 if( field.isPrimaryKeyMember()
   -|| ( field.isLoaded( ctx )  !field.isReadTimedOut( ctx ) 
)) {
   +|| ( field.isLoaded( ctx )
   + ( !field.isReadOnly() || !field.isReadTimedOut( ctx 
) )
   +   )
   +   )
   + {
fields.remove();
 }
  }





---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
jboss-cvs-commits mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-cvs-commits




AB _
AB Chat with friends online, try MSN Messenger: http://messenger.msn.com


-- 
Best regards,
 Alex Loubyansky




---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
Jboss-development mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jboss-development