Re: [JBoss-dev] message selectors

2002-02-14 Thread Dave Smith
Go nuts. I have only used bison and flex and I have some pressing other stuff to do now. The current problem with the message selectors is that text is returned with the ' . So app_id='my app' turns into EQUAL( Start Identifier@app_id Start 'my app' Now it looks like the STRING token should

Re: [JBoss-dev] message selectors

2002-02-14 Thread Jason Dillon
You are including the ' in the token spec, so if you simple take the value of that token then it will have '' in it. --jason On Thu, 2002-02-14 at 06:01, Dave Smith wrote: Go nuts. I have only used bison and flex and I have some pressing other stuff to do now. The current problem with the

Re: [JBoss-dev] message selectors

2002-02-14 Thread Jason Dillon
I updated the SelectorParser for this boolean issue (based on Dains email). I also added a testcase (testsuite/src/main/org/jboss/test/jbossmq/test/SelectorSyntaxTestCase.java) to test that it works. If you find other problems please update/patch this testcase, so we can catch it when it

Re: [JBoss-dev] message selectors

2002-02-13 Thread Jason Dillon
What version of JBoss are you using? --jason On Wed, 2002-02-13 at 16:53, Dave Smith wrote: After having a bad day trying to get a message selector working for a topic listener I came across a few bugs. 1) If the message selector is invalid but the connection is not started but no

Re: [JBoss-dev] message selectors

2002-02-13 Thread Dave Smith
CVS as off 5pm EST Feb13 Jason Dillon wrote: What version of JBoss are you using? --jason On Wed, 2002-02-13 at 16:53, Dave Smith wrote: After having a bad day trying to get a message selector working for a topic listener I came across a few bugs. 1) If the message selector is

Re: [JBoss-dev] message selectors

2002-02-13 Thread Jason Dillon
I did not think we were using the old parser anymore... Is there a reason this is still around after Scott reimplemented in JavaCC? --jason On Wed, 2002-02-13 at 16:53, Dave Smith wrote: After having a bad day trying to get a message selector working for a topic listener I came across a few

Re: [JBoss-dev] message selectors

2002-02-13 Thread Jason Dillon
Please submit a bug for this. --jason On Wed, 2002-02-13 at 16:53, Dave Smith wrote: After having a bad day trying to get a message selector working for a topic listener I came across a few bugs. 1) If the message selector is invalid but the connection is not started but no error is

Re: [JBoss-dev] message selectors

2002-02-13 Thread Dave Smith
Actually it's worse than that. If you change the default parser to SelectorParser, nothing works! So a simple slector like type='cadex' bombs. Jason Dillon wrote: I did not think we were using the old parser anymore... Is there a reason this is still around after Scott reimplemented in

Re: [JBoss-dev] message selectors

2002-02-13 Thread Jason Dillon
How about making us a MessageSelectorTestCase so we can catch this next time. I am about to commit a fix to the build system so that changes to jms.jj actually will get used, as well as making SelectorParser the default. Going to keep parser.java jms.y around for a bit, but once the javacc one

Re: [JBoss-dev] message selectors

2002-02-13 Thread Jason Dillon
Can you please verify that things are still broken with the latest CVS (with the changes I just commited). Please submit a testcase, if you are in there and finding problems just throw something together and submit it. --jason On Wed, 2002-02-13 at 17:52, Dave Smith wrote: Actually it's

Re: [JBoss-dev] message selectors

2002-02-13 Thread Dave Smith
OK. it looks like it does not like the BOOLEAN token as a combo fo the TRUE and FALSE tokens. Inlining them works. Patch inclosed. Now the selector will parse but still does not deliver it properly. Going to bed , have a look in the morning... Dave Smith wrote: Ok. First problem solved. We

Re: [JBoss-dev] message selectors

2002-02-13 Thread Dain Sundstrom
According to the JMS spec the reserved words are case insensitive. A part of the TOKEN spec I use in the new EJB-QL parser follows: TOKEN [IGNORE_CASE] : /* RESERVED WORDS */ { FALSE: FALSE | NOT: NOT | NULL: NULL | TRUE: TRUE } The boolean declaration won't work because you

Re: [JBoss-dev] message selectors

2002-02-13 Thread Jason Dillon
If you have a chance, sanity check messaging/src/main/org/jboss/mq/selectors/SelectorParser.jj It has been at least 2 years since I did any active JavaCC work. --jason On Wed, 2002-02-13 at 23:01, Dain Sundstrom wrote: According to the JMS spec the reserved words are case insensitive. A