Re: [JBoss-dev] Re: [jboss-cvs] jboss-transaction/src/main/org/jboss/tm TransactionImpl.java

2002-07-18 Thread Ole Husgaard
Dain Sundstrom wrote: Ole Husgaard wrote: + // Using the construct + // try { + // txCapsule.doSomething(); + // } catch (NullPointerException ex) { + // throw new IllegalStateException(No transaction.); + // } + // may look like bad

RE: [JBoss-dev] Re: [jboss-cvs] jboss-transaction/src/main/org/jboss/tm TransactionImpl.java

2002-07-18 Thread marc fleury
Maybe we should be a little more restrictive than JTA here, and only allow reentrant calls to the transaction service during the callouts when done on the same thread. I think that would allow us to simply synchronize on the methods of the TransactionImpl frontend. The downside of

Re: [JBoss-dev] Re: [jboss-cvs] jboss-transaction/src/main/org/jboss/tm TransactionImpl.java

2002-07-18 Thread Dain Sundstrom
marc fleury wrote: Maybe we should be a little more restrictive than JTA here, and only allow reentrant calls to the transaction service during the callouts when done on the same thread. I think that would allow us to simply synchronize on the methods of the TransactionImpl frontend. The

Re: [JBoss-dev] Re: [jboss-cvs] jboss-transaction/src/main/org/jboss/tm TransactionImpl.java

2002-07-18 Thread Ole Husgaard
Kevin Conner wrote: As an aside, having just looked at the 3.0.1 code (this may have changed since then), commit, delistResource, enlistResource, registerSynchronization, rollback and setRollbackOnly are protected by the lock method (and hence synchronisation). Until my recent commit, the

RE: [JBoss-dev] Re: [jboss-cvs] jboss-transaction/src/main/org/jboss/tm TransactionImpl.java

2002-07-18 Thread Kevin Conner
Kevin Conner wrote: As an aside, having just looked at the 3.0.1 code (this may have changed since then), commit, delistResource, enlistResource, registerSynchronization, rollback and setRollbackOnly are protected by the lock method (and hence synchronisation). Until my recent commit,

RE: [JBoss-dev] Re: [jboss-cvs] jboss-transaction/src/main/org/jboss/tm TransactionImpl.java

2002-07-17 Thread Kevin Conner
Ole Husgaard wrote: + // Using the construct + // try { + // txCapsule.doSomething(); + // } catch (NullPointerException ex) { + // throw new IllegalStateException(No transaction.); + // } + // may look like bad programming style, but it