RE: [JBoss-dev] The new tests target
Please put these tests in the testsuite. We need nightly reports on the stability of JBoss. Plus, if they aren't integrated with testsuite you risk somebody breaking your code with a new change to the core. Again, put these tests in testuiste Thanks, Bill Burke Chief Architect JBoss Group, LLC -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Ricardo Argüello Sent: Friday, February 14, 2003 9:58 AM To: [EMAIL PROTECTED] Subject: [JBoss-dev] The new tests target Hi, I'm trying to use the new tests target for JBoss-Media (CVS module: jboss-media). I need to access files with media to do some unit testing. I'm doing it this way: From jboss-head/media/src/test/org/jboss/media/JBossMediaUnitTestCase.java: ... ClassLoader classLoader = Thread.currentThread().getContextClassLoader(); InputStream inputStream = classLoader.getResourceAsStream(resourceName); ... Most of the code was copied from the jboss-head/testsuite/src/main/org/jboss/test/cmp2/lob testcase. In that testcase, getResourceAsStream works with files under src/resources resourceName is in my case data/image.png. I've tried putting the file in src/main, src/resources and src/test with no luck: I can't read the file. I can run the test from Eclipse, running JBossMediaUnitTestCase as a Junit test, build tests gives me Errors: testcase name=testMediaBeanProperties time=0.016 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error /testcase testcase name=testMediaFormatRegistry time=0.0 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error /testcase testcase name=testHeaderExtraction time=0.0 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error *Maybe* some change needs to be added to tools/etc/buildfragments/targets.ent? Where should I put files to be readed with ClassLoader.getResourceAsStream(...) form within a JUnit testcase to be run with the new tests target? You can find all the code in the jboss-media CVS module. Thanks in advance, Ricardo Argüello [EMAIL PROTECTED] www.freeroller.net/page/ricardo -- I took the red pill. --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
RE: [JBoss-dev] The new tests target
The testsuite is just not scalable, Bill, and is inappropriate for module level unit tests. Having the compile take 5-10 minutes for running just one test is ludicrous. If you want to object, object to the change note when I announced this facility. I will see about getting all the module tests to run with the main testsuite and included in the report. ricardo, all my tests just used stuff from build/tests or build/gen/tests (or whatever its named). I think we need an additional src/test-resource directory in each module for this purpose. We need a definition in buildfragments/defaults.ent and to include it in the _default:tests target. david jencks On 2003.02.14 11:26 Bill Burke wrote: Please put these tests in the testsuite. We need nightly reports on the stability of JBoss. Plus, if they aren't integrated with testsuite you risk somebody breaking your code with a new change to the core. Again, put these tests in testuiste Thanks, Bill Burke Chief Architect JBoss Group, LLC -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Ricardo Argüello Sent: Friday, February 14, 2003 9:58 AM To: [EMAIL PROTECTED] Subject: [JBoss-dev] The new tests target Hi, I'm trying to use the new tests target for JBoss-Media (CVS module: jboss-media). I need to access files with media to do some unit testing. I'm doing it this way: From jboss-head/media/src/test/org/jboss/media/JBossMediaUnitTestCase.java: ... ClassLoader classLoader = Thread.currentThread().getContextClassLoader(); InputStream inputStream = classLoader.getResourceAsStream(resourceName); ... Most of the code was copied from the jboss-head/testsuite/src/main/org/jboss/test/cmp2/lob testcase. In that testcase, getResourceAsStream works with files under src/resources resourceName is in my case data/image.png. I've tried putting the file in src/main, src/resources and src/test with no luck: I can't read the file. I can run the test from Eclipse, running JBossMediaUnitTestCase as a Junit test, build tests gives me Errors: testcase name=testMediaBeanProperties time=0.016 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error /testcase testcase name=testMediaFormatRegistry time=0.0 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error /testcase testcase name=testHeaderExtraction time=0.0 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error *Maybe* some change needs to be added to tools/etc/buildfragments/targets.ent? Where should I put files to be readed with ClassLoader.getResourceAsStream(...) form within a JUnit testcase to be run with the new tests target? You can find all the code in the jboss-media CVS module. Thanks in advance, Ricardo Argüello [EMAIL PROTECTED] www.freeroller.net/page/ricardo -- I took the red pill. --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing
RE: [JBoss-dev] The new tests target
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of David Jencks Sent: Friday, February 14, 2003 12:03 PM To: [EMAIL PROTECTED] Subject: RE: [JBoss-dev] The new tests target The testsuite is just not scalable, Bill, and is inappropriate for module level unit tests. Having the compile take 5-10 minutes for running just one test is ludicrous. If its not scalable, fix it. We need tests to run with the nightly build, this is more important than saving you 5-10 minutes. When I make a global change like InvocationResponse, I need to know that all tests are being executed so that I don't fuck up everything. I turn off recompilation in testsuite/build.xml when I need to run a test more than once quickly. Why does the stupid buildsystem rerun XDoclet everytime you do a build? Why isn't there any dependency checking? This is the real problem and why the build takes so fucking long. I miss the days of the 2.x series when the buildsystem wasn't such a burden... If you want to object, object to the change note when I announced this facility. I will see about getting all the module tests to run with the main testsuite and included in the report. This should have been done in the first place before it was encouraged to put in modules tests ricardo, all my tests just used stuff from build/tests or build/gen/tests (or whatever its named). I think we need an additional src/test-resource directory in each module for this purpose. We need a definition in buildfragments/defaults.ent and to include it in the _default:tests target. david jencks On 2003.02.14 11:26 Bill Burke wrote: Please put these tests in the testsuite. We need nightly reports on the stability of JBoss. Plus, if they aren't integrated with testsuite you risk somebody breaking your code with a new change to the core. Again, put these tests in testuiste Thanks, Bill Burke Chief Architect JBoss Group, LLC -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Ricardo Argüello Sent: Friday, February 14, 2003 9:58 AM To: [EMAIL PROTECTED] Subject: [JBoss-dev] The new tests target Hi, I'm trying to use the new tests target for JBoss-Media (CVS module: jboss-media). I need to access files with media to do some unit testing. I'm doing it this way: From jboss-head/media/src/test/org/jboss/media/JBossMediaUnitTestCase.java: ... ClassLoader classLoader = Thread.currentThread().getContextClassLoader(); InputStream inputStream = classLoader.getResourceAsStream(resourceName); ... Most of the code was copied from the jboss-head/testsuite/src/main/org/jboss/test/cmp2/lob testcase. In that testcase, getResourceAsStream works with files under src/resources resourceName is in my case data/image.png. I've tried putting the file in src/main, src/resources and src/test with no luck: I can't read the file. I can run the test from Eclipse, running JBossMediaUnitTestCase as a Junit test, build tests gives me Errors: testcase name=testMediaBeanProperties time=0.016 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error /testcase testcase name=testMediaFormatRegistry time=0.0 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error /testcase testcase name=testHeaderExtraction time=0.0 error type=java.lang.NullPointerExceptionjava.lang.NullPointerExcepti on at org.jboss.media.JBossMediaUnitTestCase.createFileFromResource(JBos sMediaUnitTestCase.java:196) at org.jboss.media.JBossMediaUnitTestCase.setUp(JBossMediaUnitTestCas e.java:61)/error *Maybe* some change needs to be added to tools/etc/buildfragments/targets.ent? Where should I put files to be readed with ClassLoader.getResourceAsStream(...) form within a JUnit testcase to be run with the new tests target? You can find all the code in the jboss-media CVS module. Thanks in advance, Ricardo Argüello [EMAIL PROTECTED] www.freeroller.net/page/ricardo -- I took the red pill. --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin
Re: [JBoss-dev] The new tests target
Its true that the main problem is xdoclet here. Its also the reason for a bug report about excessive memory usage during compilation. We need to have a comprehensive testsuite for the reason that Bill states, we cannot rely on a developer having to run individual module tests to validate system wide changes. We also do need to address the monolithic nature of the testsuite. Having to run xdoclet and the compile to rerun a test is a waste of time. This does need to be broken down without losing the ability to run comprehensive testsuites. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Bill Burke [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, February 14, 2003 9:23 AM Subject: RE: [JBoss-dev] The new tests target -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of David Jencks Sent: Friday, February 14, 2003 12:03 PM To: [EMAIL PROTECTED] Subject: RE: [JBoss-dev] The new tests target The testsuite is just not scalable, Bill, and is inappropriate for module level unit tests. Having the compile take 5-10 minutes for running just one test is ludicrous. If its not scalable, fix it. We need tests to run with the nightly build, this is more important than saving you 5-10 minutes. When I make a global change like InvocationResponse, I need to know that all tests are being executed so that I don't fuck up everything. I turn off recompilation in testsuite/build.xml when I need to run a test more than once quickly. Why does the stupid buildsystem rerun XDoclet everytime you do a build? Why isn't there any dependency checking? This is the real problem and why the build takes so fucking long. I miss the days of the 2.x series when the buildsystem wasn't such a burden... If you want to object, object to the change note when I announced this facility. I will see about getting all the module tests to run with the main testsuite and included in the report. This should have been done in the first place before it was encouraged to put in modules tests ricardo, all my tests just used stuff from build/tests or build/gen/tests (or whatever its named). I think we need an additional src/test-resource directory in each module for this purpose. We need a definition in buildfragments/defaults.ent and to include it in the _default:tests target. david jencks --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] The new tests target
I can set up so that running /build/build.sh tests runs all module build suites and the main testsuite and put all results in the testsuite/output/reports. This should be pretty easy, I can do it this weekend. I really think that encouraging people to write actual unit tests by making it really easy will greatly help the quality of our code. Right now we have almost no unit tests, only integration tests. Please distinguish between unit tests and integration tests. david jencks On 2003.02.14 13:14 Scott M Stark wrote: Its true that the main problem is xdoclet here. Its also the reason for a bug report about excessive memory usage during compilation. We need to have a comprehensive testsuite for the reason that Bill states, we cannot rely on a developer having to run individual module tests to validate system wide changes. We also do need to address the monolithic nature of the testsuite. Having to run xdoclet and the compile to rerun a test is a waste of time. This does need to be broken down without losing the ability to run comprehensive testsuites. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: Bill Burke [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, February 14, 2003 9:23 AM Subject: RE: [JBoss-dev] The new tests target -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of David Jencks Sent: Friday, February 14, 2003 12:03 PM To: [EMAIL PROTECTED] Subject: RE: [JBoss-dev] The new tests target The testsuite is just not scalable, Bill, and is inappropriate for module level unit tests. Having the compile take 5-10 minutes for running just one test is ludicrous. If its not scalable, fix it. We need tests to run with the nightly build, this is more important than saving you 5-10 minutes. When I make a global change like InvocationResponse, I need to know that all tests are being executed so that I don't fuck up everything. I turn off recompilation in testsuite/build.xml when I need to run a test more than once quickly. Why does the stupid buildsystem rerun XDoclet everytime you do a build? Why isn't there any dependency checking? This is the real problem and why the build takes so fucking long. I miss the days of the 2.x series when the buildsystem wasn't such a burden... If you want to object, object to the change note when I announced this facility. I will see about getting all the module tests to run with the main testsuite and included in the report. This should have been done in the first place before it was encouraged to put in modules tests ricardo, all my tests just used stuff from build/tests or build/gen/tests (or whatever its named). I think we need an additional src/test-resource directory in each module for this purpose. We need a definition in buildfragments/defaults.ent and to include it in the _default:tests target. david jencks --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] The new tests target
I don't disagree, but running units tests as part of the unified testsuite is just as important. Having unit tests in isolation of the overall testsuite really will not help the quality of the codebase in the long run. Scott Stark Chief Technology Officer JBoss Group, LLC - Original Message - From: David Jencks [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, February 14, 2003 10:42 AM Subject: Re: [JBoss-dev] The new tests target I can set up so that running /build/build.sh tests runs all module build suites and the main testsuite and put all results in the testsuite/output/reports. This should be pretty easy, I can do it this weekend. I really think that encouraging people to write actual unit tests by making it really easy will greatly help the quality of our code. Right now we have almost no unit tests, only integration tests. Please distinguish between unit tests and integration tests. david jencks --- This SF.NET email is sponsored by: FREE SSL Guide from Thawte are you planning your Web Server Security? Click here to get a FREE Thawte SSL guide and find the answers to all your SSL security issues. http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en ___ Jboss-development mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/jboss-development