Hi Paul, yes, indeed, this sounds smarter then the hook-solution! But nevertheless IMHO a package can not have enough hooks where other packages can "plugin" - IMHO there is no disadvantage for efc.el offering such hooks.
But back to your suggestions: Yes, a variable efc-dialog-window which can be set by other packages would be great. In this case efc must not delete this window but has to restore the original buffer (like you describe). A word to your other suggestion about using extra frames: Maybe we should go one step more forward and generalizing efc.el so it is independed from using buffer, windows, frames at all. Maybe efc.el should offer a well-defined interface for a) displaying all the stuff and an implementation has only to satisfy this interface but can display all the stuff in any arbitrary suitable manner - for exmaple XEmacs has a really powerful dialog-implementation (make-dialog) so for example "real" windows-dialogs could be used to display the efc-contents. b) hitting ok c) hitting cancel d) closing the display-"medium" (buffer, window, frame, OS-dialog, popup-menu etc...) efc.el itself could then offer standard-implementations of these interfaces which uses buffer/windows and buffers/frames for display. Hmm, maybe this is not easy but would be great... But for the beginning your suggested ecb-dialog-window would be great (maybe you could then also add some hooks - is not much effort :-)) Thanks, Klaus -----Original Message----- From: Paul Kinnucan [mailto:[EMAIL PROTECTED] Sent: Thursday, February 27, 2003 7:11 PM To: Berndl, Klaus Cc: 'Le Wang'; [EMAIL PROTECTED]; 'Paul Kinnucan' Subject: ECB + JDE window focus bug - suggestion for solution (was: RE: EC B + JDE window focus bug) Hi Klaus, Wouldn't a simpler solution be for efc to define either a variable whose value is a window for displaying the dialog or a function that returns a window for displaying the dialog. For example, efc-dialog-window If efc-dialog-window is nonnil, efc would display the dialog buffer in the specified window and then restore the buffer that it was originally displaying. Otherwise, efc would create a temporary window and delete the temporary window after the user dismisses the dialog buffer. Fixed layout tools like ECB could set this variable to the window in which they would like the dialog to be displayed. Another or additional solution would be for the efc to define the following variable: efc-frame-dialog-p If this variable is nonnil, efc would display the dialog buffer in a separate frame centered on the user's screen. If this variable is nil, it would display the dialog buffer in the window specified by efc-dialog-window. Your thoughts? - Paul Berndl, Klaus writes: > > But i would vote for the following enhancement of efc.el: > > Offering 4 new hooks: > A) ecb-show-dialog-before-hook > B) ecb-show-diaolg-after-hook > C) ecb-close-dialog-before-hook > D) ecb-close-dialog-after-hook > > What would be the advantages of these hooks: > > A tool like ECB (which has such durable windows whcih prevent the efc-dialogs > to work correct) could temporary delete its durable compile/etc/stuff-window > temporary in the new hook ecb-show-dialog-before-hook so the efc-mechanismus > described at beginning (point 1, 2) can work correct. And could also recreate > its durable window after the efc-dialog has closed in the hook > ecb-close-dialog-after-hook. > > You see really necessary are only hooks a) and D) but B) and C) could also be > senseful (maybe)... > > Thoughts? IMHO it would not be a big deal for JDEE/efc but would offer big > advantages for tools like ECB to work better with JDEE under all circumstances. > > In general such hooks would be good on every place JDEE creates and deletes windows. > > Please give me feedback! > > Ciao, > klaus > > > > -----Original Message----- > From: Le Wang [mailto:[EMAIL PROTECTED] > Sent: Monday, February 24, 2003 5:03 PM > To: [EMAIL PROTECTED] > Subject: ECB + JDE window focus bug. > > > Hi, > > When I use 'jde-import-find-and-import' in ECB with a compile window, the > prompt window that asks for clarification pops up in the compilation buffer. > This is fine. But then, it doesn't have an idea where to put the import > statement. Is there a setting in JDE/ECB that I can tweak to correct this? > > Recreate Problem: > > 1. emacs -q > > 2. setup loadpaths > > 3. load jde, ecb > > 3. find asdf.java > > 4. customize ecb-layout to use a compilation window. > > 5. ecb-activate. > > 6. With "adsf.java" in edit window, and focus in same window, do > `jde-import-find-and-import' > > 7. Import "ParseException" class, choose any of the choices, click "ok" > > 8. Now the import statement is in my scratch buffer. > > Thanks. > > -- > Le > > ______________________________________________________________________ > Post your free ad now! http://personals.yahoo.ca
