Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-23 Thread Ivan Krylov
Andrew, thank you. Just pushed the changes. BTW, icedtea patches 6650759-missing_inference.patch and 6638712-wildcard_types.patch are now redundant. Also, the following bugs may be closed OPENJDK6-32,33,34,35. I would close those myself but I do not have the required permissions. Thanks, Iva

hg: jdk6/jdk6/langtools: OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-23 Thread ivan
Changeset: e62c8af01197 Author:ikrylov Date: 2014-06-23 17:25 +0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/e62c8af01197 OPENJDK6-35: backport of JDK-6650759 to openjdk6 Summary: Inference of formal type parameter (unused in formal parameters) is not performed. Revi

Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-23 Thread Andrew Haley
On 06/23/2014 02:05 PM, Ivan Krylov wrote: > The main motivation for this fix was exactly to fix building JBoss EAP > certification bundle (for 6.2.0). > This fix exists in IcedTea (6650759-missing_inference.patch) but for > whatever reason was never promoted to openjdk6. Ah, OK. That's fine, t

Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-23 Thread Ivan Krylov
Andrew, The main motivation for this fix was exactly to fix building JBoss EAP certification bundle (for 6.2.0). This fix exists in IcedTea (6650759-missing_inference.patch) but for whatever reason was never promoted to openjdk6. Thanks, Ivan On 23/06/2014 16:37, Andrew Haley wrote: On 06/

Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-23 Thread Andrew Haley
On 06/23/2014 12:17 PM, Ivan Krylov wrote: > please review the fix for OPENJDK6-35: backport of JDK-6650759 to openjdk6 > Inference of formal type parameter (unused in formal parameters) is not > performed > > The changes are the same as for OpenJDK7 however hg import failed due to > difference

Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-23 Thread Ivan Krylov
Hello, please review the fix for OPENJDK6-35: backport of JDK-6650759 to openjdk6 Inference of formal type parameter (unused in formal parameters) is not performed The changes are the same as for OpenJDK7 however hg import failed due to differences in the context of code being changed. bug