Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-15 Thread Nikolay Gorshkov
ne generic type in program that compiles under Java 6 Reviewed-by: aph Contributed-by: nikgor On 11/12/2014 22:01, Andrew Haley wrote: On 12/11/2014 06:59 PM, Nikolay Gorshkov wrote: Me and my colleagues have a consensus that the patch is important to us - we are responsible for introducing

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-11 Thread Nikolay Gorshkov
we are interested in upstreaming it to OpenJDK 6 itself to minimize the difference in codebase. Thanks, Nikolay On 10.12.2014 19:56, Andrew Haley wrote: On 12/10/2014 04:32 PM, Nikolay Gorshkov wrote: I see your point that we chose a risky way and remember discussions around http

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Nikolay Gorshkov
Hi Andrew, OK, I see, thank you for this point! Indeed, the fix is just a backport of JDK-6938454 to OpenJDK 6. Thanks, Nikolay On 10.12.2014 19:11, Andrew Hughes wrote: - Original Message - Please, review the fix for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Nikolay Gorshkov
, fixing regressions) is more preferable than moving to pre- JDK-6650759 state where we had known incompatibilities. Thanks, Nikolay On 10.12.2014 15:31, Andrew Haley wrote: On 12/10/2014 12:06 PM, Nikolay Gorshkov wrote: Please, review the fix for OPENJDK6-40: OpenJDK6-b32 does not compile the

Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Nikolay Gorshkov
Please, review the fix for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine This is a regression of the fix for OPENJDK6-35 (which is a backport of JDK-6650759 to OpenJDK 6). In OpenJDK 7 this regression existed too - it was tracked as JDK-6938454: Unab

Changeset comment format (was Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6)

2014-07-14 Thread Nikolay Gorshkov
Hello Mario, Andrew, I'd like to propose the following changeset comment format for situations when the creator and the backporter of the fix are two different persons: 1234567: NPE thrown on FileInputStream("") Summary: Rewrite precondition-checking code in io.c Reviewed-by: mr Contributed-by:

Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-07-01 Thread Nikolay Gorshkov
Hi Andrew, Thank you for the link to the fix discussion. I see the point. Sections of the JLS dedicated to inferring type arguments have been changed for Java 7, and 6650759 implements (fully or partially) these changes. JBS says 6650759 is an enhancement, not a bug. Also, www.oracle.com/technetw

Re: Review request for OPENJDK6-35: backport of JDK-6650759 to openjdk6

2014-06-25 Thread Nikolay Gorshkov
Hi Andrew, From my previous experience I can say that it's common practice to indicate in commit messages who prepared and integrated these particular bits and who reviewed them. Here is a couple of examples where original fixes and backports are nearly identical, but their commit messages refer