Re: Need reviewer: OpenJDK6 binary plug logic removal

2010-12-23 Thread Joe Darcy
Kelly O'Hair wrote: Need reviewer: OpenJDK6 binary plug logic removal 7008723: Remove binary plugs creation and use from openjdk http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-plug-removal/webrev/ -kto Looks good; is no one is using SNMP on OpenJDK 6/IcedTea 6, might as well simplify by r

Re: Need reviewer: Openjdk6 2010 copyright year changes

2010-12-23 Thread Joe Darcy
Looks good -- approved to go back. Thanks Kelly, -Joe Kelly O'Hair wrote: Need reviewer: Openjdk6 2010 copyright year changes Any sources changed in 2010 need to have their copyright year adjusted. Script used is attached and will be added to the top repo at make/scripts. 6962318: Update

Re: Need reviewer: OpenJDK6 binary plug logic removal

2010-12-23 Thread Kelly O'Hair
On Dec 23, 2010, at 9:08 AM, Joe Darcy wrote: Kelly O'Hair wrote: Need reviewer: OpenJDK6 binary plug logic removal 7008723: Remove binary plugs creation and use from openjdk http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-plug-removal/webrev/ -kto Looks good; is no one is using SNMP on

Request to backport changeset 3a9d06af8830

2010-12-23 Thread Deepak Bhole
Hi, I'd like to request a backport of the following changeset: changeset: 770:3a9d06af8830 user:bae date:Sat Nov 01 20:42:18 2008 +0300 summary: 6541476: PNG imageio plugin incorrectly handles iTXt chunk It addresses errors caused due to incorrect iTXt chunk handling (e.g.

Re: Need reviewer: OpenJDK6 binary plug logic removal

2010-12-23 Thread Joe Darcy
On 12/23/2010 9:57 AM, Kelly O'Hair wrote: On Dec 23, 2010, at 9:08 AM, Joe Darcy wrote: Kelly O'Hair wrote: Need reviewer: OpenJDK6 binary plug logic removal 7008723: Remove binary plugs creation and use from openjdk http://cr.openjdk.java.net/~ohair/openjdk6/jdk6-plug-removal/webrev/ -kto

Re: Please review fix for regression test java/awt/xembed/server/TestXEmbedServer.java

2010-12-23 Thread Joe Darcy
Hello. Approved for OpenJDK 6. Thanks, -Joe On 12/20/2010 5:22 AM, Anthony Petrov wrote: Hi Pavel, The fixes look fine. Here's the bug ID: 6560348: PIT : java/awt/xembed/server/RunTestXEmbed.java fails Thank you. -- best regards, Anthony On 12/17/2010 4:15 PM, Pavel Tisnovsky wrote: Hi

Re: Request to backport changeset 3a9d06af8830

2010-12-23 Thread Joe Darcy
On 12/23/2010 11:28 AM, Deepak Bhole wrote: Hi, I'd like to request a backport of the following changeset: changeset: 770:3a9d06af8830 user:bae date:Sat Nov 01 20:42:18 2008 +0300 summary: 6541476: PNG imageio plugin incorrectly handles iTXt chunk It addresses errors caus

Re: Request to backport changeset 3a9d06af8830

2010-12-23 Thread Deepak Bhole
* Joe Darcy [2010-12-23 16:40]: > On 12/23/2010 11:28 AM, Deepak Bhole wrote: > >Hi, > > > >I'd like to request a backport of the following changeset: > > > >changeset: 770:3a9d06af8830 > >user:bae > >date:Sat Nov 01 20:42:18 2008 +0300 > >summary: 6541476: PNG imageio plugin

hg: jdk6/jdk6: 2 new changesets

2010-12-23 Thread kelly . ohair
Changeset: c9a6d4ccf874 Author:ohair Date: 2010-12-23 16:14 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/rev/c9a6d4ccf874 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: darcy ! README-builds.html ! make/jprt.properties Changeset: 1a9c17208fa8 Author:

hg: jdk6/jdk6/jdk: 2 new changesets

2010-12-23 Thread kelly . ohair
Changeset: c87d11e10ff2 Author:ohair Date: 2010-12-23 16:15 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c87d11e10ff2 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: darcy ! make/Makefile ! make/com/sun/jmx/Makefile ! make/common/Defs.gmk ! make/c

hg: jdk6/jdk6/jaxws: 2 new changesets

2010-12-23 Thread kelly . ohair
Changeset: 26d81b7cb87a Author:ohair Date: 2010-12-23 16:18 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxws/rev/26d81b7cb87a 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: darcy ! make/jprt.properties Changeset: 8e669ea7a213 Author:ohair Date:

hg: jdk6/jdk6/corba: 2 new changesets

2010-12-23 Thread kelly . ohair
Changeset: d0decbad791f Author:ohair Date: 2010-12-23 16:16 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/corba/rev/d0decbad791f 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: darcy ! make/common/Defs.gmk ! make/jprt.properties Changeset: 4f0834bbc28e Au

hg: jdk6/jdk6/jaxp: 2 new changesets

2010-12-23 Thread kelly . ohair
Changeset: fa293b5d8685 Author:ohair Date: 2010-12-23 16:17 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/jaxp/rev/fa293b5d8685 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: darcy ! make/jprt.properties Changeset: ef83bc7d408a Author:ohair Date:

hg: jdk6/jdk6/langtools: 7008723: Remove binary plugs creation and use from openjdk

2010-12-23 Thread kelly . ohair
Changeset: 24ca82ed9b66 Author:ohair Date: 2010-12-23 16:18 -0800 URL: http://hg.openjdk.java.net/jdk6/jdk6/langtools/rev/24ca82ed9b66 7008723: Remove binary plugs creation and use from openjdk Reviewed-by: darcy ! make/jprt.properties