CR 7107919 Review Request

2012-04-12 Thread Kevin Walls
Hi, I'd like to get this small hotspot fix reviewed for openjdk6. It prohibits building on Solaris 8 zones on at least some sparc hardware. Currently the assertion prohibits these builds, moving to a warning in debug mode only makes more sense... (it's in closed jdk6 already). http://cr.op

Re: CR 7107919 Review Request

2012-04-12 Thread Kelly O'Hair
Is this the same exact change that was made to jdk7 hotspot? Or the closed jdk6 hotspot? -kto On Apr 12, 2012, at 9:22 AM, Kevin Walls wrote: > Hi, > > I'd like to get this small hotspot fix reviewed for openjdk6. It prohibits > building on Solaris 8 zones on at least some sparc hardware. C

Re: CR 7107919 Review Request

2012-04-12 Thread Kevin Walls
Hi -- It's the exact change from closed jdk6's hotspot. The problem only happens where we build on solaris 8, not on later Solaris versions, so latest hsx doesn't have this change. Thanks Kevin On 12/04/12 18:37, Kelly O'Hair wrote: Is this the same exact change that was made to jdk7 hots

Re: CR 7107919 Review Request

2012-04-12 Thread Kelly O'Hair
Approved. -kto On Apr 12, 2012, at 10:48 AM, Kevin Walls wrote: > Hi -- > > It's the exact change from closed jdk6's hotspot. The problem only happens > where we build on solaris 8, not on later Solaris versions, so latest hsx > doesn't have this change. > > Thanks > Kevin > > > On 12/04/

Re: CR 7107919 Review Request

2012-04-12 Thread Kevin Walls
Thanks! On 12/04/12 19:25, Kelly O'Hair wrote: Approved. -kto On Apr 12, 2012, at 10:48 AM, Kevin Walls wrote: Hi -- It's the exact change from closed jdk6's hotspot. The problem only happens where we build on solaris 8, not on later Solaris versions, so latest hsx doesn't have this chang