Re: [PATCH FOR REVIEW] OPENJDK6-18: HotSpot 23's Java code won't build with a 1.5 compiler due to @Override on interfaces.

2013-09-20 Thread Andrew Hughes
- Original Message - > On 09/19/2013 01:06 PM, Andrew Hughes wrote: > >> On 09/19/2013 12:12 PM, Andrew Hughes wrote: > >>> I discovered during bootstrapping with IcedTea that the build fails due > >>> to > >>> the use of > >>> @Override on interface methods (namely an implementation of Ite

Re: [PATCH FOR REVIEW] OPENJDK6-18: HotSpot 23's Java code won't build with a 1.5 compiler due to @Override on interfaces.

2013-09-20 Thread Omair Majid
On 09/20/2013 10:17 AM, Andrew Hughes wrote: >> On 09/19/2013 01:06 PM, Andrew Hughes wrote: The build README points out that a 6 JDK is required to build OpenJDK6 [1] and @Override for interface methods are supported by a 6 compiler. >>> >>> Then the README is wrong. >> >> Oh, what

hg: jdk6/jdk6/hotspot: OPENJDK6-18: HotSpot 23's Java code won't build with a 1.5 compiler due to @Override on interfaces

2013-09-20 Thread gnu . andrew
Changeset: f6d3da39ae43 Author:andrew Date: 2013-09-19 17:03 +0100 URL: http://hg.openjdk.java.net/jdk6/jdk6/hotspot/rev/f6d3da39ae43 OPENJDK6-18: HotSpot 23's Java code won't build with a 1.5 compiler due to @Override on interfaces Reviewed-by: omajid ! agent/src/share/classes/s

Re: Backporting 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

2013-09-20 Thread Mario Torre
On Tue, 2013-08-27 at 12:06 -0400, Omair Majid wrote: > I see. I will ask Mario to create a final webrev, then. Hi all, Here's the webrev: http://cr.openjdk.java.net/~neugens/8020983/webrev.01/ If ok, can somebody please commit for me? Thanks, Mario

Re: [PATCH FOR REVIEW] OPENJDK6-18: HotSpot 23's Java code won't build with a 1.5 compiler due to @Override on interfaces.

2013-09-20 Thread Andrew Hughes
- Original Message - > On 09/20/2013 10:17 AM, Andrew Hughes wrote: > >> On 09/19/2013 01:06 PM, Andrew Hughes wrote: > > The build README points out that a 6 JDK is required to build OpenJDK6 > [1] and @Override for interface methods are supported by a 6 compiler. > >>> >

Re: Backporting 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

2013-09-20 Thread Andrew Hughes
- Original Message - > On Tue, 2013-08-27 at 12:06 -0400, Omair Majid wrote: > > > I see. I will ask Mario to create a final webrev, then. > > Hi all, > > Here's the webrev: > > http://cr.openjdk.java.net/~neugens/8020983/webrev.01/ > > If ok, can somebody please commit for me? > >