Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Nikolay Gorshkov
Please, review the fix for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine This is a regression of the fix for OPENJDK6-35 (which is a backport of JDK-6650759 to OpenJDK 6). In OpenJDK 7 this regression existed too - it was tracked as JDK-6938454: Unab

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Andrew Haley
On 12/10/2014 12:06 PM, Nikolay Gorshkov wrote: > Please, review the fix for > OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 > compiles fine > > This is a regression of the fix for OPENJDK6-35 (which is a backport of > JDK-6650759 to OpenJDK 6). In OpenJDK 7 this re

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Andrew Hughes
- Original Message - > Please, review the fix for > OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 > compiles fine > > This is a regression of the fix for OPENJDK6-35 (which is a backport of > JDK-6650759 to OpenJDK 6). In OpenJDK 7 this regression existed too

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Nikolay Gorshkov
Hi Andrew, I see your point that we chose a risky way and remember discussions around http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-December/002195.html that we had in the past when the fix for OPENJDK6-35 was in review. Well, my opinion is that this risk was taken when we decided to inte

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Nikolay Gorshkov
Hi Andrew, OK, I see, thank you for this point! Indeed, the fix is just a backport of JDK-6938454 to OpenJDK 6. Thanks, Nikolay On 10.12.2014 19:11, Andrew Hughes wrote: - Original Message - Please, review the fix for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle

Re: Review request for OPENJDK6-40: OpenJDK6-b32 does not compile the testcase that Oracle JDK 6u45 compiles fine

2014-12-10 Thread Andrew Haley
On 12/10/2014 04:32 PM, Nikolay Gorshkov wrote: > I see your point that we chose a risky way and remember discussions > around > http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-December/002195.html > that we had in the past when the fix for OPENJDK6-35 was in review. > > Well, my opinion is t