Re: Need reviewer on small test/Makefile change for jdk7u-osx

+1 Well it looks correct. The 64-bit detection is way too ugly to ever look "good" ;-) David PS. I got a 404 trying to use the frames view of the webrev. On 7/12/2011 12:45 PM, James Melvin wrote: Looks good! - Jim On 12/6/11 9:30 PM, Kelly O'Hair wrote: For the jdk7u-osx forest (Mac p

Re: Need reviewer on small test/Makefile change for jdk7u-osx

Looks good! - Jim On 12/6/11 9:30 PM, Kelly O'Hair wrote: For the jdk7u-osx forest (Mac port): 7118773: Fix jdk/test/makefile so it works on the mac http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-test/webrev The test/Makefile changes so it works for Mac. It thinks it's windows right

Need reviewer on small test/Makefile change for jdk7u-osx

For the jdk7u-osx forest (Mac port): 7118773: Fix jdk/test/makefile so it works on the mac http://cr.openjdk.java.net/~ohair/openjdk7/jdk7u-osx-test/webrev The test/Makefile changes so it works for Mac. It thinks it's windows right now. :^( -kto

Re: [7u4] Request for approval for bulk integration of hs23-b07

Thanks for the update John! Cheers, Edvard Sent from my iPhone On 6 dec 2011, at 17:54, John Coomes wrote: > Edvard Wendelin (edvard.wende...@oracle.com) wrote: >> Approved, given that SQE gives Go after PIT-testing. > > Thanks. However, problems were detected during PIT, so I am > withdrawi

Re: [7u4] Request for approval for bulk integration of hs23-b07

Edvard Wendelin (edvard.wende...@oracle.com) wrote: > Approved, given that SQE gives Go after PIT-testing. Thanks. However, problems were detected during PIT, so I am withdrawing the request. -John > On Dec 6, 2011, at 1:02 AM, John Coomes wrote: > > > Requesting approval to integrate hs23-b07

Re: request permission to push 3 changesets to jdk7u/jdk7u-osx/hotspot repo

Approved. Paul On 12/6/11 2:57 PM, Daniel D. Daugherty wrote: Greetings, The jdk7u/jdk7u-osx forest needs a hotspot changeset to build properly on Linux and Solaris: Changeset: 242b4e0e6f73 Author:phh Date: 2011-11-29 09:21 -0500 URL:http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot

request permission to push 3 changesets to jdk7u/jdk7u-osx/hotspot repo

Greetings, The jdk7u/jdk7u-osx forest needs a hotspot changeset to build properly on Linux and Solaris: Changeset: 242b4e0e6f73 Author:phh Date: 2011-11-29 09:21 -0500 URL:http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/242b4e0e6f73 7116189: Export JVM_SetNativeThreadName from H

Re: Need reviewer- for jdk7u-osx

On 12/6/11 4:03 PM, Henri Gomez wrote: > macosx_x64_10.7 ? > > Does it means there won't be a 32/64 bits JVM ? This is a fix for JPRT. See http://weblogs.java.net/blog/kellyohair/archive/2006/09/jprt_buildtest.html for an introduction. cheers, dalibor topic -- Oracle D

Re: Need reviewer- for jdk7u-osx

ts : mbp:~ henri$ java -version openjdk version "1.7.0-u4-b01" OpenJDK Runtime Environment (build 1.7.0-u4-b01-20111206) OpenJDK 64-Bit Server VM (build 23.0-b06, mixed mode) mbp:~ henri$ java -version -d32 openjdk version "1.7.0-u4-b01" OpenJDK Runtime Environment (build 1.7.

Re: Need reviewer- for jdk7u-osx

On Dec 5, 2011, at 8:46 PM, David Holmes wrote: > Hi Kelly, > > On 6/12/2011 1:19 PM, Kelly O'Hair wrote: >> >> For the jdk7u-osx forest (Mac port): >> >> 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac >> 7118095: Add macosx targets to make/jprt.properties file >> http://cr

Re: Need reviewer- for jdk7u-osx

These are just the build systems used to create the builds. But yes, as far as I know, I had assumed that there is only a 64bit VM and only a server VM. Even if we built a 32bit or additional VM, that would happen in the one build target, and testing would them have more variations. But I'll av

Re: Code Review Request for MacOS X build change (7117748)

Push now, please. Paul On 12/6/11 10:04 AM, Daniel D. Daugherty wrote: No conflict because it is the same changeset. I'm just trying to make it easier to build the jdk7u-osx forest with JPRT. Your call as to whether you want it now or later... Dan On 12/6/11 8:02 AM, Paul Hohensee wrote: [dr

Re: Code Review Request for MacOS X build change (7117748)

No conflict because it is the same changeset. I'm just trying to make it easier to build the jdk7u-osx forest with JPRT. Your call as to whether you want it now or later... Dan On 12/6/11 8:02 AM, Paul Hohensee wrote: [dropped some of the cc's inadvertently] If you push directly to jdk7u-osx/h

Re: Need reviewer- for jdk7u-osx

macosx_x64_10.7 ? Does it means there won't be a 32/64 bits JVM ? 2011/12/6 David Holmes : > Hi Kelly, > > > On 6/12/2011 1:19 PM, Kelly O'Hair wrote: >> >> >> For the jdk7u-osx forest (Mac port): >> >> 7117110: Remove target 1.5 from jaxp and jaxws repo builds for mac >> 7118095: Add macosx tar

Re: Code Review Request for MacOS X build change (7117748)

[dropped some of the cc's inadvertently] If you push directly to jdk7u-osx/hotspot, and then we pull hs23 with the identical fix down into it, we'll have a conflict. Current process is to push up to hsx/hsx23, PIT over the weekend and push the following week. In this case, that'd be next week.

Re: Code Review Request for MacOS X build change (7117748)

If you push directly to jdk7u-osx/hotspot, and then we pull hs23 with the identical fix down into it, we'll have a conflict. Current process is to push up to hsx/hsx23, PIT over the weekend and push the following week. In this case, that'd be next week. So, do you really, really have to push th

Re: Code Review Request for MacOS X build change (7117748)

Paul, I'd like to push this fix to the jdk7u/jdk7u-osx/hotspot repo. The fix is in the JPRT-hotspotwest queue heading to RT_Baseline and I have it setup so that the same changeset can also go into the jdk7u/jdk7u-osx/hotspot repo. Do I have permission? Dan On 12/3/11 9:13 PM, Daniel D. Daughe

Re: [7u4] Request for approval for bulk integration of hs23-b07

Approved, given that SQE gives Go after PIT-testing. Cheers, Edvard On Dec 6, 2011, at 1:02 AM, John Coomes wrote: > Requesting approval to integrate hs23-b07 into jdk7u4-b03. > > A webrev is available at: > > http://cr.openjdk.java.net/~jcoomes/7u4/hs23-b07-jdk7u4-b03.webrev/ > > Pre-integr