Re: [7u4] Request for approval for CR : 2221126: incorrect path separator in make/build.xml for Windows when running jtreg tests

2012-02-13 Thread Edvard Wendelin
approved. On Feb 14, 2012, at 12:47 AM, Jim Holmlund wrote: > Request for Backport of a JDK 8 fix into 7u4. > > This fixes a problem in the langtools/make/build.xml file that causes a > problem for the jtreg targets on windows. > > Bug description > http://monaco.us.oracle.com/detail.jsf?

Re: [7u4] Request for approval for CR 7131367 [macosx] reg test test/java/awt/Window/TranslucentJAppletTest fails

2012-02-13 Thread Edvard Wendelin
Approved. On Feb 2, 2012, at 5:40 PM, Sergey Bylokhov wrote: > Hello, > This is a request to push the following changes to jdk7u-dev. > The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131367 > Webrev can be

Re: [7u4] Request for approval for 7124225: [macosx] Input lines support only current sample rate

2012-02-13 Thread Edvard Wendelin
Approved. On Feb 2, 2012, at 2:26 PM, Alex Menkov wrote: > Hi, > > This is a request to push the following fix to jdk7u-dev repo: > http://cr.openjdk.java.net/~amenkov/7124225/webrev.01/ > > the bug's description is here: > http://bugs.sun.com/view_bug.do?bug_id=7124225 > > The fix was approve

Re: 7u4 Request for approval for CR 7143711 - Feature added by 7053556 should override what's set by the constructor in secure mode

2012-02-13 Thread Edvard Wendelin
Approved. On Feb 13, 2012, at 6:07 PM, Joe Wang wrote: > Hi Edvard, > > Tom has reviewed the patch. > > Thanks, > Joe > > On 2/9/2012 2:03 AM, Edvard Wendelin wrote: >> I'd be happy to approve it once the change has been reviewed by someone with >> Reviewer status. >> >> Cheers, >> Edvard >>

[7u4] Request for approval for CR : 2221126: incorrect path separator in make/build.xml for Windows when running jtreg tests

2012-02-13 Thread Jim Holmlund
Request for Backport of a JDK 8 fix into 7u4. This fixes a problem in the langtools/make/build.xml file that causes a problem for the jtreg targets on windows. Bug description http://monaco.us.oracle.com/detail.jsf?cr=2221126 The fix is a one line change that is the same as in JDK 8: JDK 8

Re: [7u4] Request for approval for CR 7088989 - Improve the performance for T4 by utilizing the newly provided crypto APIs

2012-02-13 Thread Dalibor Topic
Thanks, Valerie, the change is now retroactively approved. cheers, dalibor topic On 2/9/12 12:18 AM, Valerie (Yu-Ching) Peng wrote: > > First, I apologize for missing this request approval process before > proceeding with the putback. > I mistakenly thought that this request approval process is

hg: jdk7u/jdk7u-dev/jdk: 7142509: Cipher.doFinal(ByteBuffer, ByteBuffer) fails to process when in.remaining() == 0

2012-02-13 Thread bradford . wetmore
Changeset: be4792b3b94f Author:wetmore Date: 2012-02-13 12:20 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/be4792b3b94f 7142509: Cipher.doFinal(ByteBuffer,ByteBuffer) fails to process when in.remaining() == 0 Reviewed-by: valeriep ! src/share/classes/javax/crypto/

hg: jdk7u/jdk7u-dev/jdk: 7124337: [macosx] FileDialog fails to select multiple files

2012-02-13 Thread dmitry . cherepanov
Changeset: 0e2f3e494814 Author:dcherepanov Date: 2012-02-13 16:03 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0e2f3e494814 7124337: [macosx] FileDialog fails to select multiple files Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java ! src

[7u4] Request for approval for CR 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField

2012-02-13 Thread Leonid Romanov
Hi, This is a request to push the following changes to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124272 webrev: http://cr.openjdk.java.net/~leonidr/MACOSX_PORT-675/webrev.01/ The fix has been reviewed on macosx-port-dev mailing list by Mike Swingler Thanks, Leonid.

Re: [7u4] Request for approval for 7124337: [macosx] FileDialog fails to select multiple files

2012-02-13 Thread Artem Ananiev
Approved. On 2/13/2012 1:08 PM, Dmitry Cherepanov wrote: This is a request to push the following fix to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124337 Webrev: http://cr.openjdk.java.net/~dcherepanov/7124337/webrev.0 Technical review: http://mail.openjdk.java.net/pi

[7u4] Request for approval for CR 7088989 - Improve the performance for T4 by utilizing the newly provided crypto APIs

2012-02-13 Thread Valerie (Yu-Ching) Peng
First, I apologize for missing this request approval process before proceeding with the putback. I mistakenly thought that this request approval process is not necessary until a later stage. The majority of changes for 7088989 utilizes Oracle internal APIs and thus are under the src/closed/s

hg: jdk7u/jdk7u-dev/jdk: 8 new changesets

2012-02-13 Thread lana . steuck
Changeset: 0e394800a961 Author:katleman Date: 2012-01-23 10:03 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0e394800a961 Added tag jdk7u4-b08 for changeset bcceb5734a34 ! .hgtags Changeset: 76b1a152c1d8 Author:katleman Date: 2012-01-27 08:49 -0800 URL:

[7u4] Request for approval for CR 7131367 [macosx] reg test test/java/awt/Window/TranslucentJAppletTest fails

2012-02-13 Thread Sergey Bylokhov
Hello, This is a request to push the following changes to jdk7u-dev. The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131367 Webrev can be found at: http://cr.openjdk.java.net/~serb/7131367/webrev.00/ Technical

Re: [7u4] Request for approval for 7141296: [macosx] Mouse Wheel Turn closes combobox popup

2012-02-13 Thread Artem Ananiev
Approved. On 2/13/2012 8:45 PM, Alexander Potochkin wrote: Hello This is a request to push the following fix to jdk 7u4: http://cr.openjdk.java.net/~alexp/7141296/webrev.01/ the bug's description is here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141296 the fix was approved by Serg

Re: [7u4] Request for approval for 7119760: [macosx] The OpenGL queue flusher thread is created in the wrong thread group

2012-02-13 Thread Edvard Wendelin
Approved. On 02/06/2012 11:11 AM, Dmitry Cherepanov wrote: This is a request to push the following fix to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7119760 Webrev: http://cr.openjdk.java.net/~dcherepanov/7119760/webrev.0 Technical review: http://mail.openjdk.java.net/

[7u4] Request for approval for CR 7131367 [macosx] reg test test/java/awt/Window/TranslucentJAppletTest fails

2012-02-13 Thread Sergey Bylokhov
Hello, This is a request to push the following changes to jdk7u-dev. The fix has been reviewed on macosx-port-dev mailing list by Anthony Petrov. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131367 Webrev can be found at: http://cr.openjdk.java.net/~serb/7131367/webrev.00/ Technical r

Re: Mailing list/server problems

2012-02-13 Thread mark . reinhold
2012/2/13 3:59 -0800, edvard.wende...@oracle.com: > It seems like some emails aren't getting through to the jdk7u-dev mailing > list. That means that we might not get your approval requests. If you one > waiting for response from one of the maintainers and you haven't seen any > activity for 3-4 da

hg: jdk7u/jdk7u/langtools: Added tag jdk7u4-b10 for changeset 8919b2b02fcb

2012-02-13 Thread david . katleman
Changeset: 0dc586a38632 Author:katleman Date: 2012-02-03 01:41 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/0dc586a38632 Added tag jdk7u4-b10 for changeset 8919b2b02fcb ! .hgtags

[7u4] Request for approval for 7124225: [macosx] Input lines support only current sample rate

2012-02-13 Thread Alex Menkov
Hi, This is a request to push the following fix to jdk7u-dev repo: http://cr.openjdk.java.net/~amenkov/7124225/webrev.01/ the bug's description is here: http://bugs.sun.com/view_bug.do?bug_id=7124225 The fix was approved by Alexander Strange (astrange) The fix affects only macosx code. regards

hg: jdk7u/jdk7u-dev/jdk: 7124528: [macosx] Selection is not cleared properly in text component.

2012-02-13 Thread sergey . bylokhov
Changeset: 7816a64158c4 Author:serb Date: 2012-02-13 17:35 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7816a64158c4 7124528: [macosx] Selection is not cleared properly in text component. Reviewed-by: swingler ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java

Re: 7u4 Request for approval for CR 7143711 - Feature added by 7053556 should override what's set by the constructor in secure mode

2012-02-13 Thread Joe Wang
Hi Edvard, Tom has reviewed the patch. Thanks, Joe On 2/9/2012 2:03 AM, Edvard Wendelin wrote: I'd be happy to approve it once the change has been reviewed by someone with Reviewer status. Cheers, Edvard On 02/08/2012 11:27 PM, Joe Wang wrote: Hi, I committed a patch in 7u4 b07 that conta

Re: [7u4] Request for approval for CR 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField

2012-02-13 Thread Edvard Wendelin
Approved. On 02/13/2012 02:59 PM, Leonid Romanov wrote: Hi, This is a request to push the following changes to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124272 webrev: http://cr.openjdk.java.net/~leonidr/MACOSX_PORT-675/webrev.01/ The fix has been reviewed on macosx-po

[7u4] Request for approval for 7124337: [macosx] FileDialog fails to select multiple files

2012-02-13 Thread Dmitry Cherepanov
This is a request to push the following fix to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124337 Webrev: http://cr.openjdk.java.net/~dcherepanov/7124337/webrev.0 Technical review: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/002917.html Thanks,

[7u4] Request for approval for 7141296: [macosx] Mouse Wheel Turn closes combobox popup

2012-02-13 Thread Alexander Potochkin
Hello This is a request to push the following fix to jdk 7u4: http://cr.openjdk.java.net/~alexp/7141296/webrev.01/ the bug's description is here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7141296 the fix was approved by Sergey Bylokhov and Mike Swingler Thanks alexp

hg: jdk7u/jdk7u-dev/jdk: 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField

2012-02-13 Thread alexander . zuev
Changeset: 3e3bbc2607eb Author:leonidr Date: 2012-02-13 20:30 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3e3bbc2607eb 7124272: [macosx] VK_DELETE does produce an extraneous character in a TextArea or TextField Reviewed-by: swingler ! src/macosx/classes/sun/lwawt

Re: [7u4] Code Review Request for CR 7082294 - nsk/regression/b4265661 crashes on windows

2012-02-13 Thread Edvard Wendelin
Approved. On 02/13/2012 03:44 PM, Oleg Pekhovskiy wrote: Hi guys! Please review the fix to push for the CR: http://bugs.sun.com/view_bug.do?bug_id=7082294 Webrev: http://cr.openjdk.java.net/~denis/7082294/webrev/ Reviewed by: uta Thanks, Oleg.

Re: [jdk7u-dev] Request for approval for 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode

2012-02-13 Thread Paul Hohensee
Hmm, this was redundant. My mailer had the request come in _after_ Edvard's approval! Sorry for the noise. Paul On 2/13/12 10:25 AM, Paul Hohensee wrote: Approved. Paul On 2/13/12 5:36 AM, Alexander Zuev wrote: Hello, this is a formal request to push fix for 7144064: [macosx] "Could not

Re: [jdk7u-dev] Request for approval for 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode

2012-02-13 Thread Paul Hohensee
Approved. Paul On 2/13/12 5:36 AM, Alexander Zuev wrote: Hello, this is a formal request to push fix for 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode into the jdk7u-dev workspace. Bug description is here: http://bugs.sun.com/bugdatabase/

[7u4] Code Review Request for CR 7082294 - nsk/regression/b4265661 crashes on windows

2012-02-13 Thread Oleg Pekhovskiy
Hi guys! Please review the fix to push for the CR: http://bugs.sun.com/view_bug.do?bug_id=7082294 Webrev: http://cr.openjdk.java.net/~denis/7082294/webrev/ Reviewed by: uta Thanks, Oleg.

hg: jdk7u/jdk7u-dev/jdk: 7143070: test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit

2012-02-13 Thread denis . fokin
Changeset: a2377cb4f790 Author:bagiras Date: 2012-02-13 17:53 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a2377cb4f790 7143070: test/java/awt/print/PaintSetEnabledDeadlock/PaintSetEnabledDeadlock.java freezes on exit Reviewed-by: anthony ! test/java/awt/print/Pa

Re: [7u4] Request for approval for CR 7114611 - (fs) DirectoryStream fails with SIGBUS on some embedded platforms, dirent alignment

2012-02-13 Thread Carlos Lucasius

Re: [7u4] Request for approval: 7124528 [macosx] Selection is not cleared properly in text component.

2012-02-13 Thread Edvard Wendelin
Approved. On 02/13/2012 12:59 PM, Sergey Bylokhov wrote: Hello, This is a request to push the following changes to jdk7u-dev. The fix has been reviewed on macosx-port-dev mailing list by Mike Swingler. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124528 Webrev can be found at: ht

Mailing list/server problems

2012-02-13 Thread Edvard Wendelin
Hi, It seems like some emails aren't getting through to the jdk7u-dev mailing list. That means that we might not get your approval requests. If you one waiting for response from one of the maintainers and you haven't seen any activity for 3-4 days, please re-send. Cheers, Edvard Ps. Sometim

[7u4] Request for approval: 7124528 [macosx] Selection is not cleared properly in text component.

2012-02-13 Thread Sergey Bylokhov
Hello, This is a request to push the following changes to jdk7u-dev. The fix has been reviewed on macosx-port-dev mailing list by Mike Swingler. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124528 Webrev can be found at: http://cr.openjdk.java.net/~serb/7124528/webrev.01 Technical rev

hg: jdk7u/jdk7u-dev/jdk: 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode

2012-02-13 Thread alexander . zuev
Changeset: 8daaca510253 Author:kizune Date: 2012-02-13 14:13 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8daaca510253 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode Reviewed-by: anthony ! src/solaris/native/java/lang/j

Re: [jdk7u-dev] Request for approval for 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode

2012-02-13 Thread Edvard Wendelin
Here is a link to the review thread, in case anyone is interested: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-February/002925.html Approved. Cheers, Edvard On 02/13/2012 11:36 AM, Alexander Zuev wrote: Hello, this is a formal request to push fix for 7144064: [macosx] "Coul

[jdk7u-dev] Request for approval for 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode

2012-02-13 Thread Alexander Zuev
Hello, this is a formal request to push fix for 7144064: [macosx] "Could not find class" error in JTree's ctor when called in headless mode into the jdk7u-dev workspace. Bug description is here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144064 Webrev with fix can be found

Re: [7u4] Request for approval for 7124337: [macosx] FileDialog fails to select multiple files

2012-02-13 Thread Edvard Wendelin
Approved. On 02/13/2012 10:08 AM, Dmitry Cherepanov wrote: This is a request to push the following fix to jdk7u-dev: CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124337 Webrev: http://cr.openjdk.java.net/~dcherepanov/7124337/webrev.0 Technical review: http://mail.openjdk.java.net