I confirm my review for the public record.
David
On 29/06/2012 10:27 AM, Mike Duigou wrote:
Hello all;
I made a merge error in the final revision
(http://cr.openjdk.java.net/~mduigou/7180240/1/webrev/) of CR#7180240 that went
unnoticed until after commit. This patch corrects that error.
The
Hello all;
I made a merge error in the final revision
(http://cr.openjdk.java.net/~mduigou/7180240/1/webrev/) of CR#7180240 that went
unnoticed until after commit. This patch corrects that error.
The current patch for review:
http://cr.openjdk.java.net/~mduigou/7180621/0/webrev/
This change i
Hi Mike,
You seem to have forgotten to now disable alt hashing in Hashtable.java
- the default is back to 512.
Otherwise, apart from the in CHM I don't see any problems.
Thanks,
David
On 29/06/2012 2:31 AM, Mike Duigou wrote:
I have updated the webrev to include feedback from reviewers and
Changeset: a73386183d31
Author:mduigou
Date: 2012-06-28 11:41 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a73386183d31
7180240: Disable alternative string hashing by default
Summary: Disables by default the alternative hashing approach used by
Hashtable, HashMap,
Thanks for the updates. Looks good. One minor thing, the markup in the comment
at line 188 of CHM.java contains "" which doesn't seem correct. I think you
want a plain "" start tag.
BTW, for interested readers, I spoke with Mike personally and he said the
"fail-fast" approach of throwing an Er
I have updated the webrev to include feedback from reviewers and improve the
documentation.
http://cr.openjdk.java.net/~mduigou/7180240/1/webrev/
The only substantive changes are to rename several fields to be more consistent
about naming. ie. use "alternative" rather than "alternate".
I also
Retroactively approved.
Cheers,
Edvard
On 06/27/2012 01:38 PM, Denis S. Fokin wrote:
Good day.
I hereby request an approval to backport a fix for CR 7112115.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7112115
JDK8 changeset
http://hg.openjdk.java.net/jdk8/awt-gate/jdk/rev/fd2785
Pre-approved pending positive review. If you don't make the snapshot for
B17 we can arrange that you either push the fix or that we do a final
syncup of 7u-dev before next weeks build.
Cheers,
Edvard
On 06/27/2012 11:34 PM, Mike Duigou wrote:
Hello all;
Following testing and feedback the alt
Hi,
Due to July 4th being a public holiday in the US and how that affects
integration schedules, I'd like to propose that we move the creation of
the forest to July 5th and the jdk7u6-b17 tag instead.
Sorry for the late notice, but it was feedback we got after the first
email was sent out.
