OK, it looks like these files are identical to the Linux and Solaris versions.
Approved.
s'marks
On 7/22/13 11:22 AM, alexey zhebel wrote:
Hi Mikael, Joe, Stuart, and everyone on the jdk7u-dev list!
You have already seen these changes recently, so it should be a quick review.
It turns out tha
Vote: Yes.
On 7/22/13 6:42 AM, Daniel Fuchs wrote:
I hereby nominate Jaroslav Bachorik to JDK 7 Updates Committer.
Jaroslav is already a JDK 8 committer and has contributed
several changes to JDK 7 Updates:
http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d76eee9b4820
http://hg.openjdk.java.
Hi Alexey,
The new man pages are a big improvement over the previous ones.
There are still a number of formatting issues that need to be corrected, but
these can be postponed until later, as I understand the difficulties of trying
to fix up the toolchain under a release deadline.
I think I m
On 6/18/13 12:49 AM, alexey zhebel wrote:
We are moving to a new process for generating man pages. I checked in the two
that changed for 7u40 (java and jcmd):
http://cr.openjdk.java.net/~azhebel/8016767/
Please review.
Note that the copyright/license information format was approved by Donald Sm
Vote: yes
On 2/22/13 6:35 AM, Dalibor Topic wrote:
I hereby nominate Edvard Wendelin to JDK 7 Updates Project Committer.
As one of this Project's Maintainers, Edvard has been active in this
Project since its creation. He has gradually accumulated the necessary
commits by contributing across mul
esses when an easy opportunity arises.
Darryl
On 02/11/2013 06:06 PM, Stuart Marks wrote:
Arrgh, ya caught me! :-) I was aware of this issue but I wanted to leave it
out of this discussion since it's a potential distraction.
No, jdk-regt...@sun.com (mentioned in the TEST.ROOT file) is not a v
Changeset: a724ea5862a7
Author:smarks
Date: 2013-02-12 14:41 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a724ea5862a7
8007515: TEST_BUG: update ProblemList.txt and TEST.ROOT in jdk7u-dev to match
jdk8
Reviewed-by: alanb, mchung, dmocek
! test/ProblemList.txt
! te
to match 8.
s'marks
On 2/11/13 3:15 PM, Darryl Mocek wrote:
Stuart,
is jdk-regt...@sun.com still a valid email address?
Darryl
On 02/11/2013 03:02 PM, Stuart Marks wrote:
On 2/9/13 7:49 AM, Alan Bateman wrote:
On 09/02/2013 00:51, Stuart Marks wrote:
A simple request for code review *a
On 2/9/13 7:49 AM, Alan Bateman wrote:
On 09/02/2013 00:51, Stuart Marks wrote:
A simple request for code review *and* integration approval for the following
bugfix:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007515
http://cr.openjdk.java.net/~smarks/reviews/8007515/webrev.0
Hi all,
A simple request for code review *and* integration approval for the following
bugfix:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007515
http://cr.openjdk.java.net/~smarks/reviews/8007515/webrev.0/
Now that all the RMI test fixes have been backported, this reconciles
Changeset: 19db25f92f6e
Author:smarks
Date: 2013-01-07 18:09 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/19db25f92f6e
7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails
intermittently
Summary: Tighten up JavaVM test library API, and adjust tes
Hi all,
This backport is a fix to a particular RMI test. It had a bad race condition
that occasionally left a process running. Gory details in the bug report.
This test is actually on the problem list in 7u -- it's not in 8. I'll leave it
on in 7u for the moment until I do a comprehensive rem
Hi all,
This is a fix for a bug in the RMI CheckUsage test, along with some more RMI
test infrastructure cleanup and adjustment of other RMI tests to match.
The patch mostly applied cleanly, with the exception of some conflicts over
copyright notices, and a mismatch in the jdk/test/ProblemLis
Changeset: 587f4a6dfdc9
Author:jgish
Date: 2012-12-05 21:08 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/587f4a6dfdc9
8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception
not reported
Reviewed-by: alanb, dmocek, smarks
! test/java/rmi/tes
Hi all,
Requesting to backport this cleanup of RMI's test subprocess mechanism.
Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005290
Review:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-December/013149.html
Changeset:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/60a
Hi all,
This is a request to backport two RMI test library changes. They're closely
related so I want to push them in at the same time.
8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception
not reported
Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=800431
Changeset: 2e1d87e5637a
Author:olagneau
Date: 2013-01-18 11:03 +
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2e1d87e5637a
8000978: [Fmt-De] DecimalFormat produces wrong format() results when close to a
tie
Summary: Adds correct tie rounding behavior in alt-rt.jar se
On 12/20/12 7:33 AM, Andrew Hughes wrote:
I was surprised to see these being backported. I can follow the reasoning for
doing so, but we must be careful of introducing unwanted behaviour changes
through a fix which isn't really required in a maintenance release.
I'm not thinking so much of the
Changeset: 388b32b60fbb
Author:khazra
Date: 2012-03-02 13:48 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/388b32b60fbb
7146763: Warnings cleanup in the sun.rmi and related packages
Summary: Cleanup warnings and use jkd7 features in sun.rmi.*
Reviewed-by: smarks, che
Hi all,
This is a request to backport some RMI warnings fixes. I'm not actually very
concerned with warnings in 7u. This is really about making the RMI source code
in 7u and 8 more consistent. In backporting other changes, I've found that the
warnings fixes generate conflicts, and in general t
Changeset: 288fc2442d9e
Author:smarks
Date: 2012-12-12 09:53 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/288fc2442d9e
8004748: clean up @build tags in RMI tests
Reviewed-by: alanb, darcy, mchung
! test/java/rmi/MarshalledObject/compare/Compare.java
! test/java/rmi
Hi all,
This is a request to backport a test fix from jdk8 into jdk7u-dev:
8004748: clean up @build tags in RMI tests
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004748
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84d0927a2e
http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-De
Changeset: f1320351fb33
Author:jjg
Date: 2012-08-28 10:29 +0100
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/f1320351fb33
7194032: update tests for upcoming changes for jtreg
Reviewed-by: alanb, iris, smarks
! test/java/rmi/activation/Activatable/extLoadedImpl/ext.sh
! t
Changeset: fa4c5ccae790
Author:chegar
Date: 2011-10-24 20:55 +0100
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fa4c5ccae790
7104209: Cleanup and remove librmi (native library)
Reviewed-by: mduigou, alanb, smarks
! make/java/java/mapfile-vers
! make/sun/rmi/rmi/Makefile
Hi all,
I'd like approval to backport the following fix:
7194032: update tests for upcoming changes for jtreg
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194032
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/06d0478023ca
The review thread is here:
http://mail.openjdk.java.net/pipermail/c
Hi all,
I'm trying to keep the RMI code base in synch between 7u and 8. As part of this
I'd like to backport the following two changesets from 8 to 7u:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7104209
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3f391e649ccb
http://bugs.sun.com/bugd
Changeset: 8aefbd1d1efc
Author:smarks
Date: 2012-09-20 13:29 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8aefbd1d1efc
7199637: TEST_BUG: add serialization tests to jdk7u problem list for macosx
Reviewed-by: alanb, coffeys
! test/ProblemList.txt
Thanks. Can I get a code review from someone as well? Or does this constitute
both code review and push approval? :-)
s'marks
On 9/20/12 3:11 AM, Seán Coffey wrote:
Approved for jdk7u-dev.
regards,
Sean.
On 20/09/2012 06:49, Stuart Marks wrote:
This is a request for review and approv
This is a request for review and approval to push a change to add several tests
to the problem list in 7u. These tests are already on the problem list in JDK8.
They were added by Michael McMahon and Alan Bateman (cc'd).
The tests in question are among the set of tests listed in this bug report:
Changeset: 36e966571ab8
Author:dmocek
Date: 2012-09-08 00:03 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/36e966571ab8
6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing
intermittently
Reviewed-by: dholmes, smarks
Contributed-by: Eric Wang
Changeset: 92c7d1df9851
Author:dmocek
Date: 2012-08-02 18:12 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/92c7d1df9851
7187876: ClassCastException in TCPTransport.executeAcceptLoop
Reviewed-by: dholmes, smarks
! src/share/classes/sun/rmi/transport/tcp/TCPTransport.
Changeset: 547880604844
Author:dmocek
Date: 2012-08-10 09:04 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/547880604844
7142596: RMI JPRT tests are failing
Summary: Changed RMI tests to use random port numbers for the RMI Registry and
RMID so the tests can be run co
OK. As one of reviewers for all of these changes, and as the one who'll do the
actual push, I guess this is a reasonable way to go.
Darryl, do the individual changesets all apply cleanly? If so I can just export
them from jdk8 myself and apply them to jdk7u and then push them. Or, let me
know
d the missing spaces after "if" in a few cases.
Mike
On Jun 27 2012, at 15:46 , Stuart Marks wrote:
Oh, one more thing...
If there is an illegal negative value or a syntactically invalid value given to
the property, this will throw an Error from the Holder class, which will
proba
OK to fail fast, as opposed to silently
ignoring the value, but I wanted to check to make sure this was the intent.
s'marks
On 6/27/12 3:40 PM, Stuart Marks wrote:
Hi Mike,
The changes themselves seem simple enough.
I have a few other comments though. I didn't see them raised in the
Hi Mike,
The changes themselves seem simple enough.
I have a few other comments though. I didn't see them raised in the earlier
reviews, though of course I could have missed something. Please use your
judgment in deciding what changes you make in response.
There's an odd asymmetry between CH
36 matches
Mail list logo
