hg: jdk7u/jdk7u-dev/hotspot: 8058936: hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg)

2014-09-24 Thread staffan . larsen
Changeset: 4c218194cc6c Author:sla Date: 2014-09-24 09:49 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/4c218194cc6c 8058936: hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg) Reviewed-by: dholmes, stefank

[7u-dev] Request for approval for 8058936 hotspot/test/Makefile should use jtreg script from $JT_HOME/bin/jreg (instead of $JT_HOME/win32/bin/jtreg)

2014-09-24 Thread Staffan Larsen
Please approve this backport from 9 and 8u. The fix applies cleanly. bug: https://bugs.openjdk.java.net/browse/JDK-8058936 jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/01961999c58a review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-September/015409.html T

Re: RFR: 8041980 + 6461635

2014-08-29 Thread Staffan Larsen
Looks good! (not a Reviewer for jdk7u) Thanks, /Staffan On 28 aug 2014, at 16:43, Andreas Eriksson wrote: > Summary: > This is a backport of a change that fixes problems with jvmstat, where it > can't find local JVM processes. > Also backported is a change that improves tests related to this a

hg: jdk7u/jdk7u-dev/jdk: 8046024: JDI shared memory transport failed with "Observed abandoned IP mutex"

2014-06-23 Thread staffan . larsen
Changeset: 488d331ecd1e Author:sla Date: 2014-06-19 12:56 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/488d331ecd1e 8046024: JDI shared memory transport failed with "Observed abandoned IP mutex" Reviewed-by: alanb ! src/windows/transport/shmem/shmem_md.c

[7u80] request for approval of backport of JDK-8046024: JDI shared memory transport failed with "Observed abandoned IP mutex"

2014-06-19 Thread Staffan Larsen
I’d like to backport this backout of a previous change. See the jdk 9 review request for details. bug: https://bugs.openjdk.java.net/browse/JDK-8046024 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-June/015077.html jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/jdk

Re: CFV: New JDK 7u Committer: Ivan Gerasimov

2014-04-10 Thread Staffan Larsen
Vote: yes On 10 apr 2014, at 20:45, Seán Coffey wrote: > I hereby nominate Ivan Gerasimov (igerasim) to JDK 7u Committer. > > Ivan is a member of the Java SE Sustaining team and works on all issues > connected to the JDK core libraries. He's already a committer in the JDK 9 > Project. His JDK

Re: [7u-dev] Request for approval (8019800 approval) RR(XS): Test sun/tools/jcmd/jcmd-f.sh failing after JDK-8017011

2014-02-18 Thread Staffan Larsen
On 18 feb 2014, at 14:23, Seán Coffey wrote: > > On 18/02/2014 13:06, Staffan Larsen wrote: >> The fix is in the jdk repo, not in hotspot. Is it the repo or the Component >> in Jira that decides if approvals are needed? > good point Staffan. Given that the fix is self

Re: [7u-dev] Request for approval RR(XS): Test sun/tools/jcmd/jcmd-f.sh failing after JDK-8017011

2014-02-18 Thread Staffan Larsen
The fix is in the jdk repo, not in hotspot. Is it the repo or the Component in Jira that decides if approvals are needed? /Staffan On 18 feb 2014, at 13:48, Seán Coffey wrote: > Results look good Dmitry. Since this is in hotspot category, you can push to > the hsx team forest. > You don't nee

Re: [7u-dev] RR(XS): Test sun/tools/jcmd/jcmd-f.sh failing after JDK-8017011

2014-02-16 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 14 feb 2014, at 19:21, Dmitry Samersoff wrote: > Hi Everyone, > > Please review the fix. > > The fix remove a colon (:) from file with reference output. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8019800/webrev.01/ > > -Dmitry > > -- > Dmitry Samersoff

hg: jdk7u/jdk7u-dev/jdk: 8024027: Test sun/misc/IoTrace/IoTraceSocketReadWrite.java crashes VM

2013-09-24 Thread staffan . larsen
Changeset: 64054ee415d5 Author:sla Date: 2013-09-23 19:33 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/64054ee415d5 8024027: Test sun/misc/IoTrace/IoTraceSocketReadWrite.java crashes VM Reviewed-by: alanb ! test/sun/misc/IoTrace/IoTraceAgent.java ! test/sun/misc/Io

[7u-dev] Request for approval for 8024027 Test sun/misc/IoTrace/IoTraceSocketReadWrite.java crashes VM

2013-09-23 Thread Staffan Larsen
I would like to push this test fix to 7u-dev. This fix is only applicable to jdk7. This test uses byte code instrumentation and there were two errors in the test which under some circumstances caused the VM to crash. I have updated the test to run with -Xverify:all which would have caught the p

hg: jdk7u/jdk7u-dev/jdk: 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X

2013-09-22 Thread staffan . larsen
Changeset: bcea927e7d16 Author:sla Date: 2013-08-29 11:22 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bcea927e7d16 8023786: (jdk) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes ! src/share/back/SDE.c ! src/share/native/common/check_cod

[7u60] Request for approval for 8023786 (jdk) setjmp/longjmp changes the process signal mask on OS X

2013-09-22 Thread Staffan Larsen
I would like to push this change 7u-dev. It is the same change as has previously been made in jdk8. bug: https://bugs.openjdk.java.net/browse/JDK-8023786 jdk8 review: http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-August/011382.html jdk8 changeset: http://hg.openjdk.java.net/jdk8

hg: jdk7u/jdk7u-dev/jdk: 7023754: Jconsole javascript plugin demo throws exception on window.print

2013-08-21 Thread staffan . larsen
Changeset: 0f2736e4f577 Author:egahlin Date: 2013-08-21 13:25 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0f2736e4f577 7023754: Jconsole javascript plugin demo throws exception on window.print Reviewed-by: mchung, sundar, arieber ! src/share/demo/scripting/jconso

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2013-08-17 Thread staffan . larsen
Changeset: bc663206afc1 Author:sla Date: 2013-03-05 19:25 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bc663206afc1 8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket Reviewed-by: alanb ! src/share/b

[7u60] Request for approval for 8009397 and 8009558

2013-08-16 Thread Staffan Larsen
This is a request for backporting the two following related bugs: JDK-8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport library missing onLoad entry: private_dt_socket JDK-8009558: linked_md.c::dll_build_name can get stuck in an infinite loop http://bugs.sun.com/view_bug.do?bug

hg: jdk7u/jdk7u40-dev/jdk: 8019155: Update makefiles with correct jfr packages

2013-06-26 Thread staffan . larsen
Changeset: d6179d8024a8 Author:sla Date: 2013-06-26 19:15 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/d6179d8024a8 8019155: Update makefiles with correct jfr packages Reviewed-by: erikj, mgronlun, dholmes, tbell ! make/common/Release.gmk

[7u40] Request for phase 2 approval for CR 8019155 - Update makefiles with correct jfr packages

2013-06-26 Thread Staffan Larsen
This is a small fix for make/common/Release.gmk which needs to be updated to include the package jdk.internal.jfr.events in jfr.jar. webrev: http://cr.openjdk.java.net/~sla/8019155/webrev.00/ review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-June/010325.html reviewed

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Staffan Larsen
Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote: > Looks good to me, but I'm not a jdk7 reviewer. > > /Erik > > On 2013-06-26 09:42, Staffan Larsen wrote: >> Pl

[7u40] Request for approval for CR8014969: Use open man pages when DISABLE_COMMERCIAL_FEATURES=true

2013-05-24 Thread Staffan Larsen
A retroactive request for approval for the following review: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2013-May/006471.html /Staffan

hg: jdk7u/jdk7u-dev/jdk: 8014969: Use open man pages for non commercial builds

2013-05-24 Thread staffan . larsen
Changeset: c4788be627ad Author:erikj Date: 2013-05-24 08:59 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c4788be627ad 8014969: Use open man pages for non commercial builds Reviewed-by: tbell ! make/common/Release.gmk

Re: CFV: New JDK 7 Updates Project Committer: Edvard Wendelin

2013-02-25 Thread Staffan Larsen
Vote: yes. On 22 feb 2013, at 15:35, Dalibor Topic wrote: > I hereby nominate Edvard Wendelin to JDK 7 Updates Project Committer. > > As one of this Project's Maintainers, Edvard has been active in this > Project since its creation. He has gradually accumulated the necessary > commits by cont

hg: jdk7u/jdk7u-dev/jdk: 8008089: Delete OS dependent check in JdkFinder.getExecutable()

2013-02-20 Thread staffan . larsen
Changeset: 3e970744cf43 Author:ykantser Date: 2013-02-13 10:24 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3e970744cf43 8008089: Delete OS dependent check in JdkFinder.getExecutable() Reviewed-by: egahlin, alanb ! test/lib/testlibrary/jdk/testlibrary/JdkFinder.jav

hg: jdk7u/jdk7u-dev/jdk: 8006757: Refactor Socket and File I/O tracing

2013-02-13 Thread staffan . larsen
Changeset: 0ccb6896143c Author:sla Date: 2013-02-13 11:04 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0ccb6896143c 8006757: Refactor Socket and File I/O tracing Summary: Allow deferring evaluation/object allocations until we know events will be written, which may

hg: jdk7u/jdk7u-dev/jdk: 8007142: Add utility classes for writing better multiprocess tests in jtreg

2013-02-07 Thread staffan . larsen
Changeset: 884f845f48a9 Author:ykantser Date: 2013-02-07 11:22 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/884f845f48a9 8007142: Add utility classes for writing better multiprocess tests in jtreg Reviewed-by: alanb, rbackman + test/lib/testlibrary/OutputAnalyzerTe

Re: CFV: New JDK7u Committer: David Buck

2013-02-04 Thread Staffan Larsen
Vote: yes. On 1 feb 2013, at 18:34, Alexander Potochkin wrote: > I hereby nominate David Buck to jdk7u Committer. > > Buck has been a member of the Java SE sustaining team for two years now. > He has spent most of that time working on JRockit, > but is also responsible for working on client a

hg: jdk7u/jdk7u-dev/jdk: 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

2012-12-06 Thread staffan . larsen
Changeset: b490b3dce2e2 Author:sla Date: 2012-11-30 08:17 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b490b3dce2e2 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo Reviewed-by: okutsu ! test/java/util/TimeZone/Bug6912560.java

[7u12] Request for approval for CR 7155168 - java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

2012-12-04 Thread Staffan Larsen
This is a request to backport the fix for 7155168 to 7u12. Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-November/012459.html Changeset from jdk8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55f8ddc2f9c6 Description: The problem with the test is that it fails when runn

hg: jdk7u/jdk7u-dev/jdk: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-27 Thread staffan . larsen
Changeset: bcba89ce0a8c Author:sla Date: 2012-11-27 09:23 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bcba89ce0a8c 8003322: Add instrumentation points for tracing of I/O calls Reviewed-by: alanb, mchung ! make/java/java/mapfile-vers ! src/share/classes/java/io/Fil

Adding instrumentation points for tracing of I/O calls

2012-11-21 Thread Staffan Larsen
I have recently started a review thread [1] on the core-libs-dev alias about a change to add instrumentation for I/O calls. This change was targeted at both 7u12 and 8. The consensus in that thread is that the changes look good, but should ideally be replaced by dynamic bytecode instrumentation.

Re: Request for approval: 8002078: hs_err_pid file should report full JDK version string

2012-11-08 Thread Staffan Larsen
. > > David > > On 8/11/2012 12:13 AM, Seán Coffey wrote: >> Approved for jdk7u-dev. >> >> Please try and pre-append subject line with e.g [7u12] for future requests! >> >> regards, >> Sean. >> >> On 07/11/2012 12:34, Staffan Larsen wr

Request for approval: 8002078: hs_err_pid file should report full JDK version string

2012-11-07 Thread Staffan Larsen
Hi, This is a request for approval to backport the fix for 8002078 from jdk8 to jdk7u. jdk8 changeset: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a1b8cf9cf970 jdk8 review: http://mail.openjdk.java.net/pipermail/hotspot-dev/2012-October/007130.html bug report: http://bugs.sun.com/bu

Re: CFV: New jdk7u Committer: Alejandro Murillo

2012-09-20 Thread Staffan Larsen
Vote: yes On 19 sep 2012, at 19:30, John Coomes wrote: > I hereby nominate Alejandro Murillo to jdk7u Committer. > > Alejandro is a performance engineer and also the HotSpot gatekeeper. > In the latter role he's responsible for delivering HotSpot sources > into jdk7 updates and other jdk releas

hg: jdk7u/jdk7u-dev: 2 new changesets

2012-06-20 Thread staffan . larsen
Changeset: 87686226a43a Author:sla Date: 2012-06-11 20:52 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/87686226a43a 7175802: Missing jdk_jfr in top-level make file Reviewed-by: alanb Changeset: 5192d6390c4a Author:sla Date: 2012-06-19 20:56 +0200 URL: h

hg: jdk7u/jdk7u-dev/jdk: 7165257: Add JFR tests to the JDK code base

2012-06-20 Thread staffan . larsen
Changeset: cd10e1413a76 Author:sla Date: 2012-06-07 15:28 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/cd10e1413a76 7165257: Add JFR tests to the JDK code base Reviewed-by: ohair, dholmes, nloodin, mgronlun ! make/jprt.properties ! test/Makefile

[7u6] Request for approval for CR7165257 / 7175802 - Add JFR tests to the JDK code base

2012-06-19 Thread Staffan Larsen
Please approve this change to makefiles to allow JFR tests to be run. JDK8 changesets: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82c41d3065e2 http://hg.openjdk.java.net/jdk8/tl/rev/1af3996aa431 Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-June/006247.ht

hg: jdk7u/jdk7u-dev/jdk: 7167157: jcmd command file parsing does not respect the "stop" command

2012-05-22 Thread staffan . larsen
Changeset: 05c4a1c2ce25 Author:sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/05c4a1c2ce25 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCm

[7u6] Request for approval for CR 7167157: jcmd command file parsing does not respect the "stop" command

2012-05-22 Thread Staffan Larsen
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7167157 Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/006024.html JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1ef7e07e01 Thanks, /Staffan

hg: jdk7u/jdk7u-dev/jdk: 7154809: JDI: update JDI/JDB debugee commandline option parsing

2012-05-22 Thread staffan . larsen
Changeset: 7498514309e3 Author:mgronlun Date: 2012-04-10 10:32 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7498514309e3 7154809: JDI: update JDI/JDB debugee commandline option parsing Summary: update debugee commandline parsing Reviewed-by: dcubed, dsamersoff, sla

hg: jdk7u/jdk7u-dev/jdk: 7163524: Add SecTaskAccess attribute to jstack [macosx]

2012-04-27 Thread staffan . larsen
Changeset: 57bc0bd2677e Author:sla Date: 2012-04-23 16:34 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/57bc0bd2677e 7163524: Add SecTaskAccess attribute to jstack [macosx] Reviewed-by: dholmes ! make/launchers/Makefile.launcher

[7u6] Request for approval: 7163524: Add SecTaskAccess attribute to jstack [macosx]

2012-04-27 Thread Staffan Larsen
Hi, This is a request to backport a fix from jdk8 to 7u6: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7163524 Changeset in jdk8: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd22345bf1bf Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-April/005881.html

Re: java.awt event processing performance degradation on JRE7 - linux

2012-04-24 Thread Staffan Larsen
Hi, I have reviewed this patch and it looks good to me. Thanks, /Staffan On 23 apr 2012, at 08:06, Nicolas Carranza wrote: > hi Anthony, > > The little patch against the current > http://hg.openjdk.java.net/jdk8/jdk8/jdk repo is attached. > Running: > time -f '%P' java PerformanceRegressionTe

hg: jdk7u/jdk7u-dev/jdk: 7147848: com.sun.management.UnixOperatingSystem uses hardcoded dummy values [macosx]

2012-04-19 Thread staffan . larsen
Changeset: e11d64c07182 Author:sla Date: 2012-04-17 06:45 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e11d64c07182 7147848: com.sun.management.UnixOperatingSystem uses hardcoded dummy values [macosx] Summary: Provide the missing implementation UnixOperatingSystem

[7u6] Request for approval for CR7147848 com.sun.management.UnixOperatingSystem uses hardcoded dummy values [macosx]

2012-04-19 Thread Staffan Larsen
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147848 JDK8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/869f53f58692 Review threads: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-April/005690.html http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-A

Re: CFV: New JDK7u Committer: Mike Swingler

2012-03-12 Thread Staffan Larsen
Vote: yes /Staffan On 12 mar 2012, at 18:52, Artem Ananiev wrote: > > I hereby nominate Mike Swingler (OpenJDK user name: swingler) to JDK7u > Committer. > > I don't think any more information about Mike should be provided here, we all > know Mike's contribution to Java. > > Votes are due b

Re: CFV: New JDK7u Committer: Scott Kovatch

2012-03-03 Thread Staffan Larsen
Vote: yes /Staffan On 2 mar 2012, at 20:41, Artem Ananiev wrote: > > I hereby nominate Scott Kovatch (OpenJDK user name: skovatch) to JDK7u > Committer. > > Many of us know Scott as a former member of Apple JDK team, and many pieces > of Mac OS X Port code were actually written by Scott lon

Re: [7u4] Request for approval for CR 7145925: Removing remote access to diagnostic commands in the HotSpotDiagnosticMBean

2012-02-16 Thread Staffan Larsen
It's being removed because of an outage in the design. We are note sure that ManagementPermission("control") is the appropriate permission for running diagnostic commands over JMX. Due to time pressure to deliver 7u4, we didn't have time to redesign this. The plan is to revisit the design, and p

hg: jdk7u/jdk7u-dev/jdk: 7141739: [osx] Local attach fails if java.io.tmpdir is set

2012-02-03 Thread staffan . larsen
Changeset: ab842d66b05a Author:sla Date: 2012-02-03 11:58 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ab842d66b05a 7141739: [osx] Local attach fails if java.io.tmpdir is set Summary: Make sure Hotspot and jdk looks for well-known files in the same locations Review

Subject: [7u4] Request for approval for CR 7141739 - [osx] Local attach fails if java.io.tmpdir is set

2012-02-02 Thread Staffan Larsen
This is a request to push the following fix to jdk7u-dev: Description: If the user sets -Djava.io.tmpdir to something else than /tmp, the attach framework will fail (for example stack). This is a followup of bug 7132199 (which fixed the problem for Linux and Solaris). Webrev: http://cr.openjdk.

hg: jdk7u/jdk7u-dev/jdk: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-02-01 Thread staffan . larsen
Changeset: 991f51db80db Author:sla Date: 2012-02-01 10:46 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/991f51db80db 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms Summary: Make sure HotSpot and JDK looks for well-known

[7u4] Request for approval for CR 7132199 - sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

2012-02-01 Thread Staffan Larsen
This is a backport of a fix in jdk8. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132199 JDK 8 changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/431bc327f34a Review request thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-January/005148.html Thanks, /Staff