Thanks Yong for the review and testing.
-michael
On 07/04/13 01:27, Yong Huang wrote:
It looks good to me. BTW, I am not a formal reviewer.
Testing result on internal build is at
http://aseng-wiki.us.oracle.com/asengwiki/display/i18n/JDK+7u40+PIT+L10n+Test.
There is no stopper bug found.
t
It looks good to me. BTW, I am not a formal reviewer.
Testing result on internal build is at
http://aseng-wiki.us.oracle.com/asengwiki/display/i18n/JDK+7u40+PIT+L10n+Test.
There is no stopper bug found.
thanks,
Yong
On 2013/7/3 11:42, Michael Fang wrote:
Hi all,
Please help to code review
Thanks Dalibor for the review!
-michael
On 07/03/13 07:26, Dalibor Topic wrote:
On 7/3/13 5:42 AM, Michael Fang wrote:
Hi all,
Please help to code review the changes for the following CR:
8019541 : 7u40 l10n resource file translation update
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=
Thanks Naoto.
-michael
On 07/03/13 14:11, Naoto Sato wrote:
Thank you for the confirmation. Looks good to me.
Naoto
On 7/3/13 12:51 PM, Michael Fang wrote:
Thank you Naoto for the review. Using simple diff, it's showing some
spacing difference (but not on webrev).
==
Thank you for the confirmation. Looks good to me.
Naoto
On 7/3/13 12:51 PM, Michael Fang wrote:
Thank you Naoto for the review. Using simple diff, it's showing some
spacing difference (but not on webrev).
===
comp
Thank you Naoto for the review. Using simple diff, it's showing some
spacing difference (but not on webrev).
===
comparing
./jdk/src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java
< old
> new
==
Hi Michael,
Looks like the following file does not contain any meaningful change:
(jdk)/src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java
Other changes look good to me (haven't looked at the translation itself).
Naoto
On 7/2/13 8:42 PM, Michael Fang wrote:
Hi all,
Please he
On 7/3/13 5:42 AM, Michael Fang wrote:
> Hi all,
>
> Please help to code review the changes for the following CR:
>
> 8019541 : 7u40 l10n resource file translation update
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019541
>
> The webrev is located at:
> http://cr.openjdk.java.net/~mfan
Hi all,
Please help to code review the changes for the following CR:
8019541 : 7u40 l10n resource file translation update
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019541
The webrev is located at:
http://cr.openjdk.java.net/~mfang/8019541/
Since we perform resource file translation u
