Re: [PATCH] Display human readable progress instead of many dots in jhat

2013-12-10 Thread Alan Bateman
On 10/12/2013 03:30, Xiaoguang Sun wrote: Display hunan readable progress instead of many dots in jhat There wasn't any patch attached to your mail but if you are proposing a patch to the jhat tool then the serviceability-dev is the mailing list to use. See also the "How to contribute" page [1]

Re: [7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

2013-12-10 Thread Seán Coffey
Thanks for the review Mandy. This looks good for 7u-dev Daniel. Approved. regards, Sean. On 09/12/2013 22:09, Mandy Chung wrote: Daniel, The fix looks good and approved. I think this test may be good to be included in JDK 9 (backport to 8u). But I'd like to get rid of its dependency on awt.

Re: [7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

2013-12-10 Thread Jaroslav Bachorik
Hi Daniel, On 9.12.2013 14:46, Daniel Fuchs wrote: Hi, This is a request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8025512/webrev.00/ bugid: https://bugs.openjdk.jav

hg: jdk7u/jdk7u-dev/jdk: 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

2013-12-10 Thread daniel . fuchs
Changeset: 3ba8d15adade Author:dfuchs Date: 2013-12-10 10:36 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3ba8d15adade 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled Summary: Logger.setParent needed a check to guard against man

Re: [7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

2013-12-10 Thread Daniel Fuchs
On 12/9/13 11:09 PM, Mandy Chung wrote: Daniel, The fix looks good and approved. I think this test may be good to be included in JDK 9 (backport to 8u). But I'd like to get rid of its dependency on awt. I wonder if this can be modified to create its own implementation of JavaAWTAccess in a sim

Re: [7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

2013-12-10 Thread Daniel Fuchs
On 12/10/13 10:41 AM, Jaroslav Bachorik wrote: Hi Daniel, On 9.12.2013 14:46, Daniel Fuchs wrote: Hi, This is a request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled webrev: http://cr.openjdk.java.net/~dfuchs/webrev_80

Review Request: backport 7197210: java/lang/invoke/CallSiteTest.java times out on armsflt

2013-12-10 Thread Jiangli Zhou
Hi, Please review and approve following backport change. http://cr.openjdk.java.net/~jiangli/7197210/webrev.7u60/ Those are test only change. Thanks, Jiangli

Re: Review Request: backport 7197210: java/lang/invoke/CallSiteTest.java times out on armsflt

2013-12-10 Thread Dalibor Topic
On 12/9/13 9:03 PM, Jiangli Zhou wrote: > Hi, > > Please review and approve following backport change. > > http://cr.openjdk.java.net/~jiangli/7197210/webrev.7u60/ > > Those are test only change. Looks fine. Approved for jdk7u-dev. cheers, dalibor topic -- Oracle Da

Re: [7u60] Request for phase 2 approval for 7 bugs

2013-12-10 Thread Seán Coffey
Thanks for following up on this Pete. Approved for jdk7u-dev! regards, Sean. On 09/12/2013 16:27, Pete Brunet wrote: This is a re-request. It was not clear from the first request that there are seven bugs being backported with one patch. This open part of this patch is as described before (se

Re: [PATCH] Display human readable progress instead of many dots in jhat

2013-12-10 Thread Xiaoguang Sun
Hi Alan, thanks for letting me know where to post the patch. But it's strange that you can't see the attachment whereas I can see it locally. Let me see if I will have problem to serviceability-dev mailing list. Xiaoguang On Tue, Dec 10, 2013 at 5:12 PM, Alan Bateman wrote: > On 10/12/2013 03:3

Re: [PATCH] Display human readable progress instead of many dots in jhat

2013-12-10 Thread Dmitry Samersoff
Xiaoguang, It looks like one of mailers strip off suspicious attachment. Please, rename it to .txt and try to send again. -Dmitry On 2013-12-10 15:11, Xiaoguang Sun wrote: > Hi Alan, thanks for letting me know where to post the patch. But it's > strange that you can't see the attachment wherea

Re: [PATCH] Display human readable progress instead of many dots in jhat

2013-12-10 Thread Xiaoguang Sun
Oh, I see. Thanks Xiaoguang On Tue, Dec 10, 2013 at 7:21 PM, Dmitry Samersoff < dmitry.samers...@oracle.com> wrote: > Xiaoguang, > > It looks like one of mailers strip off suspicious attachment. > > Please, rename it to .txt and try to send again. > > -Dmitry > > > On 2013-12-10 15:11, Xiaoguang

Re: Review Request: backport 7197210: java/lang/invoke/CallSiteTest.java times out on armsflt

2013-12-10 Thread Jiangli Zhou
Hi Dalibor, Thanks very much for the review and approval. I need a sponsor to help pushing the change into the jdk repository. Would you be able to help out? Thanks again, Jiangli

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

2013-12-10 Thread coleen . phillimore
Changeset: 30203a1714f4 Author:jiangli Date: 2012-11-05 12:51 -0500 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/30203a1714f4 7197210: java/lang/invoke/CallSiteTest.java failing on armsflt. Summary: Reduce work load and set longer timeout for java/lang/invoke tests. Revie