Re: [7u-dev] Request for approval for CR 7160604: Using non-opaque windows - popups are initially not painted correctly

Hello Rob, When I sent this request, both code reviewers Sergey Bylokhov and Alexander Scherbatiy were in the recipients of this e-mail. If it is considered that changing lambda expression (anonymous method) for implementation of Runnable interface in the regression test is a change requiring

Re: [7u-dev] Request for approval for CR 7160604: Using non-opaque windows - popups are initially not painted correctly

I think either reviewer simply approving the change on this mail thread is sufficient. Let's keep it simple. this is approved for 7u-dev push but subject to reviewer approval. regards, Sean. On 23/05/14 10:47, Anton Litvinov wrote: Hello Rob, When I sent this request, both code reviewers Ser

Re: RFR: 8038925: Java with G1 crashes in dump_instance_fields using jmap or jcmd without fullgc

On Thursday 22 May 2014 13.39.13 Andreas Eriksson wrote: > Hi, > > Bengt: > > Right, that should be enough, thanks. > > Mikael: > > Can I use you as a reviewer for this latest version as well? Yes, this looks fine. /Mikael > > Regards, > Andreas > > On 2014-05-22 13:02, Bengt Rutisson wrot

Re: RFR: 8038925: Java with G1 crashes in dump_instance_fields using jmap or jcmd without fullgc

Great, thanks. /Andreas On 2014-05-23 12:37, Mikael Gerdin wrote: On Thursday 22 May 2014 13.39.13 Andreas Eriksson wrote: Hi, Bengt: Right, that should be enough, thanks. Mikael: Can I use you as a reviewer for this latest version as well? Yes, this looks fine. /Mikael Regards, Andrea

Re: CFV: New JDK7u Committer: Sergey Gabdurakhmanov

Vote: Yes. On 12.05.2014 19:01, Alexander Potochkin wrote: I hereby nominate Sergey Gabdurakhmanov to jdk7u Committer. Sergey is a member of the Java SE JVM sustaining team. He has spent most of that time working on the hotspot and serviceability issues. He has contributed 11 changes to jdk7u

Re: CFV: New JDK7u Committer: Vladimir Kempik

Vote: Yes. On 09.05.2014 16:42, Kevin Walls wrote: Vote: yes On 30/04/14 16:08, Alexander Potochkin wrote: I hereby nominate Vladimir Kempik to jdk7u Committer. Vladimir is a member of the Java SE JVM sustaining team. He has spent most of that time working on the hotspot and serviceability i

[7u-dev] Request for approval for CR 8038925 - Java with G1 crashes in dump_instance_fields using jmap or jcmd without fullgc

Hi, Requesting push approval for JDK-8038925 , a jdk7 only fix. It has been reviewed by Bengt Rutisson and Mikael Gerdin. Bug: https://bugs.openjdk.java.net/browse/JDK-8038925 Webrev: http://cr.openjdk.java.net/~aeriksso/8038925/webrev.03/ Reg

Re: [7u-dev] Request for approval for CR 7160604: Using non-opaque windows - popups are initially not painted correctly

Hello Sean, Thank you for approval of this request to push. Alexander Scherbatiy the reviewer of the original fix has approved this backport fix at "awt-dev" alias. Reviewer approval - http://mail.openjdk.java.net/pipermail/awt-dev/2014-May/007869.html Thank you, Anton On 5/23/2014 2:23 P

hg: jdk7u/jdk7u-dev/jdk: 7160604: Using non-opaque windows - popups are initially not painted correctly

Changeset: 26ba36d4400c Author:alitvinov Date: 2014-05-23 16:29 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/26ba36d4400c 7160604: Using non-opaque windows - popups are initially not painted correctly Reviewed-by: serb, alexsch ! src/share/classes/javax/swing/JPopu

Re: [7u-dev] Request for approval for CR 8038925 - Java with G1 crashes in dump_instance_fields using jmap or jcmd without fullgc

Approved. regards, Sean. On 23/05/14 12:27, Andreas Eriksson wrote: Hi, Requesting push approval for JDK-8038925 , a jdk7 only fix. It has been reviewed by Bengt Rutisson and Mikael Gerdin. Bug: https://bugs.openjdk.java.net/browse/JDK-80389

RFA - 8042857: 14 stuck threads waiting for notification on LDAPRequest

Hi folks, Patch applies cleanly from 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8042857 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/474739f38cb3 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026956.html -Rob

Re: RFA - 8042857: 14 stuck threads waiting for notification on LDAPRequest

Approved. regards, Sean. On 23/05/14 16:33, Rob McKenna wrote: Hi folks, Patch applies cleanly from 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8042857 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/474739f38cb3 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-M

Re: RFR (XS): 8043210: Add _BIG_ENDIAN define on linux/sparc

Kumar, David - thanks for the reviews! Cheers, Mikael On 2014-05-22 19:37, David Holmes wrote: Looks good. David On 23/05/2014 6:13 AM, Mikael Vidstedt wrote: Please review the following change, destined for jdk7u-dev. The zip implementation in unpack200 depends on _BIG_ENDIAN being define

Request for approval - 8041451: com.sun.jndi.ldap.Connection:ReadTimeout should abandon ldap request

Hi folks, Very simple fix, applies cleanly: Bug: https://bugs.openjdk.java.net/browse/JDK-8041451 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e48e3e902f4c Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026981.html -Rob

[7u-dev] Request for approval - 8041451: com.sun.jndi.ldap.Connection:ReadTimeout should abandon ldap request

tut - missing release. -Rob On 23/05/14 19:48, Rob McKenna wrote: Hi folks, Very simple fix, applies cleanly: Bug: https://bugs.openjdk.java.net/browse/JDK-8041451 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e48e3e902f4c Review: http://mail.openjdk.java.net/pipermail/core-libs

Request for Approval: 8043210: Add _BIG_ENDIAN define on linux/sparc

Hello all; This request is for a 7u specific change (not a backport) the makefiles to ensure that _BIG_ENDIAN is defined for linux/sparc platforms. The JDK8 and JDK9 projects use a different makefile system and no change is needed there. The issue was previously reviewed on build-dev and this l