[7u-dev] Request for approval 8051359: [headless] JPopupMenu creation in headless mode with JDK9b23 causes NPE

2014-09-17 Thread dmitry markov
Hello, Could you approve the straight back-port of the fix for 8051359 to jdk7u-dev (jdk7u80), please? The bug: https://bugs.openjdk.java.net/browse/JDK-8051359 The webrev: http://cr.openjdk.java.net/~dmarkov/8051359/webrev.00/ The review threads: http://mail.openjdk.java.net/pipermail/awt-dev

Re: [7u-dev] Request for approval 8051359: [headless] JPopupMenu creation in headless mode with JDK9b23 causes NPE

2014-09-17 Thread Seán Coffey
Approved. regards, Sean. On 17/09/2014 09:05, dmitry markov wrote: Hello, Could you approve the straight back-port of the fix for 8051359 to jdk7u-dev (jdk7u80), please? The bug: https://bugs.openjdk.java.net/browse/JDK-8051359 The webrev: http://cr.openjdk.java.net/~dmarkov/8051359/webrev.

hg: jdk7u/jdk7u-dev/jdk: 8051359: JPopupMenu creation in headless mode with JDK9b23 causes NPE

2014-09-17 Thread dmitry . markov
Changeset: ae7b0ff91866 Author:dmarkov Date: 2014-09-17 12:59 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ae7b0ff91866 8051359: JPopupMenu creation in headless mode with JDK9b23 causes NPE Reviewed-by: serb, pchelko ! src/share/classes/sun/awt/SunToolkit.java

hg: jdk7u/jdk7u-dev/jdk: 8049343: (tz) Support tzdata2014g

2014-09-17 Thread aleksej . efimov
Changeset: fd488f5e328f Author:aefimov Date: 2014-09-12 14:23 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/fd488f5e328f 8049343: (tz) Support tzdata2014g Reviewed-by: mfang, okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazi

[7u-dev] Request for approval 8028280, 8038274: ParkEvent leak when running modified runThese which only loads classes

2014-09-17 Thread Sergey Gabdurakhmanov
Hello, Could you please approve the back-port of the fix for 8028280 and 8038274 to jdk7u-dev? Especially please check stubGenerator_sparc.cpp The bugs: https://bugs.openjdk.java.net/browse/JDK-8028280 https://bugs.openjdk.java.net/browse/JDK-8038274 The webrev: http://cr.openjdk.java.net/~sga

Re: [7u-dev] Request for approval 8028280, 8038274: ParkEvent leak when running modified runThese which only loads classes

2014-09-17 Thread Seán Coffey
1st prize goes to the hotspot team for failing to use noreg- labels! Please add them. Approved for jdk7u-dev but subject to peer code review. regards, Sean. On 17/09/14 11:49, Sergey Gabdurakhmanov wrote: Hello, Could you please approve the back-port of the fix for 8028280 and 8038274 to jd

[7u80] Request for approval for CR 4963723: Implement SHA-224

2014-09-17 Thread Andrew Hughes
This is the first of three backports to 7u designed to retain SSL compatibility with servers implemented in other languages switching to larger key sizes (notably DH >=2048 in Apache 2.4.7 [0]). This patch is a per-requisite of the patch which brings NSA Suite B support to 7. It applies largely un

Re: Compiling OpenJDK 7 on Arm

2014-09-17 Thread Andrew Hughes
- Original Message - > Hello, > > I am one of the community members of AdoptOpenJDK. > I've been able to build the OpenJDK 8 on my Arm (Raspberry pi) > > But since there is no configure, it seems the Makefile of 7 assumes x86. > > Can anyone tell me how to compile to target Arm (zero) an

Re: [7u80] Request for approval for CR 4963723: Implement SHA-224

2014-09-17 Thread Rob McKenna
Hi Andrew, Sorry to be a pest, but given the scope of the change I'd feel more comfortable with an explicit codereview for the backport. -Rob On 17/09/14 18:32, Andrew Hughes wrote: This is the first of three backports to 7u designed to retain SSL compatibility with servers implemented i

Re: [7u80] Request for approval for CR 4963723: Implement SHA-224

2014-09-17 Thread Andrew Hughes
- Original Message - > Hi Andrew, > > Sorry to be a pest, but given the scope of the change I'd feel more > comfortable with an explicit codereview for the backport. > > -Rob > > On 17/09/14 18:32, Andrew Hughes wrote: > > This is the first of three backports to 7u designed to ret

Re: [7u80] Request for approval for CR 4963723: Implement SHA-224

2014-09-17 Thread Rob McKenna
Code changes generally require two approvals: codereview, performed by a reviewer, (in this case from security-dev) and push approval, performed by a gatekeeper. Given your email template matches the push approval template I understood that you intended the latter. Generally speaking codereview