RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
Hello! This is a proposal to enhance the unshuffle_patch.sh script so that it will be able to read from stdin and write to stdout. This would let us use the script in a pipe chain. For example, the following line could be used to apply a patch directly from a remote repository: wget -q -O - h

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Daniel Fuchs
Hi Ivan, When setting output & input, I wonder if it would be simpler to use an 'if else if' construct in order to avoid the '-a' in the 'if' that follows. something like this (pseudo code) might be easier to read: if "x$output" is "x-" then substitute - with /dev/stdout else if $output file

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
Thank you Daniel for the comments! On 25.09.2014 13:49, Daniel Fuchs wrote: Hi Ivan, When setting output & input, I wonder if it would be simpler to use an 'if else if' construct in order to avoid the '-a' in the 'if' that follows. We would still need that -a in if, as the user could pass /dev

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Daniel Fuchs
Hi Ivan, Should 'usage' also be redirected? best regards, -- daniel On 25/09/14 12:12, Ivan Gerasimov wrote: Thank you Daniel for the comments! On 25.09.2014 13:49, Daniel Fuchs wrote: Hi Ivan, When setting output & input, I wonder if it would be simpler to use an 'if else if' construct in

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
On 25.09.2014 14:18, Daniel Fuchs wrote: Hi Ivan, Should 'usage' also be redirected? This would be inconsistent with other command line utilities. They usually print help/usage to stdout. Sincerely yours, Ivan best regards, -- daniel On 25/09/14 12:12, Ivan Gerasimov wrote: Thank you Da

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Chris Hegarty
On 25 Sep 2014, at 03:12, Ivan Gerasimov wrote: > Thank you Daniel for the comments! > > On 25.09.2014 13:49, Daniel Fuchs wrote: >> Hi Ivan, >> >> When setting output & input, I wonder if it would be simpler >> to use an 'if else if' construct in order to avoid the '-a' >> in the 'if' that fo

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Chris Hegarty
On 25 Sep 2014, at 00:42, Ivan Gerasimov wrote: > Hello! > > This is a proposal to enhance the unshuffle_patch.sh script so that it will > be able to read from stdin and write to stdout. > This would let us use the script in a pipe chain. > > For example, the following line could be used to a

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Daniel Fuchs
On 25/09/14 12:26, Ivan Gerasimov wrote: On 25.09.2014 14:18, Daniel Fuchs wrote: Hi Ivan, Should 'usage' also be redirected? This would be inconsistent with other command line utilities. They usually print help/usage to stdout. Right. I suspected something like that. This looks good! th

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

2014-09-25 Thread Ivan Gerasimov
Thank you Daniel and Chris for your review! Sincerely yous, Ivan Please see the updated webrev: http://cr.openjdk.java.net/~igerasim/8059101/1/webrev/ This looks ok to me.

[7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Vladimir Kozlov
Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8050022 jdk9 webrev: http://cr.openjdk.java.net/~morris/JDK-8050022.05 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Seán Coffey
Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 regards, Sean. On 25/09/2014 19:42, Vladimir Kozlov wrote: Backport request. Changes was pushed into jdk9 week ago. Nighties are fine. Changes are applied cleanly.

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Vladimir Kozlov
On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I also sent the request to hotspot-dev (since it is Hotspot changes) for backport to 8u40. Can I push to 7u after I p

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Seán Coffey
On 25/09/2014 20:06, Vladimir Kozlov wrote: On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I also sent the request to hotspot-dev (since it is Hotspot changes) for

Re: [7u-dev] Request for approval for 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread Vladimir Kozlov
Thank you, Sean. Vladimir On 9/25/14 12:14 PM, Seán Coffey wrote: On 25/09/2014 20:06, Vladimir Kozlov wrote: On 9/25/14 11:49 AM, Seán Coffey wrote: Vladimir, this needs to be pushed to the jdk8u code line first. http://openjdk.java.net/projects/jdk7u/groundrules.html : Rule 1 Yes, I al

hg: jdk7u/jdk7u-dev/hotspot: 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check

2014-09-25 Thread vladimir . kozlov
Changeset: c7f740ad8991 Author:morris Date: 2014-09-18 11:46 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/c7f740ad8991 8050022: linux-sparcv9: assert(SharedSkipVerify || obj->is_oop()) failed: sanity check Summary: Provide promoted stack slots for floating-poin