[7u-dev] Request for approval for 8031765: [TEST] Child process error stream is not empty!

2014-12-03 Thread Alexey Ivanov
Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8031765 Webrev: http://cr.openjdk.java.net/~pchelko/9/8031765/webrev/ Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-March/007274.html JDK9 c

Re: [7u-dev] Request for approval for 8031765: [TEST] Child process error stream is not empty!

2014-12-03 Thread Seán Coffey
Approved. regards, Sean. On 03/12/14 17:28, Alexey Ivanov wrote: Hello, Could you please approve the following direct backport of the fix to jdk7u-dev? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8031765 Webrev: http://cr.openjdk.java.net/~pchelko/9/8031765/webrev/ Review: http://mai

[7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
Hi! Would you please approve this direct backport from 8 to 7? Bug: https://bugs.openjdk.java.net/browse/JDK-8065765 Jdk8 changeset: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/c03d85ef5e6a Jdk8 Review: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-December/002618.html Sincer

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
On 03.12.2014 23:10, Ivan Gerasimov wrote: Hi! Would you please approve this direct backport from 8 to 7? Correction! In the test, lambda needs to be replaced with an anonymous class. Bug: https://bugs.openjdk.java.net/browse/JDK-8065765 Jdk8 changeset: http://hg.openjdk.java.net/jdk8u/h

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
In fact, Files.find() in the test has to be replaced with Files.walkFileTree() from jdk7 API. Thus, this is not only the approval request, but also request to review the changes in the tests. Sorry for the confusion, if any. WEBREV: http://cr.openjdk.java.net/~igerasim/8065765/0/webrev/ Since

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Mandy Chung
On 12/3/2014 1:00 PM, Ivan Gerasimov wrote: WEBREV: http://cr.openjdk.java.net/~igerasim/8065765/0/webrev/ Another alternative is to use Files.newDirectoryStream(path, "*.jar") and increment the count. What you have is okay too. Mandy

Re: [7u-dev] Request for Approval to Backport: 8065765: Missing space in output message from -XX:+CheckEndorsedAndExtDirs

2014-12-03 Thread Ivan Gerasimov
On 04.12.2014 2:44, Mandy Chung wrote: On 12/3/2014 1:00 PM, Ivan Gerasimov wrote: WEBREV: http://cr.openjdk.java.net/~igerasim/8065765/0/webrev/ Another alternative is to use Files.newDirectoryStream(path, "*.jar") and increment the count. What you have is okay too. Yes, this is much sh