Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

2015-01-22 Thread Seán Coffey
Pooja, your test case fix looks fine to me but I'm not a jdk7u reviewer. Can we get a jdk7u reviewer to review this simple change please ? regards, Sean. On 12/01/2015 07:04, pooja chopra wrote: Hi All, Please review below fix . 8064454 [TEST_BUG] Test tools/javac/innerClassFile/Driver.sh f

Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

2015-01-22 Thread Maurizio Cimadamore
It seems like the problematic rm in the last line has been removed i.e. in JDK 8? http://hg.openjdk.java.net/jdk8u/jdk8u-dev/langtools/file/2d2b2be57c78/test/tools/javac/innerClassFile/Driver.sh Perhaps, instead of tweaking permission, we should just do things the JDK 8 way? Maurizio On 12/

[7u-dev] Backport request: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call

2015-01-22 Thread Anton Nashatyrev
Hello, please approve the fix backport to jdk7u-dev. The patch was applied without any modifications. Artem, could you please approve the backport please? (you'd reviewed the original final fix) Bug: https://bugs.openjdk.java.net/browse/JDK-7171412 Jdk7 Webrev: http://cr.openjdk.ja

Re: [7u-dev] Backport request: 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call

2015-01-22 Thread dalibor topic
Hi Anton, we're in Rampdown phase 2 now. [0] That means the OpenJDK JDK 7 Updates jdk7u/jdk7u-dev forest is only open for showstopper fixes at this time. cheers, dalibor topic [0] http://mail.openjdk.java.net/pipermail/jdk7u-dev/2015-January/010240.html On 22.01.2015 14:56, Anton Nashatyre

Re: DSA with keylength > 1024 no longer accepted (solved)

2015-01-22 Thread Peter Haraldson
I just want to confirm that this applies only to RedHat:s patched version. In their release "java-1.7.0-openjdk-1.7.0.71-2.5.3.2.el6_6", which basically is OpenJDK 7, they added a patch that included this rule. I will turn to RedHat for further discussions. Thanks for your help! Regards peter

Re: DSA with keylength > 1024 no longer accepted (solved)

2015-01-22 Thread dalibor topic
Thanks, Peter. cheers, dalibor topic On 22.01.2015 15:49, Peter Haraldson wrote: I just want to confirm that this applies only to RedHat:s patched version. In their release "java-1.7.0-openjdk-1.7.0.71-2.5.3.2.el6_6", which basically is OpenJDK 7, they added a patch that included this rule. I

Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

2015-01-22 Thread pooja chopra
Hi Maurizio, In JDK 8 as I saw ' rm -rf src ' line of code has been simply removed from the code but "src" folder was temporarily created using 'mkdir src' in the Driver.sh code so I believe it should be removed if its created after use. Please suggest further . Regards, Pooja On 1/22/

Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

2015-01-22 Thread pooja chopra
Hi Maurizio , There is already a bug JDK-8057527 : tools/javac/innerClassFile/Driver.sh fails to cleanup files after it because of which ' rm -rf src ' piece of code was added so if we remove this then again bug JDK-8057527

Maintenance Review of Java SE 7 Platform (336)

2015-01-22 Thread Iris Clark
Hi. A few critical issues in the Java SE 7 Platform (JSR 336) [0] have been identified. To resolve them, there will be Maintenance Review [1] for the following updates: - Verification of a failed invokespecial call outside an method should be corrected - Verification of a failed invoke