Re: CFV: New jdk7u Committer: Kurchi Subhra Hazra

2012-05-10 Thread Kumar Srinivasan
Vote: yes I hereby nominate Kurchi Subhra Hazra to jdk7u Committer. Kurchi has committer role in the jdk8 project but only author role on jdk7u. The following queries match most of her recent activity: http://hg.openjdk.java.net/jdk8/tl/jdk/log?rev=khazra http://hg.openjdk.java.net/jdk8/tl

[7u8] Request for review and approval/backport: 7146424: Wildcard expansion for single entry classpath

2012-08-14 Thread Kumar Srinivasan
Hi All, This has been integrated into jdk8 the changesets are: [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188114 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3521fcad4b5f went in cleanly into 7u-dev, This one is a separated changeset, such that we can record the attribution credits,

[7u8] Request for review and approval: 7189944: (launcher) test/tools/launcher/Arrrrghs.java needs a couple of minor fixes

2012-08-14 Thread Kumar Srinivasan
Hi, Please review and approve webrev: http://cr.openjdk.java.net/~ksrini/7189944/webrev.0/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7189944 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44671e0b6d7 http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-August/011074.html Thanks Kuma

Re: [7u8] Request for review and approval/backport: 7146424: Wildcard expansion for single entry classpath

2012-08-15 Thread Kumar Srinivasan
intln(tr); Other than that, thumbs up - jjh On 8/14/2012 12:58 PM, Kumar Srinivasan wrote: Hi All, This has been integrated into jdk8 the changesets are: [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188114 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3521fcad4b5f went in cleanly in

Re: [7u8] Request for review and approval/backport: 7146424, 7188114, 7151434 : Wildcard expansion for single entry classpath

2012-08-15 Thread Kumar Srinivasan
a bug fix I exchanged mail with you about earlier this year! Ok Approved. modified webrev forthcoming Thanks Kumar regards, Sean. On 15/08/2012 20:26, Kumar Srinivasan wrote: Thanks Jim! - http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/src/share/bin/wildcard.c.frames.html

Re: [7u8] Request for review and approval/backport: 7146424, 7188114, 7151434 , 7170087 : Wildcard expansion for single entry classpath

2012-08-16 Thread Kumar Srinivasan
582 System.out.println(tr); Other than that, thumbs up - jjh On 8/14/2012 12:58 PM, Kumar Srinivasan wrote: Hi All, This has been integrated into jdk8 the changesets are: [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188114 http://hg.openjdk.java.net/jdk8/tl/jdk/

Re: [7u8] Request for review and approval/backport: 7146424, 7188114, 7151434 , 7170087 : Wildcard expansion for single entry classpath

2012-08-16 Thread Kumar Srinivasan
Hi David, Jim, Sean, Thanks for the reviews etc. Kumar Hi Kumar, Seems okay to me. David On 16/08/2012 9:17 PM, Kumar Srinivasan wrote: This addresses Jim's comments (he is on vacation) anyone else wants to review ? Delta webrev since the last reviewed one. http://cr.openjdk.jav

Re: CFV: New jdk7u Committer: Alejandro Murillo

2012-09-19 Thread Kumar Srinivasan
Vote: yes I hereby nominate Alejandro Murillo to jdk7u Committer. Alejandro is a performance engineer and also the HotSpot gatekeeper. In the latter role he's responsible for delivering HotSpot sources into jdk7 updates and other jdk releases; he's been working in this role for nearly a year an

Re: Request for approval: 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking

2012-11-01 Thread Kumar Srinivasan
Hello Deven, Looks good from a review standpoint, but you will need approval from the 7u "powers" :) Thanks Kumar Hi All, This is a request for approval to push the fix of 7166955 from jdk8 to jdk7u, could anyone take a look? Link to the bug: http://bugs.sun.com/bugdatabase/view_bug.do?b

[7u] Request approval for JDK-8006574

2013-02-01 Thread Kumar Srinivasan
Hello, Requesting approval for The bug: http://jbs.oracle.com/bugs/browse/JDK-8006574 The patch went in cleanly into 7u-dev and the patch is at: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea8f3ca83501 Discussions: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-January/014148.html T

[7u-dev] Request approval for: 8004042: Arrrghs.java test failed on windows with access error.

2013-03-07 Thread Kumar Srinivasan
Hello, Request approval to push to jdk7u-dev, this causes false positives in the nightly test runs. Patch: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/da387f0cecb7 Main Bug: http://bugs.sun.com/view_bug.do?bug_id=8004042 Backport bug: http://bugs.sun.com/view_bug.do?bug_id=8009707 Patch applie

[7u] Request for approval JDK-JDK-8007333: [launcher] removes multiple back slashes

2013-05-28 Thread Kumar Srinivasan
Hello, Please approve push of the following changeset to jdk7u-dev/jdk Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8007333 Changeset (no changes): http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e769206f036 Discussion: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/threa

[7u-dev] Request approval to push backport for: 8014363: javac test class ToolTester handles classpath incorrectly

2013-06-13 Thread Kumar Srinivasan
Hello, Please approve push to jdk7u-dev/langtools Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014363 Bug(Backport): http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016373 Changeset (no changes in jdk7u-dev/langtools) : http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e39669

Re: Review request for JDK-8020319: Update Japanese man pages for 7u40

2013-07-19 Thread Kumar Srinivasan
Hi Michael, Its hard to understand this webrev, having said that, what is going on with this ? -http://docs.oracle.com/javase/7/docs/technotes/guides/vm/gc\-ergonomics.html¤ò»²¾È¤·¤Æ¤¯¤À¤µ¤¤¡£ -.br -.br +http://docs\&.oracle\&.com/javase/1\&.5\&.0/docs/guide/vm/gc\-ergonomics\&.html +.sp why

[7u-dev] Request for approval for: JDK-8026794: Test tools/pack200/TimeStamp.java fails while opening golden.jar.native.IST on linux-ppc(v2)

2013-11-08 Thread Kumar Srinivasan
Hello, Please approve backport bug: https://bugs.openjdk.java.net/browse/JDK-8028042 which is a backport of: https://bugs.openjdk.java.net/browse/JDK-8026794 the patch: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ede89a97e80a was discussed at: http://mail.openjdk.java.net/pipermail/core-libs-

Re: RFR (XS): 8043210: Add _BIG_ENDIAN define on linux/sparc

2014-05-22 Thread Kumar Srinivasan
Looks good but IIRC PPC also needs this. Kumar On 5/22/2014 1:13 PM, Mikael Vidstedt wrote: Please review the following change, destined for jdk7u-dev. The zip implementation in unpack200 depends on _BIG_ENDIAN being defined on big endian platforms, and the define is missing on the linux/spa

Request approval for CR 7073631: javac parser improvements for error position reporting

2011-09-06 Thread Kumar Srinivasan
Hi, Request approval for 7u2 push, The bug description is here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7073631 The changeset in jdk8 is here: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/04f983e3e825 The changeset for 7u is identical to jdk8. No issues found in nightly testing

Re: [7u4] Request for approval for 7124627 - Please sync up changes from workspace macosx-port into the jdk7u-osx

2011-12-23 Thread Kumar Srinivasan
Launcher changes: I am not very happy about using #ifdef's in java.c we had taken steps to ensure that all platform dependent code, be removed from src/share/bin/java.c but it is unfortunate to see conditionals have crept in. My recommendation is to have SplashScreen as it is, but for Macos hav

Re: [7u4] Request for approval for 7124627 - Please sync up changes from workspace macosx-port into the jdk7u-osx

2011-12-23 Thread Kumar Srinivasan
x27;t need to address those issues right now. They do all need to be addressed before any further osx code is merged into the mainline repos for 8 or 7u. Whew!. Cheers, and Happy Holidays Thank you and wish everyone here the same. Kumar David On 24/12/2011 3:49 AM, Kumar Srinivasan

[7u4-osx] Request for approval for 7123392 (launcher) fix MacOSX launcher failures

2012-01-05 Thread Kumar Srinivasan
Hi, Please approve, CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7123392 Webrev: http://cr.openjdk.java.net/~ksrini/7123392/ Fixes for the launcher tests which fail with MacOSX and OpenJDK, a precursor to the re-factoring launcher work in progress. Thanks Kumar

Please review: 7124089: launcher refactoring

2012-01-16 Thread Kumar Srinivasan
Hi, Please review the launcher refactoring work, the webrev is here: http://cr.openjdk.java.net/~ksrini/7124089/webrev.0/ Notes: 1. Moves the majority of the launcher code into platform specific directories/files, removed redundant conditionals. 2. The solaris/linux code co-exists togeth

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-16 Thread Kumar Srinivasan
oops missed setting the subject line to 7ux-osx. Kumar Hi, Please review the launcher refactoring work, the webrev is here: http://cr.openjdk.java.net/~ksrini/7124089/webrev.0/ Notes: 1. Moves the majority of the launcher code into platform specific directories/files, removed redundant

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-17 Thread Kumar Srinivasan
n all three platforms - solaris/linux, macosx, and windows. It makes sense to define a function containing that code in the java.c and call it by platform-specific JVMInit() implementations where needed. Yes this can be done, I will look into it. Kumar -- best regards, Anthony On 1/17

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-17 Thread Kumar Srinivasan
out in a more sensible way. Kumar Like Anthony, I'm a bit concerned about the code duplications, although generally the changes look good. -Joe On 1/17/2012 8:35 AM, Kumar Srinivasan wrote: Hi Anthony, src/share/bin/java.c 987 } else if (IsMacOSX() && J

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-17 Thread Kumar Srinivasan
Hi Joe, Anthony, Please see inlined comments Hello, On 1/17/2012 8:35 AM, Kumar Srinivasan wrote: Hi Anthony, src/share/bin/java.c 987 } else if (IsMacOSX() && JLI_StrCmp(arg, "-XstartOnFirstThread") == 0) { 988 ProcessSpecialArg(arg); 989

Re: [7ux-osx] Please review: 7124089: launcher refactoring

2012-01-17 Thread Kumar Srinivasan
Kumar -- best regards, Anthony On 1/17/2012 7:33 AM, Kumar Srinivasan wrote: oops missed setting the subject line to 7ux-osx. Kumar Hi, Please review the launcher refactoring work, the webrev is here: http://cr.openjdk.java.net/~ksrini/7124089/webrev.0/ Notes: 1. Moves the majority

Re: [7u4-osx] Please review: 7124089: launcher refactoring v1.0

2012-01-20 Thread Kumar Srinivasan
Hi All, Based on all the comments from Anthony, Joe and David, here is the modified version: Highlights: 1. re-factored code in solaris directory to be shared with macosx, reducing duplication across the *nixes. 2. adjusted the makefilesto allow the above 2. eliminated all conditionals f

Re: [7u4-osx] Please review: 7124089: launcher refactoring v2.0

2012-01-21 Thread Kumar Srinivasan
objective-c, I could guess but would be better to document it in the makefile. -kto On Jan 20, 2012, at 8:24 AM, Kumar Srinivasan wrote: Hi All, Based on all the comments from Anthony, Joe and David, here is the modified version: Highlights: 1. re-factored code in solaris directory to be s

Re: [7u4-osx] Please review: 7124089: launcher refactoring v2.0

2012-01-23 Thread Kumar Srinivasan
e came up under the build project to document coding conventions for makefiles, and *ahem* a jcheck for Makefiles perhaps ? One more webrev coming up, later today. Kumar -kto On Jan 21, 2012, at 10:05 AM, Kumar Srinivasan wrote: Hi Kelly et. al., I have beautified/fixed the Makefiles addressi

Re: [7u4-osx] Please review: 7124089: launcher refactoring v2.0

2012-01-23 Thread Kumar Srinivasan
x27; does. Please add a comment on what the -Os compiler option means, and also the -x objective-c, I could guess but would be better to document it in the makefile. -kto On Jan 20, 2012, at 8:24 AM, Kumar Srinivasan wrote: Hi All, Based on all the comments from Anthony, Joe and David, her

[7u4-osx] Request approval for: 7124089: launcher refactoring

2012-01-24 Thread Kumar Srinivasan
Hi, This is a request to push the following fix to jdk7u-osx. CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124089 Webrev: http://cr.openjdk.java.net/~ksrini/7124089/webrev.3/ Reviewed by: anthony, darcy, dholmes, ohair Thanks Kumar

[7u4] Request approval for 7125442

2012-01-25 Thread Kumar Srinivasan
Hi All, Request approval for push into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk Patch: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/96fe796fd242 CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7125442 Patch is identical to the jdk8, ie. no fuss by hg when applying. Thanks Kumar

Re: [7u-osx] Request for review : 7140989: [MacOSX] Test Pack200Test fails on Mac

2012-01-30 Thread Kumar Srinivasan
Resending and including jdk7u-dev and John. Thanks Kumar Hi, Please review a simple fix to increase the residual memory threshold between the pack/unpack iterations, on Macs for whatever reason the residual memory exceeds by a mere 104K, thus causing a false positive, I have verified the res

[7u-osx] Request approval for 7140989

2012-01-30 Thread Kumar Srinivasan
Hi Request approval for push to http://hg.openjdk.java.net/jdk7u/jdk7u-osx/jdk http://cr.openjdk.java.net/~ksrini/7140989/webrev.0/ Reviewed by: jrose Thanks Kumar Resending and including jdk7u-dev and John. Thanks Kumar Hi, Please review a simple fix to increase the residual memory thre

Re: Mac OS X port - update

2012-02-03 Thread Kumar Srinivasan
On 2/3/2012 3:23 AM, Alan Bateman wrote: On 03/02/2012 02:10, David Holmes wrote: I am concerned. There was some discussion when various changes went into 7u-osx regarding the suitability of the changes for inclusion in the mainline repositories ie 7u-dev. It was my understanding that there

Re: Mac OS X port - update

2012-02-03 Thread Kumar Srinivasan
On 2/3/2012 7:36 AM, Alan Bateman wrote: On 03/02/2012 15:28, Kumar Srinivasan wrote: On 2/3/2012 3:23 AM, Alan Bateman wrote: On 03/02/2012 02:10, David Holmes wrote: I am concerned. There was some discussion when various changes went into 7u-osx regarding the suitability of the changes

Re: Mac OS X port - update

2012-02-06 Thread Kumar Srinivasan
Right now, JDK8 doesn't contain Mac OS X specific code, it cannot be built or run on Mac, so I don't see how individual fixes can be fw-ported. Instead, I would expect bulk migration from 7u to 8 similar to what Michael/Alex did for macosx-port to 7u-osx and 7u-osx to 7u-dev. The fixes I mad

Re: Repo locked?

2012-02-14 Thread Kumar Srinivasan
According to the census [1] you have author role. This means you will need to get someone to push the change-set for you. OK. Any volunteers? Ok, I will do the push. Kumar FYI, the webrev is here: http://cr.openjdk.java.net/~gkbrown/7134730/webrev.01/ It was reviewed by Kumar Srinivasan

Re: [7u6] Request for approval for CR 7141141 - Add 3 new test scenarios for testing Main-Class attribute in jar manifest file

2012-03-13 Thread Kumar Srinivasan
Hi Dalibor, I will be pushing this on behalf of Balachandra shortly. Kumar This changeset doesn't seem to have been pushed yet. cheers, dalibor topic On 2/23/12 4:52 PM, Edvard Wendelin wrote: Approved. On Feb 22, 2012, at 8:45 PM, Balchandra Vaidya wrote: Hi, This is a request to appr

Re: CFV: New JDK7u Committer: Mike Swingler

2012-03-14 Thread Kumar Srinivasan
Vote: yes I hereby nominate Mike Swingler (OpenJDK user name: swingler) to JDK7u Committer. I don't think any more information about Mike should be provided here, we all know Mike's contribution to Java. Votes are due by Mar 26, 2012. Only current JDK7u Committers [1] are eligible to vote

Re: CFV: New JDK7u Committer: Scott Kovatch

2012-03-14 Thread Kumar Srinivasan
Vote: yes I hereby nominate Scott Kovatch (OpenJDK user name: skovatch) to JDK7u Committer. Many of us know Scott as a former member of Apple JDK team, and many pieces of Mac OS X Port code were actually written by Scott long time ago. He is now a member of development and client teams at O

Re: Review for 7155419

2012-03-21 Thread Kumar Srinivasan
It looks generally good, few comments, can be fixed for the next release. 1. Standardize the terms JVM and HotSpot it seems to be used interchangeably, good idea to fix them correctly for the next release. 2. URLs ending with a "." may not work with some browsers depending on how t