[RFR - backport]: 8203009 - IDN do not throw IAE when hostname ends with a trailing dot

Hi, Can I have a review for 8203009 [1]? This bug is a backport of 8020842 [2]. * http://cr.openjdk.java.net/~mbalao/webrevs/8203009/8203009.webrev.00/ * http://cr.openjdk.java.net/~mbalao/webrevs/8203009/8203009.webrev.00.zip Testing: jdk/test/java/net/IDN/IllegalArg.java test is now passing

[7u-dev] RFA for JDK-8204344: Release session if initialization of SunPKCS11 Signature fails

Hi, Here there is a backport of JDK-8203182 [1] to JDK7: * http://cr.openjdk.java.net/~mbalao/webrevs/8203182/backports/7/8203182.webrev.01/ * http://cr.openjdk.java.net/~mbalao/webrevs/8203182/backports/7/8203182.webrev.01.zip Backport ticket: JDK-8204344 [2]. JDK commit: http://hg.openjdk.ja

Re: [7u-dev] RFA for JDK-8204344: Release session if initialization of SunPKCS11 Signature fails

Thanks for review. I need you to push it on my behalf, as I don't have permissions to do so. On Tue, Jun 5, 2018 at 10:44 PM, Andrew Hughes wrote: > On 5 June 2018 at 17:10, Martin Balao wrote: > > Hi, > > > > Here there is a backport of JDK-8203182 [1] to

[RFR] JDK-8207151: JVM 7u181 crash with SIGSEGV when Tomcat 7 starts

Hi, I'd like to propose a fix for JDK-8207151 [1]: * http://cr.openjdk.java.net/~mbalao/webrevs/8207151/8207151.webrev.01/ * http://cr.openjdk.java.net/~mbalao/webrevs/8207151/8207151.webrev.01.zip This fix has been already reviwed by Andrew Dinn (adinn). Kind regards, Martin.- -- [1] - https

Re: [PATCH] jdk7u201-b00 security patch review

Hi, I'm not an official reviewer but have had a look at the following critical backports and are fine to me: * 8194534 / 8208754 * 8194546 * 8195868 * 8195874 / 8211731 * 8196897 * 8196902 * 8199177 * 8199226 * 8201756 * 8202613 * 8203654 * 8204497 * 8205361 Kind regards, Martin.-

[RFR - 7u]: 8029661: Support TLS v1.2 algorithm in SunPKCS11 provider

Hi, I'd like to propose a backport of SunPKCS11 + TLS 1.2 enhancement to jdk7u: * http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.12.jdk7u/ * http://cr.openjdk.java.net/~mbalao/webrevs/8029661/8029661.webrev.12.jdk7u.zip It's almost identical to jdk8u backport, with a few tri

RFA: 8213154 - Update copyright headers of files in src tree that are missing Classpath exception

Hi, Can I have the backport of 8213154 [0] approved for jdk7u? * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01.jdk7u/ * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01.jdk7u.zip Thanks, Martin.- -- [0] - https://bugs.openjdk.java.net/browse/JDK-8213

Re: [PATCH] jdk7u211-b00 security patch review

On 2/15/19 3:22 AM, Andrew Hughes wrote: > 8u201 was released recently & we've backported appropriate > changes to OpenJDK 7 to create OpenJDK 7 u211. > > The changes from u201-b00 to u211-b00 are as follows: > - S6383200: PBE: need new algorithm support in password based encryption > - S64836

RFA: 8200659

I'd like to request the approval of 8200659 backport to jdk7u. * http://cr.openjdk.java.net/~mbalao/webrevs/8200659/8200659.webrev.jdk7u.00/ * http://cr.openjdk.java.net/~mbalao/webrevs/8200659/8200659.webrev.jdk7u.00.zip Kind regards, Martin.-

RFA 8211435: Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source

Hi, I'd like to request an approval for the backport of "8211435 - Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source" [1] to jdk7u. * http://cr.openjdk.java.net/~mbalao/webrevs/8211435/8211435.webrev.jdk7u.00/ We need this patch in jdk7u because I'm planning

RFA 8204142: AWT hang occurs when sequenced events arrive out of sequence in multiple AppContexts

Hi, I'd like to propose the backport of 8204142 [1] to jdk7u. * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.04.jdk7u/ * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.04.jdk7u.zip This patch is already included in mainline [2] and in jdk11u [3]. It has

Re: [RFR] 8219570: JDK-6383200 wrongly extends PBEParameterSpec API

On 3/12/19 1:07 AM, Andrew John Hughes wrote: > Webrevs: https://cr.openjdk.java.net/~andrew/openjdk7/jdk7u211-b02/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8219570 > > When backporting 6383200, some API changes were introduced into > javax.crypto.spec.PBEParameterSpec. This change works ar

RFR 8129822: Define "headful" jtreg keyword

Hi, I'd like to propose a backport of JDK-8129822 [1] to jdk7u: * http://cr.openjdk.java.net/~mbalao/webrevs/8129822/8129822.webrev.jdk7u.00/ Patch did not apply cleanly but was trivial. Thanks, Martin.- -- [1] - https://bugs.openjdk.java.net/browse/JDK-8129822

Re: RFA 8204142: AWT hang occurs when sequenced events arrive out of sequence in multiple AppContexts

Hi Andrew, Thanks for your feedback. Yes, this should have been a Request for Review instead of Approval. Here it's a new version: * http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.05.jdk7u/ New: * "headful" tags restored * I proposed a backport of JDK-8129822 to jdk7u he

RFA 8151731: Add new jtreg keywords to jdk 8

Hi, Can I have an approval for the backport of 8151731 [0] to jdk7u? * http://cr.openjdk.java.net/~mbalao/webrevs/8151731/8151731.webrev.00.jdk7u Patch applies cleanly. This patch will allow to backport 8129822 [1] and 8204142 [2] cleanly to jdk7u. Thanks, Martin.- -- [0] - https://bugs.open

Re: RFR 8129822: Define "headful" jtreg keyword

Hi Andrew, Thanks for the feedback. You are right, there was an extra "l" in the commit message. I've requested an approval to have 8151731 [1] in jdk7u, so we can apply 8129822 cleanly. Kind regards, Martin.- -- [1] - https://mail.openjdk.java.net/pipermail/jdk7u-dev/2019-March/010907.html

Re: RFA 8151731: Add new jtreg keywords to jdk 8

On 3/28/19 7:31 PM, Andrew John Hughes wrote: > > Approved. > > Thanks, > Pushed: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/c876fdda25b5 Thanks, Martin.-

Re: RFR 8129822: Define "headful" jtreg keyword

Pushed: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/b0731daeea1a Thanks, Martin.-

Re: RFA 8204142: AWT hang occurs when sequenced events arrive out of sequence in multiple AppContexts

Hi Andrew, Thanks for your review. On 4/2/19 3:20 PM, Andrew John Hughes wrote: > > I think this should really be an addition of a Red Hat 2019 line. > Tests were contributed by Oracle and an independent contributor. See "@author" tag. That's why they have an Oracle copyright. >> >> * Missin

Re: RFA 8211435: Exception in thread "AWT-EventQueue-1" java.lang.IllegalArgumentException: null source

It's finally in: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/737a0b21b76c Thanks, Martin.-

Re: [RFR] [7u] jdk7u231-b01

On 7/17/19 12:57 AM, Andrew John Hughes wrote: > > jdk7u231-b01 is tagged as jdk7u231-ga. > > Ok to push? > I've verified all security patches and I'm okay with them. Note: I'm not an official jdk7u reviewer. Regards, Martin.-

[7u] RFR 8226318: Class Loader Dependencies improvements

Hi, I'd like to request a review for the jdk7u backport of 8226318: Class Loader Dependencies improvements [1]. This is a stabilization fix. It has been privately reviewed by Andrew Dinn but I'd appreciate a public review too. Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8226318/822

Re: [7u] RFR 8226318: Class Loader Dependencies improvements

On 9/3/19 3:00 PM, Martin Balao wrote: > > I'd like to request a review for the jdk7u backport of 8226318: Class > Loader Dependencies improvements [1]. > Errata: it's not a backport actually: it does not apply to versions greater than 7.

Re: [7u] RFR 8226318: Class Loader Dependencies improvements

On 9/4/19 3:39 PM, Andrew John Hughes wrote: > > I looked this over when we were discussing it internally and it looks > fine to me. Please push. > Pushed: https://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/e00eb0a88cae Thanks, Martin.-

[RFR 7u] 8017773: OpenJDK7 returns incorrect TrueType font metrics

Hi, I'd like to request an approval for the 7u backport of 8017773 [1]. The reason for this request is that 7u release is affected by this bug in the same way that 8u and 11u were. 8u patch applied cleanly. No 7u-specific changes were required. Changeset: * http://cr.openjdk.java.net/~mbalao/

[RFR 7u] 8221304: Problem list java/awt/FontMetrics/MaxAdvanceIsMax.java

Hi, I'd like to request an approval for the 7u backport of 8221304 [1]. The reason for this request is that 7u release is affected by this bug in the same way that 8u and 11u were. 8u patch applied cleanly. No 7u-specific changes were required. Changeset: * http://cr.openjdk.java.net/~mbalao/

[RFR 7u] 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

Hi, I'd like to request a review for the 7u backport of 8218854 [1]. The reason for this request is that 7u release is affected by this bug in the same way that 8u and 11u were. Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.jdk7u.jdk.webrev.00/ Changeset with header

[RFR 7u] 8214002: Cannot use italic font style if the font has embedded bitmap

Hi, I'd like to request an approval for the 7u backport of 8214002 [1]. The reason for this request is that 7u release is affected by this bug in the same way that 8u and 11u were. 8u patch applied cleanly. No 7u-specific changes were required. Changeset: * http://cr.openjdk.java.net/~mbalao/

[RFR 7u] 8232643: Building error in jdk7u241 after 7068616

Hi, I'd like to request a review for 8232643 [1]. Webrev.00: * http://cr.openjdk.java.net/~mbalao/webrevs/8232643/8232643.jdk7u.jdk.webrev.00/ Change is trivial, so I did not include a new test. Building jdk7u241 would work as a test. Thanks, Martin.- -- [1] - https://bugs.openjdk.java.net/b

Re: [RFR 7u] 8232643: Building error in jdk7u241 after 7068616

On 10/22/19 1:50 PM, Andrew John Hughes wrote: > > Building 7u241 is not sufficient, as I didn't encounter this when > building either locally or in our RHEL builds. So I need more detail on > how to reproduce this. > Yes, I managed to build RHEL java-1.7.0-openjdk RPMS locally. But that's becau

Re: [RFR 7u] 8017773: OpenJDK7 returns incorrect TrueType font metrics

On 10/22/19 1:55 PM, Andrew John Hughes wrote: > > Then can we stick to one at a time then please, to avoid confusion? I'm > not reviewing patches that are against other patches in other e-mails, > rather than what's in HEAD already. Ok. I'll then serialize the RFRs. Let's start with 8214002 whic

Re: [RFR 7u] 8214002: Cannot use italic font style if the font has embedded bitmap

On 10/18/19 5:51 PM, Martin Balao wrote: > > Changeset: > > * > http://cr.openjdk.java.net/~mbalao/webrevs/8214002/8214002.jdk7u.jdk.patch > Webrev: http://cr.openjdk.java.net/~mbalao/webrevs/8214002/8214002.jdk7u.jdk.webrev.00/ Note: 8u patch applied cleanly in 7u.

Re: [RFR 7u] 8017773: OpenJDK7 returns incorrect TrueType font metrics

Hi Andrew, Now that we have 8214002 in 7u [1], do you approve the inclusion of 8017773 in 7u? (8u patch for 8017773 [2] applies cleanly in 7u). I can push if you approve. Thanks, Martin.- -- [1] - http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/7a57b24311fe [2] - http://hg.openjdk.java.net/jdk8u/

Re: [RFR 7u] 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

Hi Andrew, Now that we have 8017773 [1] in 7u, can I have a review for the 8218854 [2] 7u backport? As previously said [3], these are the reasons why 8u patch did not apply cleanly: * Copyright date in freetypeScaler.c * MaxAdvanceIsMax jtreg header to run on jdk7u (removed jdk.version.major)

Re: [RFR 7u] 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

On 2/3/20 10:19 PM, Andrew John Hughes wrote: > > Any idea why "@requires jdk.version.major >= 8" was added in the first > place? It seems odd, given the tests are housed with a particular JDK > version (and thus require backports such as this for use in other versions). > Yes, that's right. I w

Re: [RFR] [7u] jdk7u261-b02/ga

On 4/15/20 11:48 AM, Andrew John Hughes wrote: > OpenJDK 7u261 has been released: http://bitly.com/oj7u261 > > Here are the remaining changes for the jdk7u repository: > > Webrev: https://cr.openjdk.java.net/~andrew/openjdk7/20200414/ > > Changes: > - S7065233: To interpret case-insensitive st

Re: [RFR] [7u] jdk7u271-b01

On Thu, Jul 23, 2020 at 1:10 PM Andrew Hughes wrote: > > If this looks ok, I'll tag as jdk7u271-b01. > > Assuming our testing then goes ok, we'll add the tag jdk7u271-ga and > make the release. > Looks good to me. Once the testing is ok, proceed with the push. Good job Andrew, thanks.