Open part of this review:
The docs team will start producing separate man pages for openjdk and
oraclejdk. Here are the necessary changes to the makefiles to support this.
http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.01/
/Erik
I should add that this is for jdk7u, what used to be 14.
On 2013-02-04 12:42, Erik Joelsson wrote:
Open part of this review:
The docs team will start producing separate man pages for openjdk and
oraclejdk. Here are the necessary changes to the makefiles to support
this.
http
David Holmes wrote:
Hi Erik,
Can you use $(CLOSED_PLATFORM_SOURCE) instead of hardwiring
src/closed/? In theory it should be possible to relocate the
"closed" repo and still have things work (by changing one definition).
David
On 4/02/2013 9:42 PM, Erik Joelsson wrote:
Open part of th
Please review open part of these changes.
http://cr.openjdk.java.net/~erikj/8014969/webrev.jdk.01/
/Erik
Please review open part of these changes in jdk7u-dev. Moving logic for
choosing open or oracle man pages to closed makefile.
http://cr.openjdk.java.net/~erikj/8014969/webrev.jdk.01/
/Erik
Oops, wrong bug number. 8014969 is the jdk7 version of this issue.
/Erik
On 2013-05-23 11:47, Erik Joelsson wrote:
Please review open part of these changes in jdk7u-dev. Moving logic
for choosing open or oracle man pages to closed makefile.
http://cr.openjdk.java.net/~erikj/8014969
Hi David,
The other *setup targets just do $(RM) -r (since RM is already defined
as rm -f). Would look better to follow the same pattern. Otherwise,
thanks for fixing it.
/Erik
On 2013-08-09 22:14, David DeHaven wrote:
This issue has been annoying me for some time, I finally got frustrated
Looks good to me, though I'm neither reviewer nor committer in jdk7u.
/Erik
On 2013-08-12 17:38, David DeHaven wrote:
Updated:
http://cr.openjdk.java.net/~ddehaven/8022734/jdk.1/
JPRT run was successful, aside from a spurious solaris_sparc_5.10.product "resource
unavailable" error. I re-ran t
Hello,
Open part of this revew.
Please review this minor patch to 7u, moving the test for if the JDK
part of JFR should be built to a single location in a closed makefile.
Bug: https://bugs.openjdk.java.net/browse/JDK-8029304
Webrev: http://cr.openjdk.java.net/~erikj/8029304/webrev.jdk.01/
/
Hello,
This is a 7u60 request for aproval for the issue:
https://bugs.openjdk.java.net/browse/JDK-8029304
Webrev here:
http://cr.openjdk.java.net/~erikj/8029304/webrev.jdk.01/
reviewed by: collins, dholmes
This change stops jfr.jar from being built on arm, where jfr is
currently not supported
Hello Ivan,
The change looks good to me, but I'm not a reviewer for 7u.
/Erik
On 2014-04-28 14:45, Ivan Gerasimov wrote:
Ping.
Could someone please help review this quite simple fix?
I've tested the change with JPTR in three configuration: open jdk,
full jdk and licensee source.
The binari
Hello,
Please review this fix for jdk7u. The localized versions of
com/apple/laf/resources/aqua.properties are not included in the built
product while available in the source. The reason for this is that no
LOCALE_SET_DEFINITION is set in make/com/apple/osxui/Makefile, which
causes make/commo
Hello Jiri,
I think jdk7u-dev is the appropriate list for this issue.
/Erik
On 2015-02-09 10:53, Jiri Vanek wrote:
ping?
On 01/26/2015 03:08 PM, Jiri Vanek wrote:
hi!
jhat.1 have wrong url in "see also" section in openjdk7 [1]
Jdk 8 and 9 have this url correct.
Attached patch is fixing i
Hello jdk7u maintainers,
I would like to raise the subject of potentially moving jdk7u
development over to Github/Skara at some point in the future. Currently
the only 2 projects still on hg.openjdk.java.net are jdk7u and jdk8u,
and we are currently in the process of figuring out the migration
Resending this as there have been no replies yet.
On 2021-10-12 14:51, erik.joels...@oracle.com wrote:
Hello jdk7u maintainers,
I would like to raise the subject of potentially moving jdk7u
development over to Github/Skara at some point in the future.
Currently the only 2 projects still on hg
Hello Andrew,
Thanks for your reply. Yes, we can certainly perform the consolidation
next week. I'm proposing we start on Monday. I've filed this issue to
track the work:
https://bugs.openjdk.java.net/browse/SKARA-1268
/Erik
On 2021-12-03 05:50, Andrew Brygin wrote:
Hello Erik,
I apologi
Looks good to me.
Did you try 'git webrev' locally with this change as current HEAD?
/Erik
On 2022-04-21 03:46, Andrew Brygin wrote:
We have to update the .jcheck/conf for jdk7u in the same manner as it was done
for jdk8u-dev:
https://github.com/openjdk/jdk8u-dev/commit/4a19c1a65107202800bf8
On Thu, 21 Apr 2022 12:57:26 GMT, Andrew Brygin wrote:
> @erikj79 I have just tried git webrev locally and it works excellent to my
> taste: it creates a perfect webrev in a local folder.
Oh, I meant `git jcheck`, to verify that the config parses correctly. Too early
for me it seems. :)
-
On Thu, 21 Apr 2022 13:18:25 GMT, Andrew Brygin wrote:
> `git jcheck` produces expected errors:
>
> ```
> [branches] error: illegal branch name: 8285357-jcheck-update
> [reviewers] error: ee5137a7: 1 reviewer required, found 0
> ```
>
> Both errors will be eliminated as a result of PR, if I und
On Thu, 21 Apr 2022 10:37:50 GMT, Andrew Brygin wrote:
> We have to update the .jcheck/conf for jdk7u in the same manner as it was
> done for jdk8u-dev:
> https://github.com/openjdk/jdk8u-dev/commit/4a19c1a65107202800bf8df51684f7255d6ef027
>
> The current version for 7u is openjdk7u341.
Marke
On Thu, 2 Jun 2022 10:31:09 GMT, Yuri Nesterenko wrote:
> It is a missed part of 8087283 cleanup fix. It has in head the same bug id
> and synopsis: I hope Skara jcheck would process it.
In general, OpenJDK projects require a new bug for this kind of thing, but the
jdk7u project is of course
21 matches
Mail list logo
