hg: jdk7u/jdk7u-dev/langtools: 7112427: The doclet needs to be able to generate JavaFX documentation.

Changeset: b020b7a017cc Author:jjg Date: 2012-05-15 17:47 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/b020b7a017cc 7112427: The doclet needs to be able to generate JavaFX documentation. Reviewed-by: jjg Contributed-by: jan.vale...@oracle.com ! src/share/clas

Re: hg: jdk7u/jdk7u-dev/langtools: 7112427: The doclet needs to be able to generate JavaFX documentation.

Thank you for raising this issue. I will check it out. This was reviewed internally for 7u, and has not yet been approved or ported forward to 8. -- Jon On 09/03/2012 05:53 AM, Andrew Hughes wrote: - Original Message - Changeset: b020b7a017cc Author:jjg Date: 2012-05-15 17:

Re: request for review: 8033294: javac, spurious warning for instanceof operator

Looks OK to me. -- Jon On 02/06/2014 09:49 AM, Vicente-Arturo Romero-Zaldivar wrote: Thanks, Vicente On 06/02/14 17:34, Jan Lahoda wrote: Seems OK for 7 to me (I am not a capital-R reviewer, though). An alternative might be to skip all unchecked warnings while checking castability for the

hg: jdk7u/jdk7u-dev/langtools: 8033294: javac, spurious warning for instanceof operator

Changeset: 420dc86b1716 Author:vromero Date: 2014-02-11 21:01 + URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/420dc86b1716 8033294: javac, spurious warning for instanceof operator Reviewed-by: jjg, jlahoda ! src/share/classes/com/sun/tools/javac/code/Type.java !

Re: [7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases

Looks OK to me. -- Jon On 11/24/2014 11:16 AM, Vicente-Arturo Romero-Zaldivar wrote: Please review the proposed fix for the bug in the subject. Details below: JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ This p

Request for approval for CR 7086261: javac doesn't report error as expected, it only reports ClientCodeWrapper$DiagnosticSourceUnwrapper

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7086261 JDK 8 changeset to backport: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec27e5befa53 See also associated request for 7074416

Request for approval for CR 7074416 - Regression: JSR199: javac doesn't unwrap clientcodewrapper objects

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7074416 JDK 8 changeset to backport: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f85d980faaf8 See also associated request for 7086261

hg: jdk7u/jdk7u-dev/langtools: 3 new changesets

Changeset: 20f538c8b111 Author:jjg Date: 2011-08-31 15:39 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/20f538c8b111 7074416: Regression: JSR199: javac doesn't unwrap clientcodewrapper objects Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/ap

Request for approval for CR 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7073508 JDK 8 changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ee9f9a91e9c

hg: jdk7u/jdk7u-dev/langtools: 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment

Changeset: 313874c05e8e Author:jjg Date: 2011-09-09 17:19 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/313874c05e8e 7073508: Regression: NullPointerException at com.sun.tools.javac.code.Lint$AugmentVisitor.augment Reviewed-by: darcy ! src/share/classes/com/s

Request for approval for CR 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7068437 JDK 8 Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/826ae6a2f27d -- Jon

hg: jdk7u/jdk7u-dev/langtools: 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s

Changeset: 1a08aea750b2 Author:jjg Date: 2011-09-14 18:26 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/1a08aea750b2 7068437: Regression: Filer.getResource(SOURCE_OUTPUT, ...) no longer works in JDK 7 w/o -s Reviewed-by: darcy ! src/share/classes/com/sun/tool

Re: Suggestion: require release name in the approval request Subject line

On 11/10/2011 12:13 PM, Edvard Wendelin wrote: >> A much bigger problem to me at the moment is the amount of commit traffic I get. Can we not have these >> on a separate list? I need to be signed up to the lists to get the actual patch reviews/discussion, but >> a commit to tl gives me abo

Re: [jdk7u-dev] Please review the fix for 7126832

Looks good to me. -- Jon On 01/25/2012 10:29 AM, Jim Holmlund wrote: Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126832 Here is the webrev http://cr.openjdk.java.net/~jjh/7126832/ The fix is the same as the fix in jdk8 with one exception: - in JDK 8, the compile(...)

Re: [jdk7u-dev] Please review the fix for 7129225

Looks good to me. -- Jon On 01/25/2012 12:36 PM, Jim Holmlund wrote: Here is the bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7129225 Here is the webrev http://cr.openjdk.java.net/~jjh/7129225.7u The jdk8 fix for 7129225 failed when run with jtreg -samevm. The fix for 7133314 fix

Re: [jdk7u-dev] Please review the fix for 7126832

Dalibor, No, this is an internal method in javac we are talking about. No CCC is required. -- Jon On 01/25/2012 05:03 PM, Dalibor Topic wrote: Would this be adding a new public API to JDK 7, i.e. need to go through CCC? cheers, dalibor topic On 1/25/12 10:29 AM, Jim Holmlund wrote: Here