Re: [7u] Request for approve for CR 8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have conflicting test descriptions

2013-06-06 Thread Yuri Nesterenko
I didn't look into sources of jtreg stuff! Basically, I understand that our test is either one or several files, and only one of them should have @test tag inside. Simplest example, .java and .html pair for running in appletviewer: @test should be in .html only. Now, I always thought that a line

CFV: New OpenJDK 7u Reviewer: Martin Balao

2020-05-22 Thread Yuri Nesterenko
Vote: yes --yan

Re: [7u] RFR: 8250861: Crash in MinINode::Ideal(PhaseGVN*, bool)

2020-11-10 Thread Yuri Nesterenko
Looks good to me Thanks, --yan On 09.11.2020 11:02, Andrew Brygin wrote: > Hello, > > I would like to backport the fix for 8250861 to jdk7u: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8250861 > Webrev: http://cr.openjdk.java.net/~bae/7u/8250861/webrev.v00/ > > 8u patch applied cleanly

Re: [7u] RFR: 8259048: (tz) Upgrade time-zone data to tzdata2020f

2021-03-09 Thread Yuri Nesterenko
Looks good to me! Thank you, --yan On 09.03.2021 18:00, Dmitry Cherepanov wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8259048 > 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/42f6981cebc5 > 7u webrev: > http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8259048/webrev.v0/ >

Re: [7u] RFR 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR

2021-03-11 Thread Yuri Nesterenko
Fine, looks good to me. --yan On 11.03.2021 13:55, Sergey Chernyshev wrote: > Hi Alexey, > > Thank you for the review. > > > On 11.03.2021 12:49, Alexey Bakhtin wrote: >> Hello Sergey, >> >> Thank you for the backport. >> I’m not reviewer but I verified your patch and it looks good to me. >> >

Re: [jdk7u] RFR: 8285357: Update .jcheck/conf file for 7u move to git

2022-04-21 Thread Yuri Nesterenko
On Thu, 21 Apr 2022 10:37:50 GMT, Andrew Brygin wrote: > We have to update the .jcheck/conf for jdk7u in the same manner as it was > done for jdk8u-dev: > https://github.com/openjdk/jdk8u-dev/commit/4a19c1a65107202800bf8df51684f7255d6ef027 > > The current version for 7u is openjdk7u341. ok wi

Re: [jdk7u] RFR: 8285579: Bump update version of OpenJDK: 7u351

2022-04-27 Thread Yuri Nesterenko
On Tue, 26 Apr 2022 17:36:08 GMT, Andrew Brygin wrote: > Bump the version in .jcheck/conf to openjdk7u351. Marked as reviewed by yan (Reviewer). - PR: https://git.openjdk.java.net/jdk7u/pull/2

[jdk7u] RFR: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head

2022-05-16 Thread Yuri Nesterenko
This fix is different from versions 8+: first, in Lexer.java there's no LastModified and a usual copyright, so it is dropped from the change. Second, a new XPathExceptionTest is hard to compile in 7: to run with jdk7 we'd need an older than usual version of testng which, in turn, doesn't work wi

[jdk7u] Integrated: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head

2022-05-16 Thread Yuri Nesterenko
On Mon, 16 May 2022 09:53:10 GMT, Yuri Nesterenko wrote: > This fix is different from versions 8+: first, in Lexer.java there's no > LastModified and a usual copyright, so it is dropped from the change. Second, > a new XPathExceptionTest is hard to compile in 7: to run with

git: openjdk/jdk7u: 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head

2022-05-16 Thread Yuri Nesterenko
Changeset: c83eb83f Author:Yuri Nesterenko Date: 2022-05-16 12:20:06 + URL: https://git.openjdk.java.net/jdk7u/commit/c83eb83fcc33ba9ab6e6e783fe0e9acdbe0085c5 8285726: [11u, 17u] Unify fix for JDK-8284548 with version from head Reviewed-by: bae ! jdk/test/javax/xml/jaxp

[jdk7u] RFR: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head

2022-05-16 Thread Yuri Nesterenko
I'd like to backport this leveling fix to 7u, too. All differences between patches for adapted for git 7u and e.g. 15u are in paths. First round of tests run OK. - Commit messages: - 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head Changes: https://git.openjdk.

git: openjdk/jdk7u: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head

2022-05-16 Thread Yuri Nesterenko
Changeset: 7ecb5b2e Author:Yuri Nesterenko Date: 2022-05-16 14:39:06 + URL: https://git.openjdk.java.net/jdk7u/commit/7ecb5b2eebfdc06a4a261ee2b5ada3adad81e88d 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head Reviewed-by: bae ! jaxp/src/com/sun/org/apache

[jdk7u] Integrated: 8285727: [11u, 17u] Unify fix for JDK-8284920 with version from head

2022-05-16 Thread Yuri Nesterenko
On Mon, 16 May 2022 14:08:27 GMT, Yuri Nesterenko wrote: > I'd like to backport this leveling fix to 7u, too. All differences between > patches for adapted for git 7u and e.g. 15u are in paths. First round of > tests run OK (with testng 6.9). This pull request has now b

[jdk7u] RFR: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

2022-05-31 Thread Yuri Nesterenko
I need to backport this change to 7u to facilitate other updates. Tests run fine (with testng 6) - Commit messages: - Backport 22fad64529a890dd3ae8b07c7981d9a720cf8e96 Changes: https://git.openjdk.java.net/jdk7u/pull/6/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk7u&pr=

git: openjdk/jdk7u: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

2022-05-31 Thread Yuri Nesterenko
Changeset: bc575d02 Author:Yuri Nesterenko Date: 2022-05-31 13:06:13 + URL: https://git.openjdk.java.net/jdk7u/commit/bc575d02f468ec0e870997cb1b534f94bdb46767 8087283: Add support for the XML Signature here() function to the JDK XPath implementation Reviewed-by: bae

[jdk7u] Integrated: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

2022-05-31 Thread Yuri Nesterenko
On Tue, 31 May 2022 11:12:15 GMT, Yuri Nesterenko wrote: > I need to backport this change to 7u to facilitate other updates. Tests run > fine (with testng 6) This pull request has now been integrated. Changeset: bc575d02 Author: Yuri Nesterenko URL: https://git.openjdk.ja

[jdk7u] RFR: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

2022-06-02 Thread Yuri Nesterenko
It is a missed part of 8087283 cleanup fix. It has in head the same bug id and synopsis: I hope Skara jcheck would process it. - Commit messages: - Remove a trailinig whitespace - Backport b05b9cbefad137c5e2802942de6e77d3994f4315 Changes: https://git.openjdk.java.net/jdk7u/pull/7

Re: [jdk7u] RFR: 8087283: Add support for the XML Signature here() function to the JDK XPath implementation

2022-06-02 Thread Yuri Nesterenko
On Thu, 2 Jun 2022 10:31:09 GMT, Yuri Nesterenko wrote: > It is a missed part of 8087283 cleanup fix. It has in head the same bug id > and synopsis: I hope Skara jcheck would process it. Two bugs with the same bugid but different content and hashes are apparently a result of the