RE: FilterOutputStream.close() throws exception from flush()

2012-02-10 Thread Ludwig, Mark
That might allow the close() to complete, but the underlying IOException should not just be silently ignored. Since BufferedWriter.close() is allowed to throw IOException, it should do so, after cleaning up the underlying Writer. I'm not familiar with this code, but in most cases, judicious us

Re: Warning Fixes from LJC Hack Session

2012-02-10 Thread Chris Hegarty
On 02/10/12 03:58 AM, Michael Barker wrote: Hi Stuart, Thank you for the reviewing the patches. I forgot about the Contributed-by header, sorry about that. That's one I'll put on the list to make sure I have sorted next time. I've split the contributors up according to the two patches supplie

Re: FilterOutputStream.close() throws exception from flush()

2012-02-10 Thread Alan Bateman
On 10/02/2012 13:16, Alex Lam S.L. wrote: I think I have narrowed it down to this changeset: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/759aa847dcaf 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails Which no longer catches and ignores the except

Re: FilterOutputStream.close() throws exception from flush()

2012-02-10 Thread Alex Lam S.L.
I think I have narrowed it down to this changeset: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/759aa847dcaf 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails Which no longer catches and ignores the exception thrown by flush(): try (OutputStream os