Re: RFR: 7113349 JDK8 port to macosx

2012-02-23 Thread Anthony Petrov
One more thing: src/solaris/classes/sun/awt/X11/XWM.java contains a patch from bsd-port [1] which is unrelated to Mac OS or 7u4-specific changes. I think that this change might have been added when porting from macosx-port repo to the 7u-dev one. On the one hand, the change itself is somewhat h

Re: RFR: 7113349 JDK8 port to macosx

2012-02-23 Thread Michael McMahon
Anthony, Yes, sorry about that, when checking the webrev before sending it, I concentrated on the modified files, rather than the new ones. So, any new files in the webrev that are not clearly macos related need to be treated with some suspicion. I'll probably be generating a new webrev soon w

Re: RFR: 7113349 JDK8 port to macosx

2012-02-23 Thread Anthony Petrov
Hi Michael, I've noticed your webrev adds files belonging to the legacy MToolkit (e.g. src/solaris/native/sun/awt/awt_*). These files have been removed explicitly from JDK 8 with a fix for 6996291. I think we should examine the list of hg add'ed files carefully to see if they were really add

Re: RFR: 7113349 JDK8 port to macosx

2012-02-23 Thread David Holmes
Michael, I only glanced at this so far. In make/common/Release-embedded.gmk you've dragged in the fix for 7087956 which we haven't pushed into JDK8 and don't plan to. It's probably harmless to put it in but the CR will need updating in that case. Or just drop it. David On 23/02/2012 7:50 A

Re: RFR: 7113349 JDK8 port to macosx

2012-02-23 Thread Alan Bateman
On 22/02/2012 21:50, Michael McMahon wrote: This is the webrev for the Mac OS changes for JDK8. It is pretty much a straight merge of the current jdk7u-dev changes. It builds and passes most JCK and regression tests with only a small number of failures. http://cr.openjdk.java.net/~michaelm/711