Hi Michael,
I looked at the launcher and pack200 files:
General comment, the copyrights are out of sync.
can we make MACOSX consistent ? we have _ALLBSD_SOURCE and MACOSX,
in the following files:
src/share/native/com/sun/java/util/jar/pack/main.cpp
src/share/native/com/sun/java/util/jar/pack/de
Hi David,
One other general nit (because it made it much harder to see real
changes!): there is no need to add comments to every "else" and
"endif" in the build files. When they are long sections sure, but not
for one or two lines. That makes it harder to read things in my
opinion. (Ref: jd
Hi Michael,
Partial review of jdk changes. Sorry but it is too large to go through
everything in detail.
General meta comment: When this stuff went into 7u my biggest complaint
was that it introduced a mass of new platform-specific stuff in places
that weren't otherwise platform specific. Th
I'm not sure that all printf utilities document the -- argument as valid, most
man pages don't document any options.
I'm pretty sure all of them accept it, but without it being documented it
concerns me that we
would be using an undocumented interface that could go away in the future.
But not a
In top Defs-internal.gmk
The change from
$(PRINTF) "-- Build times
to
$(PRINTF) "#-- Build times
should instead be to
$(PRINTF) -- "-- Build times
Otherwise thumbs up!
- michael.x.mcma...@oracle.com skrev:
> This is an updated webrev for the Mac OS X changes after comments so
> far:
>
> h
Thumbs up on the langtools changes.
- jjh
On 2/27/2012 1:07 PM, Michael McMahon wrote:
This is an updated webrev for the Mac OS X changes after comments so far:
http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.3/
The main changes from the original webrev are:
- jprt configuration for
This is an updated webrev for the Mac OS X changes after comments so far:
http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.3/
The main changes from the original webrev are:
- jprt configuration for macosx
- problem list updates
- removal of dud source files brought in from 7u-dev by mis
Vote: yes
I hereby nominate Oleg Pekhovskiy (OpenJDK user name: bagiras) to JDK8
Committer.
Oleg is currently a JDK8 Author and a member of AWT group. He has
contributed a number of fixes, mostly in AWT area, including several
really tough ones like 7108598 and :
http://hg.openjdk.java.ne
Vote: YES.
--
best regards,
Anthony
On 2/25/2012 12:32 AM, Artem Ananiev wrote:
I hereby nominate Oleg Pekhovskiy (OpenJDK user name: bagiras) to JDK8
Committer.
Oleg is currently a JDK8 Author and a member of AWT group. He has
contributed a number of fixes, mostly in AWT area, including s
