hg: jdk8/jdk8/nashorn: Added tag jdk8-b89 for changeset 45ce27fbe272

2013-05-09 Thread david . katleman
Changeset: 67ca019e3713 Author:katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/67ca019e3713 Added tag jdk8-b89 for changeset 45ce27fbe272 ! .hgtags

hg: jdk8/jdk8/langtools: Added tag jdk8-b89 for changeset ec434cfd2752

2013-05-09 Thread david . katleman
Changeset: e19283cd30a4 Author:katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e19283cd30a4 Added tag jdk8-b89 for changeset ec434cfd2752 ! .hgtags

hg: jdk8/jdk8/jdk: Added tag jdk8-b89 for changeset 845025546e35

2013-05-09 Thread david . katleman
Changeset: b8e7d145abc2 Author:katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b8e7d145abc2 Added tag jdk8-b89 for changeset 845025546e35 ! .hgtags

hg: jdk8/jdk8/jaxp: Added tag jdk8-b89 for changeset 893d2ba8bbea

2013-05-09 Thread david . katleman
Changeset: 668acc0e1034 Author:katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/668acc0e1034 Added tag jdk8-b89 for changeset 893d2ba8bbea ! .hgtags

hg: jdk8/jdk8/jaxws: Added tag jdk8-b89 for changeset 88838e08e4ef

2013-05-09 Thread david . katleman
Changeset: 3e5b9ea5ac35 Author:katleman Date: 2013-05-09 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/3e5b9ea5ac35 Added tag jdk8-b89 for changeset 88838e08e4ef ! .hgtags

hg: jdk8/jdk8: Added tag jdk8-b89 for changeset 892a0196d10c

2013-05-09 Thread david . katleman
Changeset: 69b773a221b9 Author:katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/69b773a221b9 Added tag jdk8-b89 for changeset 892a0196d10c ! .hgtags

hg: jdk8/jdk8/hotspot: Added tag jdk8-b89 for changeset 9c1fe0b419b4

2013-05-09 Thread david . katleman
Changeset: 7d56b68a9672 Author:katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7d56b68a9672 Added tag jdk8-b89 for changeset 9c1fe0b419b4 ! .hgtags

hg: jdk8/jdk8/corba: Added tag jdk8-b89 for changeset fe4150590ee5

2013-05-09 Thread david . katleman
Changeset: c8286839d0df Author:katleman Date: 2013-05-09 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/c8286839d0df Added tag jdk8-b89 for changeset fe4150590ee5 ! .hgtags

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread Dmitry Samersoff
Looks good for me. -Dmitry On 2013-05-09 23:45, David Katleman wrote: > > On 5/9/2013 12:09 PM, Dmitry Samersoff wrote: >> David, >> >> test/java/lang/CharSequence/DefaultTest.java >> >> has a "Classpath exception" but shouldn't. > > Good catch. > > Scripts just check for correct format of the

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread David Katleman
On 5/9/2013 12:09 PM, Dmitry Samersoff wrote: David, test/java/lang/CharSequence/DefaultTest.java has a "Classpath exception" but shouldn't. Good catch. Scripts just check for correct format of the header, but not whether the file should have GPL or GPL+classpath. I've updated the webrev

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread Tim Bell
Hi Dave: Below are corrections to GPL headers found in JDK8 b89: http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/ Just 4 files this go around, all are simple punctuation changes, anyone can review. Looks good. Tim

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread Dmitry Samersoff
David, test/java/lang/CharSequence/DefaultTest.java has a "Classpath exception" but shouldn't. -Dmitry On 2013-05-09 22:38, David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b89: > > http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/ > > Just 4 files thi

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread David Katleman
On 5/9/2013 12:02 PM, Mike Duigou wrote: All look good. Sorry to be the contributor of three of these. Thank you to Mandy & Mike for reviewing! That will do it! Dave On May 9 2013, at 11:38 , David Katleman wrote: Below are corrections to GPL headers found in JDK8 b89: ht

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread Mike Duigou
All look good. Sorry to be the contributor of three of these. Mike On May 9 2013, at 11:38 , David Katleman wrote: > Below are corrections to GPL headers found in JDK8 b89: > >http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/ > > Just 4 files this go around, all are simple punct

Re: Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread Mandy Chung
Thumbs up. Mandy On 5/9/13 11:38 AM, David Katleman wrote: Below are corrections to GPL headers found in JDK8 b89: http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/ Just 4 files this go around, all are simple punctuation changes, anyone can review. As a veteran of many such h

Review request: JDK8 b89 source with GPL header errors

2013-05-09 Thread David Katleman
Below are corrections to GPL headers found in JDK8 b89: http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/ Just 4 files this go around, all are simple punctuation changes, anyone can review. As a veteran of many such header reviews, reviewing the patch link at the top of the web