Re: RFR: 8026491: Typos in string literals

2013-10-30 Thread Stuart Marks
Perhaps Sergey can check. I would have checked myself, but Sergey pushed his earlier fix to the AWT forest, and I don't think it's appeared in TL yet. I could have pulled over the AWT forest, but I have enough distractions as it stands. Hm, maybe we need a new Friday Stats metric: the numbre

Re: RFR: 8026491: Typos in string literals

2013-10-30 Thread Jonathan Gibbons
find/grep before and after? -- Jon On 10/30/2013 01:17 PM, Stuart Marks wrote: The changes look good. It looks like "occured" is the most common spelling error. I wonder how many instances of this misspelling will remain in the codebase after your fixes. s'marks On 10/30/13 4:43 AM, serge

Re: RFR: 8026491: Typos in string literals

2013-10-30 Thread Stuart Marks
The changes look good. It looks like "occured" is the most common spelling error. I wonder how many instances of this misspelling will remain in the codebase after your fixes. s'marks On 10/30/13 4:43 AM, sergey malenkov wrote: Hello, Could you please review the following fix: fix:http://cr

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Staffan Larsen
Vote: yes /Staffan On 30 okt 2013, at 16:44, Alan Bateman wrote: > > I hereby nominate Daniel Fuchs to jdk8 Reviewer. > > Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev > will remember Daniel from the early years of OpenJDK when he was contributing > changes to

hg: jdk8/jdk8: 5 new changesets

2013-10-30 Thread david . katleman
Changeset: b098ee22aa97 Author:erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/b098ee22aa97 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! common/makefiles/JavaCompilation.gmk Changeset: 3c48e11c3

hg: jdk8/jdk8/jdk: 6 new changesets

2013-10-30 Thread david . katleman
Changeset: 110c4fe4c354 Author:erikj Date: 2013-10-24 10:43 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/110c4fe4c354 8009280: JCE jurisdiction policy files not copied into jdk/lib/security Reviewed-by: tbell, ihse ! makefiles/BuildJdk.gmk ! makefiles/CompileJavaClasses.

hg: jdk8/jdk8/hotspot: 3 new changesets

2013-10-30 Thread david . katleman
Changeset: e006d2e25bc7 Author:dholmes Date: 2013-10-24 20:47 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e006d2e25bc7 8025673: [macosx] Disable X11 AWT toolkit Summary: Disable but not completely remove the XAWT and headless toolkits on Mac OS X Reviewed-by: dholme

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Mike Duigou
Vote: YES On Oct 30 2013, at 08:44 , Alan Bateman wrote: > > I hereby nominate Daniel Fuchs to jdk8 Reviewer. > > Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev > will remember Daniel from the early years of OpenJDK when he was contributing > changes to JMX. He l

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Xueming Shen
Vote: yes On 10/30/2013 08:44 AM, Alan Bateman wrote: I hereby nominate Daniel Fuchs to jdk8 Reviewer. Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev will remember Daniel from the early years of OpenJDK when he was contributing changes to JMX. He left for a while

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Artem Ananiev
Vote: yes Artem On 10/30/2013 7:44 PM, Alan Bateman wrote: I hereby nominate Daniel Fuchs to jdk8 Reviewer. Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev will remember Daniel from the early years of OpenJDK when he was contributing changes to JMX. He left for a

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread David Katleman (Oracle)
Vote: yes On 10/30/2013 8:44 AM, Alan Bateman wrote: I hereby nominate Daniel Fuchs to jdk8 Reviewer. Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev will remember Daniel from the early years of OpenJDK when he was contributing changes to JMX. He left for a while

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread naoto sato
vote: yes Naoto On 10/30/13 8:44 AM, Alan Bateman wrote: I hereby nominate Daniel Fuchs to jdk8 Reviewer. Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev will remember Daniel from the early years of OpenJDK when he was contributing changes to JMX. He left for a w

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Mandy Chung
Vote: yes

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Chris Hegarty
Vote: YES. -Chris On 30/10/2013 15:44, Alan Bateman wrote: I hereby nominate Daniel Fuchs to jdk8 Reviewer.

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Tim Bell
Vote: yes Tim On 10/30/13 08:44 AM, Alan Bateman wrote: I hereby nominate Daniel Fuchs to jdk8 Reviewer.

Re: CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Lance Andersen - Oracle
vote: yes On Oct 30, 2013, at 11:44 AM, Alan Bateman wrote: > > I hereby nominate Daniel Fuchs to jdk8 Reviewer. > > Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev > will remember Daniel from the early years of OpenJDK when he was contributing > changes to JMX. He

CFV: New jdk8 Reviewer: Daniel Fuchs

2013-10-30 Thread Alan Bateman
I hereby nominate Daniel Fuchs to jdk8 Reviewer. Daniel is on his second tour of duty in Oracle's JDK team. Those on jmx-dev will remember Daniel from the early years of OpenJDK when he was contributing changes to JMX. He left for a while to work at another team in Sun before returning to Ora

Re: RFR: 8026491: Typos in string literals

2013-10-30 Thread Alexander Scherbatiy
The fix looks good for me. Thanks, Alexandr. On 10/30/2013 3:48 PM, sergey malenkov wrote: Unfortunately the webrev's wdiff is failed, so I've prepared the following page for your convenience: http://cr.openjdk.java.net/~malenkov/8026491.8.0/diff.html

Re: RFR: 8026491: Typos in string literals

2013-10-30 Thread Anthony Petrov
Looks fine to me. -- best regards, Anthony On 10/30/2013 03:48 PM, sergey malenkov wrote: Unfortunately the webrev's wdiff is failed, so I've prepared the following page for your convenience: http://cr.openjdk.java.net/~malenkov/8026491.8.0/diff.html

Re: RFR: 8026491: Typos in string literals

2013-10-30 Thread sergey malenkov
Unfortunately the webrev's wdiff is failed, so I've prepared the following page for your convenience: http://cr.openjdk.java.net/~malenkov/8026491.8.0/diff.html Thanks, SAM On 30.10.2013 15:43, sergey malenkov wrote: Could you ple

RFR: 8026491: Typos in string literals

2013-10-30 Thread sergey malenkov
Hello, Could you please review the following fix: fix:http://cr.openjdk.java.net/~malenkov/8026491.8.0/ bug:https://bugs.openjdk.java.net/browse/JDK-8026491 I've replaced all typos with correct words in all string literals. This is a second part of the previous fix (8022746: List of spelling er