Re: CFV: New JDK8 Reviewer: Petr Pchelko

Vote: YES -- best regards, Anthony On 11/19/2013 05:11 PM, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to JDK8 Reviewer. Petr is one of the most active contributors to AWT and Swing. He is currently a JDK8 Committer, voting for JDK7u Committer is in progre

Re: webrev.ksh on Ubuntu 12.04

No, wait. It looks like the webrev for jdk8/jdk8 has been successfully generated, no? Please try opening "/home/dpointo8/work/repos/Mercurial/upstream/webrev" with a web-browser. -- best regards, Anthony On 11/15/2013 09:19 PM, Dave Pointon wrote: On Fri, 2013-11-15 at 20:55 +040

Re: webrev.ksh on Ubuntu 12.04

What is the output of `hg st` for the second repo (jdk8/jdk8)? -- best regards, Anthony On 11/15/2013 09:19 PM, Dave Pointon wrote: On Fri, 2013-11-15 at 20:55 +0400, Anthony Petrov wrote: Hi Dave, Please post the exact and complete output of the script on the console. Also, please post the

Re: webrev.ksh on Ubuntu 12.04

Hi Dave, Please post the exact and complete output of the script on the console. Also, please post the content of your .hg/hgrc file in the repo you're trying to generate a webrev for. If you clone a new fresh repo from any of the OpenJDK forests, does it also fail to generate a webrev for u

Re: webrev.ksh on Ubuntu 12.04

Did you try "our" (unmodified) webrev.ksh script from make/scripts/ of the top-level repo? Does it still fail for uncommitted changes? -- best regards, Anthony On 11/15/2013 12:50 AM, Dave Pointon wrote: Hi Anthony , On Thu, 2013-11-14 at 22:55 +0400, Anthony Petrov wrote: I never

Re: webrev.ksh on Ubuntu 12.04

- maybe webrev needs better help by way of properly explaining what the options actually do. BTW, the default path represents our (the IBM) clone path. Thanx again , Best rgds , Dave P On Thu, 2013-11-14 at 01:36 +0400, Anthony Petrov wrote: Hi Dave, The .hg/hgrc in your repo seems to ha

Re: webrev.ksh on Ubuntu 12.04

Hi Dave, The .hg/hgrc in your repo seems to have an incorrect default-push path. Here's mine for example: [paths] default = http://hg.openjdk.java.net/jdk8/awt/jdk default-push = ssh://anth...@hg.openjdk.java.net/jdk8/awt-gate/jdk Your hgrc should look somewhat similar (just replace the user

Re: RFR: 8026491: Typos in string literals

Looks fine to me. -- best regards, Anthony On 10/30/2013 03:48 PM, sergey malenkov wrote: Unfortunately the webrev's wdiff is failed, so I've prepared the following page for your convenience: http://cr.openjdk.java.net/~malenkov/8026491.8.0/diff.html

Re: CFV: New JDK8 Committer: Vadim Pakhnushev (vadim)

Vote: YES -- best regards, Anthony On 10/22/2013 11:24 PM, Phil Race wrote: I hereby nominate Vadim Pakhnushev to JDK8 committer. Vadim has been working for the Java client team for over a year with a substantial amount of that time working on bugs in Java 2D in JDK 8. He has substantial backg

Re: CFV: New JDK 8 Reviewer: Seán Coffey

Vote: YES -- best regards, Anthony On 10/09/2013 10:51 PM, Chris Hegarty wrote: I hereby nominate Seán Coffey (coffeys) to JDK 8 Reviewer. Seán has worked in the core libraries and networking area since before the beginning of OpenJDK. Seán is probably best known for his role as 7u maintainer,

Re: CFV: New JDK8 Committer Brent Christian (bchristi)

Vote: YES -- best regards, Anthony On 09/27/2013 01:18 AM, Mike Duigou wrote: I hereby nominate Brent Christian to jdk8 Committer. Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in

Re: CFV: New JDK8 Committer Brian Burkhalter (bpb)

Vote: YES -- best regards, Anthony On 08/15/13 01:23, Mike Duigou wrote: I hereby nominate Brian Burkhalter to jdk8 Committer. Brian joined the Oracle OpenJDK team a couple of months ago and has quickly become a very active contributor to the long neglected numerics area. In addition to cont

Re: CFV: New JDK8 Reviewer: Anton Tarasov

Vote: YES -- best regards, Anthony On 08/02/2013 02:32 PM, Artem Ananiev wrote: I hereby nominate Anton Tarasov (OpenJDK user name: ant) to JDK8 Reviewer. Anton is currently a Committer in JDK7, 7u, 8, and OpenJFX projects. He is a member of AWT/Swing and JavaFX groups at Oracle, now working

Re: CFV: New JDK8 Committer: Anton Litvinov

Vote: YES -- best regards, Anthony On 06/25/2013 07:22 PM, Alexander Potochkin wrote: I hereby nominate Anton Litvinov to jdk8 Committer. Anton has been a member of the Java SE sustaining team for more then a year. He has spent most of that time working on client issues. He has contributed se

Re: CFV: New JDK8 Committer: Vladislav Karnaukhov

Vote: YES -- best regards, Anthony On 06/05/13 20:54, Alexander Potochkin wrote: I hereby nominate Vladislav Karnaukhov to jdk8 Committer. Vlad has been a member of the Java SE sustaining team for five years. He has spent most of that time working on customer escalations. He has contributed s

Re: CFV: New JDK8 Committer: Mikhail Cherkasov

Vote: YES -- best regards, Anthony On 05/01/13 19:31, alexander potochkin wrote: I hereby nominate Mikhail Cherkasov to jdk8 Committer. Mikhail has been a member of the Java SE sustaining team for a year now. He has spent most of that time working on the client-side issues (Swing/AWT/Java 2D)

Re: Define JNIEXPORT as visibility default with GCC?

All right then. I'm fine with the fix. -- best regards, Anthony On 4/12/2013 19:22, David DeHaven wrote: I totally agree that the current usage of JNIEXPORT in typedefs in AWT and 2D code is a bug. My concern, however, is about other code that mistakenly adapted the same pattern. After this

Re: CFV: New JDK8 Committer: Petr Pchelko

Vote: YES -- best regards, Anthony On 4/12/2013 13:16, Artem Ananiev wrote: I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to JDK8 Committer. Petr is a member of AWT/Swing and JavaFX teams at Oracle. Here is the list of his contributions to JDK (JavaFX list is to come!): htt

Re: Define JNIEXPORT as visibility default with GCC?

I totally agree that the current usage of JNIEXPORT in typedefs in AWT and 2D code is a bug. My concern, however, is about other code that mistakenly adapted the same pattern. After this fix its compilation will fail. -- best regards, Anthony On 4/9/2013 19:39, David DeHaven wrote: [ cc'ing

Re: sun.awt.X11 logs still using String + (waste)

Le 4 avr. 2013 14:08, "Laurent Bourgès" mailto:bourges.laur...@gmail.com>> a écrit : Ok, I can provide an updated patch after finding / fixing all usages. Probably in 1 or 2 days, Laurent 2013/4/4 An

Re: Define JNIEXPORT as visibility default with GCC?

Hi Coleen, Martin, [ cc'ing awt-dev@ ] Probably gcc can't process typedefs with visibility attributes specified, hence the changes to AWT. Generally they look good. However, I'm concerned with the compatibility impact of this change. I suppose that 3rd-party JNI libraries could use such a pa

Re: CFV: New OpenJDK8 Reviewer: Omair Majid

Vote: YES -- best regards, Anthony On 4/9/2013 0:56, Andrew Hughes wrote: I hereby nominate Omair Majid for the position of OpenJDK 8 reviewer. Omair has been working on OpenJDK since his internship at Red Hat in May 2008, and has continued doing so after obtaining full-time employment in June

Re: CFV: New jdk8 Reviewer: Erik Joelsson

Vote: YES -- best regards, Anthony On 3/22/2013 19:48, Alan Bateman wrote: I hereby nominate Erik Joelsson to jdk8 Reviewer. Erik has Committer role on the jdk8 and build-infra projects. He is the author of more than 70 changes pushed to the jdk8 forest over the last 9 months. He has also b

Re: CFV: New JDK8 Committer: Konstantin Shefov

Vote: YES -- best regards, Anthony On 1/18/2013 14:17, Artem Ananiev wrote: I hereby nominate Konstantin Shefov (OpenJDK user name: kshefov) to JDK8 Committer. Konstantin is a member of Client SQE team at Oracle. He has been making AWT, Swing, and Java2D tests more better and more reliable

Re: CFV: New JDK8 Reviewer: Alexander Scherbatiy

Vote: YES -- best regards, Anthony On 12/12/2012 19:01, Artem Ananiev wrote: I hereby nominate Alexander Scherbatiy (OpenJDK user name: alexsch) to Reviewer in JDK8 project. Alexander is a member of AWT and Swing groups at Oracle. He has committed 50+ changesets to JDK7u and JDK8. He is al

Re: CFV: New JDK8 Reviewer: Sergey Bylokhov

Vote: YES -- best regards, Anthony On 12/4/2012 6:13 PM, Artem Ananiev wrote: I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to Reviewer in JDK8 project. Sergey is a member of AWT group at Oracle and committer in JDK6, JDK7, JDK7u, and JDK8 projects. He has contributed a numbe

Re: Review Request: 8004151: build-infra: Generating X11 wrapper offset file is not cross compilable (AWT folks look here!)

CC'ing awt-dev@, Yuri, and Artem. -- best regards, Anthony On 11/29/12 18:27, Fredrik Öhrström wrote: The GensrcX11Wrapper.gmk makefile creates a new sizes.32 or sizes.64 by running a generated C program that performs many sizeof calculations on X11 structures. This is cross compileable. Fortu

Re: Objective-C and jcheck

Hi Kelly, John, There's quite a few .m files in AWT area, and we just can't get rid of them since we have to access native GUI API. At the same time, we [AWT team] DO want to keep these files clean (i.e. w/o TABs, etc.). Enforcing a jcheck verification for these files would be the most natural

Re: CFV: New JDK8 Committer: Leonid Romanov

Vote: YES -- best regards, Anthony On 8/21/2012 2:37 PM, Artem Ananiev wrote: I hereby nominate Leonid Romanov (OpenJDK user name: leonidr) to JDK8 Committer. Leonid is a member of AWT group. He has contributed many changes to AWT and Swing code into 7u and 8, mostly for Mac OS X platform:

Re: CFV: New JDK8 Committer: Jonathan Lu

Vote: YES -- best regards, Anthony On 06/14/12 17:49, Artem Ananiev wrote: I hereby nominate Jonathan Lu (OpenJDK user name: luchsh) to JDK8 Committer. Jonathan has contributed a number of changes to different JDK areas: http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=luchsh Votes are due b

Re: CFV: New JDK8 Committer: Oleg Pekhovskiy

Vote: YES. -- best regards, Anthony On 2/25/2012 12:32 AM, Artem Ananiev wrote: I hereby nominate Oleg Pekhovskiy (OpenJDK user name: bagiras) to JDK8 Committer. Oleg is currently a JDK8 Author and a member of AWT group. He has contributed a number of fixes, mostly in AWT area, including s

Re: RFR: 7113349 JDK8 port to macosx

27;ll probably be generating a new webrev soon with changes to jprt configuration and the langtools changes mentioned by Jim, but let me know anything else you notice in the meantime. Thanks, Michael On 23/02/12 12:27, Anthony Petrov wrote: Hi Michael, I've noticed your webrev adds fi

Re: RFR: 7113349 JDK8 port to macosx

Hi Michael, I've noticed your webrev adds files belonging to the legacy MToolkit (e.g. src/solaris/native/sun/awt/awt_*). These files have been removed explicitly from JDK 8 with a fix for 6996291. I think we should examine the list of hg add'ed files carefully to see if they were really add

Re: Warning Fixes from LJC Hack Session

Hi Michael, The changes to List.java and Window.java look fine to me. -- best regards, Anthony On 2/4/2012 8:40 PM, Michael Barker wrote: Patch with BeanSupportContext changes removed. Mike. On Sat, Feb 4, 2012 at 3:48 PM, Chris Hegarty wrote: I think you should just drop the changes to th

Re: [8] Review request for 7117008: warning cleanup in sun.awt

Hi Artem, The fix looks fine to me. -- best regards, Anthony On 12/5/2011 11:37 PM, Artem Ananiev wrote: Hi, AWT team, here is a fix for 7117008, which is about javac warning cleanup in the sun.awt package: http://cr.openjdk.java.net/~art/jdk8/7117008/ As a part of this fix, I'm deleting