Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-13 Thread Joe Darcy
Hello, A follow-up, some lint warnings are now enabled: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/262a625809fd At least a few more should be turned out before JDK 8 GA! Thanks, -Joe On 09/03/2013 06:40 PM, Joe Darcy wrote: Hello, Over the last few months, over on core-libs-dev there h

Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-04 Thread John Rose
+1 As new warnings are introduced it is a moving target. But it is a very good target. -- John (on my iPhone) On Sep 3, 2013, at 6:40 PM, Joe Darcy wrote: > I think it is time for selected categories of javac lint warnings to be > enabled during the build under -Werror.

Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-04 Thread Joe Darcy
Hi Stuart, On 9/4/2013 2:09 PM, Stuart Marks wrote: Hi Joe, As you might imagine, I'm all for it. Which specific warnings categories do you envision enabling? What worked (as of about two weeks ago) was a javac lint setting of -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfi

Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-04 Thread Stuart Marks
Hi Joe, As you might imagine, I'm all for it. Which specific warnings categories do you envision enabling? Some work in the makefiles is probably necessary provide default settings for warnings/errors and to make the settings easily overridable from the command line. The current variable tha

Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-03 Thread Joe Darcy
Hello, Over the last few months, over on core-libs-dev there have been various clean up efforts concerning the Java code in the JDK 8 "jdk" repo, resolving both javac lint and doclint warnings. With these clean ups in place, I think it is time for selected categories of javac lint warnings t