Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Alan Bateman
On 31/01/2012 00:08, Stuart Marks wrote: : (Crap. I've just realized that I never pushed Deepak Bhole's java.text patches from December. To avoid conflicts, I'd suggest avoiding changes to src/share/classes/java/text. Other areas should be fair game.) Another one is java.util. Rémi provided a p

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Rémi Forax
On 01/31/2012 09:07 AM, Alan Bateman wrote: On 31/01/2012 00:08, Stuart Marks wrote: : (Crap. I've just realized that I never pushed Deepak Bhole's java.text patches from December. To avoid conflicts, I'd suggest avoiding changes to src/share/classes/java/text. Other areas should be fair game

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Martijn Verburg
Hi Stuart, > I don't know if anyone from Oracle will be involved in this. I can try to > hang out on the #openjdk IRC channel, and I can review and push a couple of > the patches if you need help doing so. What time do you guys think you'll be > online? We'll be on-line around 1830+ GMT, on the 3

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Martijn Verburg
Hi all, >> On 31/01/2012 00:08, Stuart Marks wrote: >>> >>> (Crap. I've just realized that I never pushed Deepak Bhole's java.text >>> patches from December. To avoid conflicts, I'd suggest avoiding changes to >>> src/share/classes/java/text. Other areas should be fair game.) >> >> Another one is

AIX and OpenJDK

2012-01-31 Thread Steve Poole
hi all, Last year there was a discussion [1] about adding AIX platform support into OpenJDK. I'd like to pick up that conversation and complete this work. To recap the salient points of the thread: 1: The scale of the changes to support AIX without Hotspot are small ( ~ 300 LOC) There

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Martijn Verburg
Hi all, Some corrections in-line (error between chair and keyboard ;p) On 31 January 2012 10:01, Martijn Verburg wrote: >> I've added an awk script to the main Warnings Cleanup page [2] that does >> some analysis of warnings from a build log. I used this script to keep track >> of the warnings c

Re: AIX and OpenJDK

2012-01-31 Thread Alan Bateman
On 31/01/2012 10:49, Steve Poole wrote: hi all, Last year there was a discussion [1] about adding AIX platform support into OpenJDK. I'd like to pick up that conversation and complete this work. To recap the salient points of the thread: 1: The scale of the changes to support AIX withou

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Stuart Marks
On 1/31/12 2:02 AM, Martijn Verburg wrote: On 31/01/2012 00:08, Stuart Marks wrote: (Crap. I've just realized that I never pushed Deepak Bhole's java.text patches from December. To avoid conflicts, I'd suggest avoiding changes to src/share/classes/java/text. Other areas should be fair game.) A

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Martijn Verburg
On 31/01/2012 00:08, Stuart Marks wrote: > > (Crap. I've just realized that I never pushed Deepak Bhole's java.text > patches from December. To avoid conflicts, I'd suggest avoiding changes > to > src/share/classes/java/text. Other areas should be fair game.)

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread John Yeary
Hello Martijn, I was trying to connect via IRC, but my company is blocking it on all our networks including the "unsecured" network for guests. If I get a chance, I will try to connect from a remote location just to keep track of what you are doing. Have a great time! I see you are starting in les

Re: AIX and OpenJDK

2012-01-31 Thread John Yeary
Hello All, I like the idea of a port which eventually gets migrated into the main line. I am using the BSD port with PPC. The build was done on an Apple G5 fully loaded. The Zero build I am using works, but the build alone took 3 days using another Zero build to bootstrap. My results may not be ty

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Mike Duigou
On Jan 31 2012, at 09:15 , Martijn Verburg wrote: > On 31/01/2012 00:08, Stuart Marks wrote: >> >> (Crap. I've just realized that I never pushed Deepak Bhole's java.text >> patches from December. To avoid conflicts, I'd suggest avoiding changes >> to >> src/share/classes/

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Martijn Verburg
>> On 31/01/2012 00:08, Stuart Marks wrote: >>> >>> (Crap. I've just realized that I never pushed Deepak Bhole's java.text >>> patches from December. To avoid conflicts, I'd suggest avoiding changes >>> to >>> src/share/classes/java/text. Other areas should be fair game.) >>

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Stuart Marks
On 1/31/12 10:57 AM, Martijn Verburg wrote: I would encourage anyone who is interested to continue the review of Rémi's patch. More review is always helpful and there was at least once case that Rémi identified where he thought the patch could be improved with additional effort. TL;DR -- If yo

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Mike Duigou
> Is there a bug id/reference for Remi's patch? Happy to try and help > review (not that I'm an experienced OpenJDK person by any stretch of > the imagination). > > Cheers, > Martijn There is not bug # yet but here is the current webrev/patch: http://cr.openjdk.java.net/~forax/WarningDay1/web

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Stuart Marks
Ah, it looks like you guys wrapped up while I was taking my lunch break. I hope your hack session was fun and productive. There was a question on IRC about the serialization warnings. There's some additional information I wanted to add, so I'll post it here for everyone's benefit. -- The co

Re: AIX and OpenJDK

2012-01-31 Thread Kelly O'Hair
On Jan 31, 2012, at 2:49 AM, Steve Poole wrote: > > hi all, > > Last year there was a discussion [1] about adding AIX platform support into > OpenJDK. I'd like to pick up that conversation and complete this work. > > To recap the salient points of the thread: > > 1: The scale of the change

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread John Rose
On Jan 31, 2012, at 1:50 PM, Stuart Marks wrote: > An anonymous inner class -- actually any inner class or non-static nested > class -- has a reference to an "enclosing instance" It only strengthen's your already unassailable conclusion, but I'll add: ... may have a reference to an "enclosing

Re: AIX and OpenJDK

2012-01-31 Thread David Holmes
Stepping up a level I think we need to address the way we currently arrange our sources and build files along OS/architecture lines before trying to integrate any further ports into mainline (including the OSX port that is currently off-to-the-side in 7u-osx). The initial scheme (Windows else n

Re: Java User Group - Warnings clean-up hack day - 31st of Jan

2012-01-31 Thread Dalibor Topic
On 1/31/12 11:01 AM, Martijn Verburg wrote: > I've at least got read access to that wiki (I grabbed a login after > Dalibor made the > shift). If you let me know off-list what your Oracle SSO id is, you can have write access, too. cheers, dalibor topic -- Oracle Dalibo